[jira] Created: (ODE-310) Fault in HTTP binding

Fault in HTTP binding
---------------------

                 Key: ODE-310
                 URL: https://issues.apache.org/jira/browse/ODE-310
             Project: ODE
          Issue Type: Sub-task
            Reporter: Alexis Midon


Wsdl HTTP binding completely skips faults. However it could be useful.
So ODE will support fault in HTTP binding.

For 500s if a fault is defined in the WSDL and the response body contains the corresponding xml doc, then reply with a fault ; else reply with failure.
For other codes (300s & 400s), reply with failure but put the response body in the details element and break down the status-line into 3 separate elements: HTTP-Version, Status-Code, Reason-Phrase. This will save some painful string manipulations with XPath.

<definitions xmlns:odex="http://www.apache.org/ode/type/extension/http">
    <wsdl:message name="PUTRequest">
        <wsdl:part name="articleId" type="xsd:string"/>
        <wsdl:part name="article" element="ns1:article"/>
    </wsdl:message>
    <wsdl:message name="UpdateFault">
        <wsdl:part name="comment" element="fault"/>
    </wsdl:message>
    <wsdl:message name="NoPartMessage"/>

    <wsdl:portType name="ArticlePortType">
        <wsdl:operation name="doPUT">
            <wsdl:input message="ns1:PUTRequest"/>
            <wsdl:output message="ns1:NoPartMessage"/>
            <wsdl:fault name="UpdateFailed" message="UpdateFault"/>
        </wsdl:operation>
    </wsdl:portType>

<wsdl:binding name="binding" type="ns1:ArticlePortType">
    <wsdl:operation name="doPUT">
            <http:operation location=""/>
            <odex:binding verb="PUT"/>
            <wsdl:input>
                <http:urlReplacement/>
                <!-- fault binding -->
                <odex:fault name="UpdateFailed"/>
            </wsdl:input>
            <wsdl:output/>
        </wsdl:operation>
</bind>
</definitions>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/ODE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexis Midon resolved ODE-310.
------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3
                   1.2

committed an implementation on trunk and 1.1

> Fault in HTTP binding
> ---------------------
>
>                 Key: ODE-310
>                 URL: https://issues.apache.org/jira/browse/ODE-310
>             Project: ODE
>          Issue Type: Sub-task
>            Reporter: Alexis Midon
>             Fix For: 1.2, 1.3
>
>
> Wsdl HTTP binding completely skips faults. However it could be useful.
> So ODE will support fault in HTTP binding.
> For 500s if a fault is defined in the WSDL and the response body contains the corresponding xml doc, then reply with a fault ; else reply with failure.
> For other codes (300s & 400s), reply with failure but put the response body in the details element and break down the status-line into 3 separate elements: HTTP-Version, Status-Code, Reason-Phrase. This will save some painful string manipulations with XPath.
> <definitions xmlns:odex="http://www.apache.org/ode/type/extension/http">
>     <wsdl:message name="PUTRequest">
>         <wsdl:part name="articleId" type="xsd:string"/>
>         <wsdl:part name="article" element="ns1:article"/>
>     </wsdl:message>
>     <wsdl:message name="UpdateFault">
>         <wsdl:part name="comment" element="fault"/>
>     </wsdl:message>
>     <wsdl:message name="NoPartMessage"/>
>     <wsdl:portType name="ArticlePortType">
>         <wsdl:operation name="doPUT">
>             <wsdl:input message="ns1:PUTRequest"/>
>             <wsdl:output message="ns1:NoPartMessage"/>
>             <wsdl:fault name="UpdateFailed" message="UpdateFault"/>
>         </wsdl:operation>
>     </wsdl:portType>
> <wsdl:binding name="binding" type="ns1:ArticlePortType">
>     <wsdl:operation name="doPUT">
>             <http:operation location=""/>
>             <odex:binding verb="PUT"/>
>             <wsdl:input>
>                 <http:urlReplacement/>
>                 <!-- fault binding -->
>                 <odex:fault name="UpdateFailed"/>
>             </wsdl:input>
>             <wsdl:output/>
>         </wsdl:operation>
> </bind>
> </definitions>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/ODE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexis Midon updated ODE-310:
-----------------------------

    Assignee: Alexis Midon

> Fault in HTTP binding
> ---------------------
>
>                 Key: ODE-310
>                 URL: https://issues.apache.org/jira/browse/ODE-310
>             Project: ODE
>          Issue Type: Sub-task
>            Reporter: Alexis Midon
>            Assignee: Alexis Midon
>             Fix For: 1.2, 1.3
>
>
> Wsdl HTTP binding completely skips faults. However it could be useful.
> So ODE will support fault in HTTP binding.
> For 500s if a fault is defined in the WSDL and the response body contains the corresponding xml doc, then reply with a fault ; else reply with failure.
> For other codes (300s & 400s), reply with failure but put the response body in the details element and break down the status-line into 3 separate elements: HTTP-Version, Status-Code, Reason-Phrase. This will save some painful string manipulations with XPath.
> <definitions xmlns:odex="http://www.apache.org/ode/type/extension/http">
>     <wsdl:message name="PUTRequest">
>         <wsdl:part name="articleId" type="xsd:string"/>
>         <wsdl:part name="article" element="ns1:article"/>
>     </wsdl:message>
>     <wsdl:message name="UpdateFault">
>         <wsdl:part name="comment" element="fault"/>
>     </wsdl:message>
>     <wsdl:message name="NoPartMessage"/>
>     <wsdl:portType name="ArticlePortType">
>         <wsdl:operation name="doPUT">
>             <wsdl:input message="ns1:PUTRequest"/>
>             <wsdl:output message="ns1:NoPartMessage"/>
>             <wsdl:fault name="UpdateFailed" message="UpdateFault"/>
>         </wsdl:operation>
>     </wsdl:portType>
> <wsdl:binding name="binding" type="ns1:ArticlePortType">
>     <wsdl:operation name="doPUT">
>             <http:operation location=""/>
>             <odex:binding verb="PUT"/>
>             <wsdl:input>
>                 <http:urlReplacement/>
>                 <!-- fault binding -->
>                 <odex:fault name="UpdateFailed"/>
>             </wsdl:input>
>             <wsdl:output/>
>         </wsdl:operation>
> </bind>
> </definitions>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614939#action_12614939 ]

Alexis Midon commented on ODE-310:
----------------------------------

FAULT: these status codes will trigger a fault if the body element matches a fault declaration
############
500_INTERNAL_SERVER_ERROR
501_NOT_IMPLEMENTED
502_BAD_GATEWAY
505_HTTP_VERSION_NOT_SUPPORTED
400_BAD_REQUEST
402_PAYMENT_REQUIRED
403_FORBIDDEN
404_NOT_FOUND
405_METHOD_NOT_ALLOWED
406_NOT_ACCEPTABLE
407_PROXY_AUTHENTICATION_REQUIRED
409_CONFLICT
410_GONE
412_PRECONDITION_FAILED
413_REQUEST_TOO_LONG
414_REQUEST_URI_TOO_LONG
415_UNSUPPORTED_MEDIA_TYPE
411_LENGTH_REQUIRED
416_REQUESTED_RANGE_NOT_SATISFIABLE
417_EXPECTATION_FAILED

FAILURE: these status codes will trigger a failure
##################
503_SERVICE_UNAVAILABLE
504_GATEWAY_TIMEOUT
401_UNAUTHORIZED
408_REQUEST_TIMEOUT

> Fault in HTTP binding
> ---------------------
>
>                 Key: ODE-310
>                 URL: https://issues.apache.org/jira/browse/ODE-310
>             Project: ODE
>          Issue Type: Sub-task
>            Reporter: Alexis Midon
>            Assignee: Alexis Midon
>             Fix For: 1.2, 1.3
>
>
> Wsdl HTTP binding completely skips faults. However it could be useful.
> So ODE will support fault in HTTP binding.
> For 500s if a fault is defined in the WSDL and the response body contains the corresponding xml doc, then reply with a fault ; else reply with failure.
> For other codes (300s & 400s), reply with failure but put the response body in the details element and break down the status-line into 3 separate elements: HTTP-Version, Status-Code, Reason-Phrase. This will save some painful string manipulations with XPath.
> <definitions xmlns:odex="http://www.apache.org/ode/type/extension/http">
>     <wsdl:message name="PUTRequest">
>         <wsdl:part name="articleId" type="xsd:string"/>
>         <wsdl:part name="article" element="ns1:article"/>
>     </wsdl:message>
>     <wsdl:message name="UpdateFault">
>         <wsdl:part name="comment" element="fault"/>
>     </wsdl:message>
>     <wsdl:message name="NoPartMessage"/>
>     <wsdl:portType name="ArticlePortType">
>         <wsdl:operation name="doPUT">
>             <wsdl:input message="ns1:PUTRequest"/>
>             <wsdl:output message="ns1:NoPartMessage"/>
>             <wsdl:fault name="UpdateFailed" message="UpdateFault"/>
>         </wsdl:operation>
>     </wsdl:portType>
> <wsdl:binding name="binding" type="ns1:ArticlePortType">
>     <wsdl:operation name="doPUT">
>             <http:operation location=""/>
>             <odex:binding verb="PUT"/>
>             <wsdl:input>
>                 <http:urlReplacement/>
>                 <!-- fault binding -->
>                 <odex:fault name="UpdateFailed"/>
>             </wsdl:input>
>             <wsdl:output/>
>         </wsdl:operation>
> </bind>
> </definitions>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.