« Return to Thread: [jira] Created: (NET-208) TelnetInputStream swallows interruptedexception as IOException

[jira] Created: (NET-208) TelnetInputStream swallows interruptedexception as IOException

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View in Thread

TelnetInputStream swallows interruptedexception as IOException
--------------------------------------------------------------

                 Key: NET-208
                 URL: https://issues.apache.org/jira/browse/NET-208
             Project: Commons Net
          Issue Type: Bug
    Affects Versions: 1.4
            Reporter: Jan Van Besien


The TelnetInputStream catches InterruptedException in the read() method (line 342) and throws a new IOException without wrapping the InterruptedException. This means that the fact that the read() method was interrupted can hardly be distinguished from any other IOException.

I use thread interruption as a cancellation mechanism for a thread that uses the TelnetInputStream to read data.

The read method is not allowed to throw InterruptedException, so I propose to fix it by at least wrapping the underlying InterruptedException:

catch (InterruptedException e)
{
    throw new IOException("Fatal thread interruption during read.", e);
}


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

 « Return to Thread: [jira] Created: (NET-208) TelnetInputStream swallows interruptedexception as IOException

LightInTheBox - Buy quality products at wholesale price