[jira] Created: (MYFACES-1900) <f:param> violates the JSF spec

[My Faces - Dev mailing list]

<f:param> violates the JSF spec
-------------------------------

                 Key: MYFACES-1900
                 URL: https://issues.apache.org/jira/browse/MYFACES-1900
             Project: MyFaces Core
          Issue Type: Bug
          Components: JSR-252
    Affects Versions: 1.2.3
         Environment: MSIE
            Reporter: Gertjan van Oosten
             Fix For: 1.2.2


Since nothing seems to be happening with MYFACES-1723, I'm raising this major bug against the JSF 1.2 specification.

Summary: MyFaces 1.2.3 does not support <f:param name="id" /> under Microsoft Internet Explorer, which violates the JSF 1.2 specification;
cf. section 4.1.11 UIParameter and section 9.4.8 <f:param> the 'name' attribute of <f:param> is a String with no specific exceptions for a name of "id".

Some additional details: with myfaces-api-1.2.2.jar and myfaces-impl-1.2.2.jar, using <f:param name="id" /> works;
with myfaces-api-1.2.3.jar and myfaces-impl-1.2.3.jar using <f:param name="id" /> fails, e.g. an

  <h:commandLink actionListener="#{myController.selectId}">
    <f:param name="id" value="123" />
  </h:commandLink>

when submitted does not pass the param to selectId(), that is: the value in

  public void selectId(ActionEvent event)
  {
     final String value = FacesContext.getCurrentInstance().getExternalContext().getRequestParameterMap().get("id");
  }

remains null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/MYFACES-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618309#action_12618309 ]

Gertjan van Oosten commented on MYFACES-1900:
---------------------------------------------

Copied from MyFaces Dev list:

As quoted from Gertjan van Oosten <gertjan@...>:

> To follow-up on my own message: the classes from r645741 seem to work,
> the classes from r647237 fail under MSIE.  So the incompatible change
> seems to appear first after:
>
>   2008-04-11 17:39  lu4242
>         * [r647237]
>           core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java,
>           core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java,
>           core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java:
>           fix MYFACES-1855 hidden fields created when using h:commandLink
>           and f:param should be created and removed using javascript
>
>
> [All this is in myfaces/shared/trunk_3.0.x]

Then if I re-enable the lines on trunk commented out in r647237 in
HtmlButtonRendererBase and HtmlLinkRendererBase, it works again.

I'll attach a patch

> <f:param> violates the JSF spec
> -------------------------------
>
>                 Key: MYFACES-1900
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1900
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-252
>    Affects Versions: 1.2.3
>         Environment: MSIE
>            Reporter: Gertjan van Oosten
>             Fix For: 1.2.2
>
>         Attachments: myfaces-1900-patch.txt
>
>
> Since nothing seems to be happening with MYFACES-1723, I'm raising this major bug against the JSF 1.2 specification.
> Summary: MyFaces 1.2.3 does not support <f:param name="id" /> under Microsoft Internet Explorer, which violates the JSF 1.2 specification;
> cf. section 4.1.11 UIParameter and section 9.4.8 <f:param> the 'name' attribute of <f:param> is a String with no specific exceptions for a name of "id".
> Some additional details: with myfaces-api-1.2.2.jar and myfaces-impl-1.2.2.jar, using <f:param name="id" /> works;
> with myfaces-api-1.2.3.jar and myfaces-impl-1.2.3.jar using <f:param name="id" /> fails, e.g. an
>   <h:commandLink actionListener="#{myController.selectId}">
>     <f:param name="id" value="123" />
>   </h:commandLink>
> when submitted does not pass the param to selectId(), that is: the value in
>   public void selectId(ActionEvent event)
>   {
>      final String value = FacesContext.getCurrentInstance().getExternalContext().getRequestParameterMap().get("id");
>   }
> remains null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

     [ https://issues.apache.org/jira/browse/MYFACES-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gertjan van Oosten updated MYFACES-1900:
----------------------------------------

    Status: Patch Available  (was: Open)

> <f:param> violates the JSF spec
> -------------------------------
>
>                 Key: MYFACES-1900
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1900
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-252
>    Affects Versions: 1.2.3
>         Environment: MSIE
>            Reporter: Gertjan van Oosten
>             Fix For: 1.2.2
>
>         Attachments: myfaces-1900-patch.txt
>
>
> Since nothing seems to be happening with MYFACES-1723, I'm raising this major bug against the JSF 1.2 specification.
> Summary: MyFaces 1.2.3 does not support <f:param name="id" /> under Microsoft Internet Explorer, which violates the JSF 1.2 specification;
> cf. section 4.1.11 UIParameter and section 9.4.8 <f:param> the 'name' attribute of <f:param> is a String with no specific exceptions for a name of "id".
> Some additional details: with myfaces-api-1.2.2.jar and myfaces-impl-1.2.2.jar, using <f:param name="id" /> works;
> with myfaces-api-1.2.3.jar and myfaces-impl-1.2.3.jar using <f:param name="id" /> fails, e.g. an
>   <h:commandLink actionListener="#{myController.selectId}">
>     <f:param name="id" value="123" />
>   </h:commandLink>
> when submitted does not pass the param to selectId(), that is: the value in
>   public void selectId(ActionEvent event)
>   {
>      final String value = FacesContext.getCurrentInstance().getExternalContext().getRequestParameterMap().get("id");
>   }
> remains null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.