[jira] Created: (MRM-915) NPE with rss links

NPE with rss links
------------------

                 Key: MRM-915
                 URL: http://jira.codehaus.org/browse/MRM-915
             Project: Archiva
          Issue Type: Bug
          Components: Users/Security, web application
    Affects Versions: 1.1.1
            Reporter: Emmanuel Venisse


With LDAP, I get the following exception when I use the rss icon on the browse page:

{noformat}
java.lang.NullPointerException
        org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
        org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
        org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
        org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
        javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
        javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
        com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
        com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
        com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
        com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
{noformat}

My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null

Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse updated MRM-915:
---------------------------------

    Fix Version/s: 1.1.2

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching reassigned MRM-915:
------------------------------------

    Assignee: Maria Odea Ching

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145983#action_145983 ]

Chris Anders commented on MRM-915:
----------------------------------

i get a similar NPE after setting up AD (LDAP) authentication when a user who is yet to login clicks on browse or attempts a search.

Aug 26, 2008 2:21:02 AM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet default threw exception
java.lang.NullPointerException
        at org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
        at org.apache.maven.archiva.web.action.BrowseAction.getObservableRepos(BrowseAction.java:131)
        at org.apache.maven.archiva.web.action.BrowseAction.browse(BrowseAction.java:65)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)

in security.properties i have defined
redback.default.guest=archiva

This user exists in our LDAP as i can click login and login with this archiva user credentials.

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146573#action_146573 ]

Maria Odea Ching commented on MRM-915:
--------------------------------------

I can't seem to replicate the NPE, but I'm getting a blank browse page even if I have assigned the 'guest' user the Global Repository Observer role. I get the same blank page in browse even if I'm logged in as admin. I can perform a search though except when I click on a search result, I get an 'Unable to find project model for [org.apache.maven.plugins:maven-clean-plugin:2.2]' error but not NPE.

I have the following configuration in my security.properties:

user.manager.impl=ldap
ldap.user.store.enabled=true
ldap.bind.authenticator.enabled=true
redback.default.admin=admin
redback.default.guest=guest

security.policy.password.expiration.enabled=false
ldap.config.hostname=localhost
ldap.config.port=10389
ldap.config.base.dn=dc=redback,dc=plexus,dc=codehaus,dc=org
ldap.config.context.factory=com.sun.jndi.ldap.LdapCtxFactory
ldap.config.bind.dn=uid=admin,ou=system
ldap.config.password=XXXXX

Do we have the same configuration? Btw, I'm using ApacheDS and running on Linux 7.04.

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146574#action_146574 ]

Chris Anders commented on MRM-915:
----------------------------------

I only get this exception when i am not logged in and attempt to browse or run a search

Server - FreeBSD 6.3-STABLE
java version - diablo-1.5.0_07-b01, mixed mode
tomcat version - tomcat-5.5.26

running the archiva 1.1.1 war package on a default tomcat install with the dependency jars - mail.jar, activation.jar, derby.jar (as per the install docs)

security.properties file:
user.manager.impl=ldap
ldap.user.store.enabled=true
ldap.bind.authenticator.enabled=true
redback.default.admin=canders
redback.default.guest=tuser
security.policy.password.expiration.enabled=false

ldap.config.hostname=10.66.5.7
ldap.config.port=389
ldap.config.base.dn=OU=Users,OU=Velocity,DC=velsys,DC=local
ldap.config.context.factory=com.sun.jndi.ldap.LdapCtxFactory
ldap.config.bind.dn=cn=Predator,cn=Users,dc=velsys,dc=local
ldap.config.password=xxxxxxxxxxxxxxx
ldap.config.mapper.attribute.email=mail
ldap.config.mapper.attribute.fullname=name
ldap.config.mapper.attribute.user.id=mailNickname
ldap.config.mapper.attribute.user.object.class=user

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146575#action_146575 ]

Maria Odea Ching commented on MRM-915:
--------------------------------------

Hmm... I wasn't logged in too when I tried the to search & browse, but instead of the NPE I got the 'Unable to find project model...' error when I tried to access a search result and a blank browse page when I clicked on Browse. I was running the standalone though, I'll try deploying the war to tomcat and see if I'll get the NPEs.

Thanks for the quick reply Chris!

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146579#action_146579 ]

Emmanuel Venisse commented on MRM-915:
--------------------------------------

I don't use ldap for user.manager.impl, but cached. I don't think the problem is there.

To reproduce this issue, I think you must not use 'guest' for redback.default.guest property

My security.properties:
user.manager.impl=cached
ldap.bind.authenticator.enabled=true
redback.default.admin=adminuser
redback.default.guest=guestuser
security.policy.password.expiration.enabled=false

ldap.config.hostname=ldap_host
ldap.config.port=389
ldap.config.base.dn=o=MyBaseDN
ldap.config.context.factory=com.sun.jndi.ldap.LdapCtxFactory

ldap.config.mapper.attribute.email=mail
ldap.config.mapper.attribute.fullname=cn
#ldap.config.mapper.attribute.password=userPassword
ldap.config.mapper.attribute.user.id=uid
#ldap.config.mapper.attribute.user.base.dn=
ldap.config.mapper.attribute.user.object.class=inetOrgPerson
#ldap.config.mapper.attribute.user.filter=(attributeName=value)

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146580#action_146580 ]

Maria Odea Ching commented on MRM-915:
--------------------------------------

Ahh.. ok, I'll try that. Thanks Emm! :)

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146583#action_146583 ]

Maria Odea Ching commented on MRM-915:
--------------------------------------

Hmm.. I still did not get the NPE after using a different default guest and admin users. Instead, I got a 'You have access to no repositories. Ask your system administrator for access.' message when I clicked Browse even though my default guest user 'anotherGuest' has Global Repository Observer role.

Anyway, I think the problem is in the ArchivaXworkUser which uses a constant "guest" for the default guest account. It doesn't get it from the security.properties file.

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146584#action_146584 ]

Chris Anders commented on MRM-915:
----------------------------------

I can confirm that when i set the redback.default.guest=guest and create a guest user in my OU defined in ldap.config.base.dn=OU=Users,OU=Velocity,DC=velsys,DC=local that I now get 'You have access to no repositories. Ask your system administrator for access.

So i then logged in gave the new guest user the Global Repository Observer role, logged out and now browse and running searchs works!!!

Looks like you are correct with the constant "guest" being set somewhere in the code :)

good stuff :D

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146822#action_146822 ]

Maria Odea Ching commented on MRM-915:
--------------------------------------

I made some fixes in trunk -r691581. Could you verify if the NPE problem was fixed too? I still wasn't able to replicate the NPE previously, just the 'You have access to no repositories...' message given the guest user has Global Observer role so I was only able to verify that as fixed.

Thanks! :)

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching closed MRM-915.
--------------------------------

    Resolution: Fixed

> NPE with rss links
> ------------------
>
>                 Key: MRM-915
>                 URL: http://jira.codehaus.org/browse/MRM-915
>             Project: Archiva
>          Issue Type: Bug
>          Components: Users/Security, web application
>    Affects Versions: 1.1.1
>            Reporter: Emmanuel Venisse
>            Assignee: Maria Odea Ching
>             Fix For: 1.1.2
>
>
> With LDAP, I get the following exception when I use the rss icon on the browse page:
> {noformat}
> java.lang.NullPointerException
> org.apache.maven.archiva.security.DefaultUserRepositories.getObservableRepositoryIds(DefaultUserRepositories.java:76)
> org.apache.maven.archiva.web.rss.RssFeedServlet.getObservableRepos(RssFeedServlet.java:305)
> org.apache.maven.archiva.web.rss.RssFeedServlet.isAllowed(RssFeedServlet.java:267)
> org.apache.maven.archiva.web.rss.RssFeedServlet.doGet(RssFeedServlet.java:124)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> com.opensymphony.webwork.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:189)
> com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
> com.opensymphony.webwork.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:88)
> {noformat}
> My guest user have the global repository observer role but the login isn't 'guest' so securitySystem.getUserManager().findUser( principal ) return null
> Rss works fine if I use the repoId parameter on RssFessServlet instead of groupId/artifactId.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira