[jira] Created: (JS2-894) Deploy tool does not keep file dates in WAR file

[Jetspeed - Dev mailing list]

Deploy tool does not keep file dates in WAR file
------------------------------------------------

                 Key: JS2-894
                 URL: https://issues.apache.org/jira/browse/JS2-894
             Project: Jetspeed 2
          Issue Type: Bug
          Components: Deployment
    Affects Versions: 2.1.3
         Environment: Seen on Windows 2000 and Windows XP. Not tested on any other platform
            Reporter: Ron McNulty
            Priority: Minor


After adding a jar full of custom tags (written as JSP scriptlets) to my project, Tomcat insisted on compiling every page plus the tags from the jar on every page access. Needless to say, performance was a bit pedestrian.

Since then, I have researched the problem, but unfortunately it came right of its own accord - I cannot reproduce it. But I did notice that the re-packaged .war file emiited to Tomcat has all the file modification dates set to "now". I suspect the issue may arise when a run of the deploy tool spans two windows clock ticks.

The fix is trivial - I will attach an updated source file



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@...
For additional commands, e-mail: jetspeed-dev-help@...

[Jetspeed - Dev mailing list]

     [ https://issues.apache.org/jira/browse/JS2-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ron McNulty updated JS2-894:
----------------------------

    Attachment: JetspeedDeploy.java

Patched JetspeedDeploy.java attached

> Deploy tool does not keep file dates in WAR file
> ------------------------------------------------
>
>                 Key: JS2-894
>                 URL: https://issues.apache.org/jira/browse/JS2-894
>             Project: Jetspeed 2
>          Issue Type: Bug
>          Components: Deployment
>    Affects Versions: 2.1.3
>         Environment: Seen on Windows 2000 and Windows XP. Not tested on any other platform
>            Reporter: Ron McNulty
>            Priority: Minor
>         Attachments: JetspeedDeploy.java
>
>
> After adding a jar full of custom tags (written as JSP scriptlets) to my project, Tomcat insisted on compiling every page plus the tags from the jar on every page access. Needless to say, performance was a bit pedestrian.
> Since then, I have researched the problem, but unfortunately it came right of its own accord - I cannot reproduce it. But I did notice that the re-packaged .war file emiited to Tomcat has all the file modification dates set to "now". I suspect the issue may arise when a run of the deploy tool spans two windows clock ticks.
> The fix is trivial - I will attach an updated source file

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@...
For additional commands, e-mail: jetspeed-dev-help@...

[Jetspeed - Dev mailing list]

     [ https://issues.apache.org/jira/browse/JS2-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma reassigned JS2-894:
-----------------------------

    Assignee: Ate Douma

> Deploy tool does not keep file dates in WAR file
> ------------------------------------------------
>
>                 Key: JS2-894
>                 URL: https://issues.apache.org/jira/browse/JS2-894
>             Project: Jetspeed 2
>          Issue Type: Bug
>          Components: Deployment
>    Affects Versions: 2.1.3
>         Environment: Seen on Windows 2000 and Windows XP. Not tested on any other platform
>            Reporter: Ron McNulty
>            Assignee: Ate Douma
>            Priority: Minor
>         Attachments: JetspeedDeploy.java
>
>
> After adding a jar full of custom tags (written as JSP scriptlets) to my project, Tomcat insisted on compiling every page plus the tags from the jar on every page access. Needless to say, performance was a bit pedestrian.
> Since then, I have researched the problem, but unfortunately it came right of its own accord - I cannot reproduce it. But I did notice that the re-packaged .war file emiited to Tomcat has all the file modification dates set to "now". I suspect the issue may arise when a run of the deploy tool spans two windows clock ticks.
> The fix is trivial - I will attach an updated source file

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@...
For additional commands, e-mail: jetspeed-dev-help@...

[Jetspeed - Dev mailing list]

    [ https://issues.apache.org/jira/browse/JS2-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614885#action_12614885 ]

Ate Douma commented on JS2-894:
-------------------------------

Thanks Ron, I've looked at the patched file and your changes are sound.

Note: it would be handier if you provide diff files instead of complete patched sources to make it easier to review *and* apply.
 
I will commit these to the current trunk (Jetspeed-2.2-SNAPSHOT) as well to the 2.1.3-postrelease branch.

> Deploy tool does not keep file dates in WAR file
> ------------------------------------------------
>
>                 Key: JS2-894
>                 URL: https://issues.apache.org/jira/browse/JS2-894
>             Project: Jetspeed 2
>          Issue Type: Bug
>          Components: Deployment
>    Affects Versions: 2.1.3
>         Environment: Seen on Windows 2000 and Windows XP. Not tested on any other platform
>            Reporter: Ron McNulty
>            Assignee: Ate Douma
>            Priority: Minor
>         Attachments: JetspeedDeploy.java
>
>
> After adding a jar full of custom tags (written as JSP scriptlets) to my project, Tomcat insisted on compiling every page plus the tags from the jar on every page access. Needless to say, performance was a bit pedestrian.
> Since then, I have researched the problem, but unfortunately it came right of its own accord - I cannot reproduce it. But I did notice that the re-packaged .war file emiited to Tomcat has all the file modification dates set to "now". I suspect the issue may arise when a run of the deploy tool spans two windows clock ticks.
> The fix is trivial - I will attach an updated source file

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@...
For additional commands, e-mail: jetspeed-dev-help@...

[Jetspeed - Dev mailing list]

     [ https://issues.apache.org/jira/browse/JS2-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma resolved JS2-894.
---------------------------

       Resolution: Fixed
    Fix Version/s: 2.2

Patch applied both to the trunk (2.2-SNAPSHOT) and branch 2.1.3-postrelease.

Thanks Ron.

> Deploy tool does not keep file dates in WAR file
> ------------------------------------------------
>
>                 Key: JS2-894
>                 URL: https://issues.apache.org/jira/browse/JS2-894
>             Project: Jetspeed 2
>          Issue Type: Bug
>          Components: Deployment
>    Affects Versions: 2.1.3
>         Environment: Seen on Windows 2000 and Windows XP. Not tested on any other platform
>            Reporter: Ron McNulty
>            Assignee: Ate Douma
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: JetspeedDeploy.java
>
>
> After adding a jar full of custom tags (written as JSP scriptlets) to my project, Tomcat insisted on compiling every page plus the tags from the jar on every page access. Needless to say, performance was a bit pedestrian.
> Since then, I have researched the problem, but unfortunately it came right of its own accord - I cannot reproduce it. But I did notice that the re-packaged .war file emiited to Tomcat has all the file modification dates set to "now". I suspect the issue may arise when a run of the deploy tool spans two windows clock ticks.
> The fix is trivial - I will attach an updated source file

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@...
For additional commands, e-mail: jetspeed-dev-help@...