|

»

»

»

JDO - Development

[jira] Created: (JDO-583) Add license headers to source files.

View: New views

9 Messages — Rating Filter: Alert me

	[jira] Created: (JDO-583) Add license headers to source files. by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Add license headers to source files. ------------------------------------ Key: JDO-583 URL: https://issues.apache.org/jira/browse/JDO-583 Project: JDO Issue Type: Bug Components: tck2, tck2-legacy Affects Versions: JDO 2 maintenance release 1 Reporter: Craig Russell Assignee: Craig Russell Fix For: JDO 2 maintenance release 1 RAT reveals files that need Apache license headers: jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/ CompanyFactoryNewInstance.java jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml\ jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Commented: (JDO-583) Add license headers to source files. by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/JDO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580000#action_12580000 ] Craig Russell commented on JDO-583: ----------------------------------- Sending branches/2.1/tck2/src/java/org/apache/jdo/tck/pc/company/CompanyFactoryNewInstance.java Sending branches/2.1/tck2/src/uml/org/apache/jdo/tck/pc/shoppingcart/shoppingcart.argo.uml Sending branches/2.1/tck2-legacy/src/uml/org/apache/jdo/tck/pc/shoppingcart/shoppingcart.argo.uml Sending trunk/tck2/src/java/org/apache/jdo/tck/pc/company/CompanyFactoryNewInstance.java Sending trunk/tck2/src/uml/org/apache/jdo/tck/pc/shoppingcart/shoppingcart.argo.uml Sending trunk/tck2-legacy/src/uml/org/apache/jdo/tck/pc/shoppingcart/shoppingcart.argo.uml Transmitting file data ...... Committed revision 638503. > Add license headers to source files. > ------------------------------------ > > Key: JDO-583 > URL: https://issues.apache.org/jira/browse/JDO-583 > Project: JDO > Issue Type: Bug > Components: tck2, tck2-legacy > Affects Versions: JDO 2 maintenance release 1 > Reporter: Craig Russell > Assignee: Craig Russell > Fix For: JDO 2 maintenance release 1 > > > RAT reveals files that need Apache license headers: > jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/ CompanyFactoryNewInstance.java > jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml\ > jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Updated: (JDO-583) Add license headers to source files. by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/JDO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Russell updated JDO-583: ------------------------------ Fix Version/s: (was: JDO 2 maintenance release 1) JDO 2 maintenance release 2 Additional work is needed to be able to add comments to the signatures file. The fix is non-trivial (need to write a "skip" algorithm for the signature file parser). This is not critical for this release but should be done the next time we release. > Add license headers to source files. > ------------------------------------ > > Key: JDO-583 > URL: https://issues.apache.org/jira/browse/JDO-583 > Project: JDO > Issue Type: Bug > Components: tck2, tck2-legacy > Affects Versions: JDO 2 maintenance release 1 > Reporter: Craig Russell > Assignee: Craig Russell > Fix For: JDO 2 maintenance release 2 > > > RAT reveals files that need Apache license headers: > jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/ CompanyFactoryNewInstance.java > jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml\ > jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Assigned: (JDO-583) Add license headers to source files. by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/JDO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew T. Adams reassigned JDO-583: ------------------------------------ Assignee: Matthew T. Adams (was: Craig Russell) > Add license headers to source files. > ------------------------------------ > > Key: JDO-583 > URL: https://issues.apache.org/jira/browse/JDO-583 > Project: JDO > Issue Type: Bug > Components: tck2, tck2-legacy > Affects Versions: JDO 2 maintenance release 1 > Reporter: Craig Russell > Assignee: Matthew T. Adams > Fix For: JDO 2 maintenance release 2 > > > RAT reveals files that need Apache license headers: > jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/ CompanyFactoryNewInstance.java > jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml\ > jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Commented: (JDO-583) Add license headers to source files. by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/JDO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585627#action_12585627 ] Craig Russell commented on JDO-583: ----------------------------------- Adding Apache headers to src/conf/jdo-2_1-signatures.txt involves two changes: 1. Update the signatures.txt file to have the standard Apache java source code comment block at the beginning. 2. Modify the parser of the file to skip comments. There is already a method used to skip white space, and this method should be updated to skip comments as well. Take a look at "tck2/src/java/org/apache/jdo/tck/util/signature/SignatureVerifier.java" line 836 and add code to detect the "/" sequence and skip through the input stream until you find a trailing "/" and then continue to skip white space. > Add license headers to source files. > ------------------------------------ > > Key: JDO-583 > URL: https://issues.apache.org/jira/browse/JDO-583 > Project: JDO > Issue Type: Bug > Components: tck2, tck2-legacy > Affects Versions: JDO 2 maintenance release 1 > Reporter: Craig Russell > Assignee: Matthew T. Adams > Fix For: JDO 2 maintenance release 2 > > > RAT reveals files that need Apache license headers: > jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/ CompanyFactoryNewInstance.java > jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml\ > jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Assigned: (JDO-583) Add license headers to source files. by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/JDO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Russell reassigned JDO-583: --------------------------------- Assignee: Michelle Caisse (was: Matthew T. Adams) > Add license headers to source files. > ------------------------------------ > > Key: JDO-583 > URL: https://issues.apache.org/jira/browse/JDO-583 > Project: JDO > Issue Type: Bug > Components: tck2, tck2-legacy > Affects Versions: JDO 2 maintenance release 1 > Reporter: Craig Russell > Assignee: Michelle Caisse > Fix For: JDO 2 maintenance release 2 > > > RAT reveals files that need Apache license headers: > jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/ CompanyFactoryNewInstance.java > jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml\ > jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Updated: (JDO-583) Add license headers to source files. by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/JDO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michelle Caisse updated JDO-583: -------------------------------- Attachment: SignatureVerifier.patch The attached patch seems to work, but could use a bit of clean-up, I think. > Add license headers to source files. > ------------------------------------ > > Key: JDO-583 > URL: https://issues.apache.org/jira/browse/JDO-583 > Project: JDO > Issue Type: Bug > Components: tck2, tck2-legacy > Affects Versions: JDO 2 maintenance release 1 > Reporter: Craig Russell > Assignee: Michelle Caisse > Fix For: JDO 2 maintenance release 2 > > Attachments: SignatureVerifier.patch > > > RAT reveals files that need Apache license headers: > jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/ CompanyFactoryNewInstance.java > jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml\ > jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Commented: (JDO-583) Add license headers to source files. by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/JDO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623054#action_12623054 ] Craig Russell commented on JDO-583: ----------------------------------- Looks good. Were you planning on adding the // style comments? > Add license headers to source files. > ------------------------------------ > > Key: JDO-583 > URL: https://issues.apache.org/jira/browse/JDO-583 > Project: JDO > Issue Type: Bug > Components: tck2, tck2-legacy > Affects Versions: JDO 2 maintenance release 1 > Reporter: Craig Russell > Assignee: Michelle Caisse > Fix For: JDO 2 maintenance release 2 > > Attachments: SignatureVerifier.patch > > > RAT reveals files that need Apache license headers: > jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/ CompanyFactoryNewInstance.java > jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml\ > jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Resolved: (JDO-583) Add license headers to source files. by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/JDO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michelle Caisse resolved JDO-583. --------------------------------- Resolution: Fixed Completed: At revision: 687404 Works for both /* */ and // comments. License header added to signatures text file. > Add license headers to source files. > ------------------------------------ > > Key: JDO-583 > URL: https://issues.apache.org/jira/browse/JDO-583 > Project: JDO > Issue Type: Bug > Components: tck2, tck2-legacy > Affects Versions: JDO 2 maintenance release 1 > Reporter: Craig Russell > Assignee: Michelle Caisse > Fix For: JDO 2 maintenance release 2 > > Attachments: SignatureVerifier.patch > > > RAT reveals files that need Apache license headers: > jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/ CompanyFactoryNewInstance.java > jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml\ > jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt > jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/ shoppingcart.argo.uml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.