[jira] Created: (JCR-1600) Remove noLockHack in SharedItemStateManager

Remove noLockHack in SharedItemStateManager
-------------------------------------------

                 Key: JCR-1600
                 URL: https://issues.apache.org/jira/browse/JCR-1600
             Project: Jackrabbit
          Issue Type: Improvement
          Components: jackrabbit-core
            Reporter: Marcel Reutegger
            Priority: Minor
         Attachments: JCR-1600.patch

With the increased test coverage, specifically the recently added multi-threaded tests, I'm reasonably confident that the noLockHack in SharedItemStateManager is not needed anymore.

Attached patch removes the hack. All tests still pass, including the daily integration tests.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger updated JCR-1600:
----------------------------------

    Attachment: JCR-1600.patch

> Remove noLockHack in SharedItemStateManager
> -------------------------------------------
>
>                 Key: JCR-1600
>                 URL: https://issues.apache.org/jira/browse/JCR-1600
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: JCR-1600.patch
>
>
> With the increased test coverage, specifically the recently added multi-threaded tests, I'm reasonably confident that the noLockHack in SharedItemStateManager is not needed anymore.
> Attached patch removes the hack. All tests still pass, including the daily integration tests.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JCR-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596496#action_12596496 ]

Esteban Franqueiro commented on JCR-1600:
-----------------------------------------

Is the fine grained locking strategy being tested?

> Remove noLockHack in SharedItemStateManager
> -------------------------------------------
>
>                 Key: JCR-1600
>                 URL: https://issues.apache.org/jira/browse/JCR-1600
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: JCR-1600.patch
>
>
> With the increased test coverage, specifically the recently added multi-threaded tests, I'm reasonably confident that the noLockHack in SharedItemStateManager is not needed anymore.
> Attached patch removes the hack. All tests still pass, including the daily integration tests.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JCR-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596737#action_12596737 ]

Marcel Reutegger commented on JCR-1600:
---------------------------------------

No, I didn't run the tests with the fine grained locking, but the noLockHack was only supported by the DefaultISMLocking anyway. Removing it should not have an affect on the FineGrainedISMLocking.

> Remove noLockHack in SharedItemStateManager
> -------------------------------------------
>
>                 Key: JCR-1600
>                 URL: https://issues.apache.org/jira/browse/JCR-1600
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: JCR-1600.patch
>
>
> With the increased test coverage, specifically the recently added multi-threaded tests, I'm reasonably confident that the noLockHack in SharedItemStateManager is not needed anymore.
> Attached patch removes the hack. All tests still pass, including the daily integration tests.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger resolved JCR-1600.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5

Assuming lazy consensus, committed patch in revision: 657031

> Remove noLockHack in SharedItemStateManager
> -------------------------------------------
>
>                 Key: JCR-1600
>                 URL: https://issues.apache.org/jira/browse/JCR-1600
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: JCR-1600.patch
>
>
> With the increased test coverage, specifically the recently added multi-threaded tests, I'm reasonably confident that the noLockHack in SharedItemStateManager is not needed anymore.
> Attached patch removes the hack. All tests still pass, including the daily integration tests.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.