[jira] Created: (JCR-1579) Improved XML export handling

Improved XML export handling
----------------------------

                 Key: JCR-1579
                 URL: https://issues.apache.org/jira/browse/JCR-1579
             Project: Jackrabbit
          Issue Type: Improvement
          Components: jackrabbit-core, jackrabbit-jcr-commons, jackrabbit-jcr2spi, xml
            Reporter: Jukka Zitting
            Assignee: Jukka Zitting
            Priority: Minor


As mentioned in JCR-1574, the current XML export functionality is generating workarounds like the new PropertyWrapper class. I'd like to refactor and clean up the XML export stuff so that such workarounds wouldn't be needed.

An additional bonus would be to make both core and jcr2spi use the same XML export mechanism. For example the one in core already supports JSR 283 shareable nodes, but the one in jcr2spi does not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1579:
-------------------------------

    Attachment: export.patch

Attached a patch (export.patch) that moves all the XML export functionality from core to jcr-commons. The jcr-commons implementation is a heavily refactored version of the previous functionality. The refactoring noticeably reduces the amount of code involved and increases the documentation of the relevant classes.

I'll see if I could make also jcr2spi use the same functionality (note that I failed the last time I tried to do that).

> Improved XML export handling
> ----------------------------
>
>                 Key: JCR-1579
>                 URL: https://issues.apache.org/jira/browse/JCR-1579
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, jackrabbit-jcr-commons, jackrabbit-jcr2spi, xml
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>         Attachments: export.patch
>
>
> As mentioned in JCR-1574, the current XML export functionality is generating workarounds like the new PropertyWrapper class. I'd like to refactor and clean up the XML export stuff so that such workarounds wouldn't be needed.
> An additional bonus would be to make both core and jcr2spi use the same XML export mechanism. For example the one in core already supports JSR 283 shareable nodes, but the one in jcr2spi does not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1579:
-------------------------------

    Attachment: export.patch

Updated version of the patch, now it covers also jcr2spi.

The refactoring and removed duplication results in nice reduction in the lines of code: from 1240 to 414! (Empty lines and comments excluded.)

> Improved XML export handling
> ----------------------------
>
>                 Key: JCR-1579
>                 URL: https://issues.apache.org/jira/browse/JCR-1579
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, jackrabbit-jcr-commons, jackrabbit-jcr2spi, xml
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>         Attachments: export.patch, export.patch
>
>
> As mentioned in JCR-1574, the current XML export functionality is generating workarounds like the new PropertyWrapper class. I'd like to refactor and clean up the XML export stuff so that such workarounds wouldn't be needed.
> An additional bonus would be to make both core and jcr2spi use the same XML export mechanism. For example the one in core already supports JSR 283 shareable nodes, but the one in jcr2spi does not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1579.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5

Committed in revisions 656194 (jcr-commons), 656195 (core), and 656199 (jcr2spi).

> Improved XML export handling
> ----------------------------
>
>                 Key: JCR-1579
>                 URL: https://issues.apache.org/jira/browse/JCR-1579
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, jackrabbit-jcr-commons, jackrabbit-jcr2spi, xml
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: export.patch, export.patch
>
>
> As mentioned in JCR-1574, the current XML export functionality is generating workarounds like the new PropertyWrapper class. I'd like to refactor and clean up the XML export stuff so that such workarounds wouldn't be needed.
> An additional bonus would be to make both core and jcr2spi use the same XML export mechanism. For example the one in core already supports JSR 283 shareable nodes, but the one in jcr2spi does not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.