[jira] Created: (JCR-1577) Remove RepositoryService.getRootId()

Remove RepositoryService.getRootId()
------------------------------------

                 Key: JCR-1577
                 URL: https://issues.apache.org/jira/browse/JCR-1577
             Project: Jackrabbit
          Issue Type: Improvement
          Components: jackrabbit-jcr2spi, jackrabbit-spi
            Reporter: Michael Dürig
            Priority: Minor


For consistency reasons jcr2spi should use idFactory.createNodeId((String) null, pathFactory.getRootPath()) everywhere to build the NodeId of the root node. having two separate methods is confusing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig updated JCR-1577:
-------------------------------

    Attachment: JCR-1577.patch

Patch which deprecates RepositoryService.getRootId()

> Remove RepositoryService.getRootId()
> ------------------------------------
>
>                 Key: JCR-1577
>                 URL: https://issues.apache.org/jira/browse/JCR-1577
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi, jackrabbit-spi
>            Reporter: Michael Dürig
>            Priority: Minor
>         Attachments: JCR-1577.patch
>
>
> For consistency reasons jcr2spi should use idFactory.createNodeId((String) null, pathFactory.getRootPath()) everywhere to build the NodeId of the root node. having two separate methods is confusing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JCR-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595179#action_12595179 ]

angela commented on JCR-1577:
-----------------------------

fine with me. does anybody object?

> Remove RepositoryService.getRootId()
> ------------------------------------
>
>                 Key: JCR-1577
>                 URL: https://issues.apache.org/jira/browse/JCR-1577
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi, jackrabbit-spi
>            Reporter: Michael Dürig
>            Priority: Minor
>         Attachments: JCR-1577.patch
>
>
> For consistency reasons jcr2spi should use idFactory.createNodeId((String) null, pathFactory.getRootPath()) everywhere to build the NodeId of the root node. having two separate methods is confusing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JCR-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595182#action_12595182 ]

angela commented on JCR-1577:
-----------------------------

btw... since we already remove other methods from the RepositoryService, i guess i would rather remove this as well.

> Remove RepositoryService.getRootId()
> ------------------------------------
>
>                 Key: JCR-1577
>                 URL: https://issues.apache.org/jira/browse/JCR-1577
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi, jackrabbit-spi
>            Reporter: Michael Dürig
>            Priority: Minor
>         Attachments: JCR-1577.patch
>
>
> For consistency reasons jcr2spi should use idFactory.createNodeId((String) null, pathFactory.getRootPath()) everywhere to build the NodeId of the root node. having two separate methods is confusing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JCR-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595499#action_12595499 ]

Marcel Reutegger commented on JCR-1577:
---------------------------------------

> ... i would rather remove this ...

+1

> Remove RepositoryService.getRootId()
> ------------------------------------
>
>                 Key: JCR-1577
>                 URL: https://issues.apache.org/jira/browse/JCR-1577
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi, jackrabbit-spi
>            Reporter: Michael Dürig
>            Priority: Minor
>         Attachments: JCR-1577.patch
>
>
> For consistency reasons jcr2spi should use idFactory.createNodeId((String) null, pathFactory.getRootPath()) everywhere to build the NodeId of the root node. having two separate methods is confusing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved JCR-1577.
-------------------------

    Resolution: Fixed
      Assignee: angela

> Remove RepositoryService.getRootId()
> ------------------------------------
>
>                 Key: JCR-1577
>                 URL: https://issues.apache.org/jira/browse/JCR-1577
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi, jackrabbit-spi
>            Reporter: Michael Dürig
>            Assignee: angela
>            Priority: Minor
>         Attachments: JCR-1577.patch
>
>
> For consistency reasons jcr2spi should use idFactory.createNodeId((String) null, pathFactory.getRootPath()) everywhere to build the NodeId of the root node. having two separate methods is confusing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated JCR-1577:
------------------------

    Fix Version/s: 1.5

> Remove RepositoryService.getRootId()
> ------------------------------------
>
>                 Key: JCR-1577
>                 URL: https://issues.apache.org/jira/browse/JCR-1577
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi, jackrabbit-spi
>            Reporter: Michael Dürig
>            Assignee: angela
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: JCR-1577.patch
>
>
> For consistency reasons jcr2spi should use idFactory.createNodeId((String) null, pathFactory.getRootPath()) everywhere to build the NodeId of the root node. having two separate methods is confusing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JCR-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig closed JCR-1577.
------------------------------

> Remove RepositoryService.getRootId()
> ------------------------------------
>
>                 Key: JCR-1577
>                 URL: https://issues.apache.org/jira/browse/JCR-1577
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi, jackrabbit-spi
>            Reporter: Michael Dürig
>            Assignee: angela
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: JCR-1577.patch
>
>
> For consistency reasons jcr2spi should use idFactory.createNodeId((String) null, pathFactory.getRootPath()) everywhere to build the NodeId of the root node. having two separate methods is confusing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.