[jira] Created: (HTTPCLIENT-781) Respect Keep-Alive Header

Respect Keep-Alive Header
-------------------------

                 Key: HTTPCLIENT-781
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-781
             Project: HttpComponents HttpClient
          Issue Type: Bug
    Affects Versions: 4.0 Alpha 4
            Reporter: Sam Berlin


HttpClient currently does not respect the 'Keep-Alive' header tokens (timeout, max, etc..) and continues to use the persistent connection beyond limits the server requests.  This leads to failure and falling back to HttpRequestRetryHandler, when it should instead just use a new connection explicitly.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Berlin closed HTTPCLIENT-781.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0 Beta 1

committed fix -- please tweak the API / param names as desired.  i went with a strategy of adding a 'valid duration' to any release event, and storing the data in the existing IdleConnectionHandler, since it already stored time-sensitive info.  worked out pretty nicely i think.

> Respect Keep-Alive Header
> -------------------------
>
>                 Key: HTTPCLIENT-781
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-781
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Alpha 4
>            Reporter: Sam Berlin
>             Fix For: 4.0 Beta 1
>
>
> HttpClient currently does not respect the 'Keep-Alive' header tokens (timeout, max, etc..) and continues to use the persistent connection beyond limits the server requests.  This leads to failure and falling back to HttpRequestRetryHandler, when it should instead just use a new connection explicitly.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608514#action_12608514 ]

Oleg Kalnichevski commented on HTTPCLIENT-781:
----------------------------------------------

Sam,

I made some changes to the DefaultConnectionKeepAliveStrategy class and added more test cases. Please review. I also think it would be better if getKeepAliveDuration returned both TimeUnit and long in one go. Something like

class KeepAliveInfo {
 
  long getTime();
  TimeUnit getUnit();

}

Or we dropped TimeUnit altogether.

Oleg

> Respect Keep-Alive Header
> -------------------------
>
>                 Key: HTTPCLIENT-781
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-781
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Alpha 4
>            Reporter: Sam Berlin
>             Fix For: 4.0 Beta 1
>
>
> HttpClient currently does not respect the 'Keep-Alive' header tokens (timeout, max, etc..) and continues to use the persistent connection beyond limits the server requests.  This leads to failure and falling back to HttpRequestRetryHandler, when it should instead just use a new connection explicitly.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608680#action_12608680 ]

Daniel Woo commented on HTTPCLIENT-781:
---------------------------------------

I found a similiar issue with 3.1. Will you fix 3.1? because I am using axis1 with CommonsHTTPSender which depends on httpclient3.x

> Respect Keep-Alive Header
> -------------------------
>
>                 Key: HTTPCLIENT-781
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-781
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Alpha 4
>            Reporter: Sam Berlin
>             Fix For: 4.0 Beta 1
>
>
> HttpClient currently does not respect the 'Keep-Alive' header tokens (timeout, max, etc..) and continues to use the persistent connection beyond limits the server requests.  This leads to failure and falling back to HttpRequestRetryHandler, when it should instead just use a new connection explicitly.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608698#action_12608698 ]

Ortwin Glück commented on HTTPCLIENT-781:
-----------------------------------------

Daniel, 3.1 is considered end of life. It is unlikely that there will be another release. We accept patches, if they have sufficient test coverage, however.

> Respect Keep-Alive Header
> -------------------------
>
>                 Key: HTTPCLIENT-781
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-781
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Alpha 4
>            Reporter: Sam Berlin
>             Fix For: 4.0 Beta 1
>
>
> HttpClient currently does not respect the 'Keep-Alive' header tokens (timeout, max, etc..) and continues to use the persistent connection beyond limits the server requests.  This leads to failure and falling back to HttpRequestRetryHandler, when it should instead just use a new connection explicitly.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608898#action_12608898 ]

Sam Berlin commented on HTTPCLIENT-781:
---------------------------------------

i cleaned up the code a bit, including removing getUnit from the keep alive strategy.  i _think_ the new API is a little better, but could go either way.

> Respect Keep-Alive Header
> -------------------------
>
>                 Key: HTTPCLIENT-781
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-781
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Alpha 4
>            Reporter: Sam Berlin
>             Fix For: 4.0 Beta 1
>
>
> HttpClient currently does not respect the 'Keep-Alive' header tokens (timeout, max, etc..) and continues to use the persistent connection beyond limits the server requests.  This leads to failure and falling back to HttpRequestRetryHandler, when it should instead just use a new connection explicitly.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608908#action_12608908 ]

Oleg Kalnichevski commented on HTTPCLIENT-781:
----------------------------------------------

I also like it better this way.

Oleg

> Respect Keep-Alive Header
> -------------------------
>
>                 Key: HTTPCLIENT-781
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-781
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Alpha 4
>            Reporter: Sam Berlin
>             Fix For: 4.0 Beta 1
>
>
> HttpClient currently does not respect the 'Keep-Alive' header tokens (timeout, max, etc..) and continues to use the persistent connection beyond limits the server requests.  This leads to failure and falling back to HttpRequestRetryHandler, when it should instead just use a new connection explicitly.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...