[
https://issues.apache.org/jira/browse/HTTPCLIENT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599617#action_12599617 ]
Sam Berlin commented on HTTPCLIENT-745:
---------------------------------------
Along with these visibility fixes, I think some attention should be placed on classes who shared their variables directly (as opposed to through a getter). This is sometimes OK for subclasses, but rarely good for other classes that use the objects. There's a small number of classes that have non-private variables, especially in the impl.conn & impl.conn.tsccm packages.
> no classes with default visibility
> ----------------------------------
>
> Key: HTTPCLIENT-745
> URL:
https://issues.apache.org/jira/browse/HTTPCLIENT-745> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: Roland Weber
> Priority: Minor
> Fix For: 4.0 Beta 1
>
>
> There should be no classes with default (package) visibility. They cause problems when classes using them are extended. All classes should either be public, or nested with protected visibility where they are used. Nesting with private visibility may be acceptable in certain cases, for example in final classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@...
For additional commands, e-mail:
dev-help@...
