[jira] Created: (HADOOP-3918) Improved error message when classpath not set or set incorrectly

Improved error message when classpath not set or set incorrectly
----------------------------------------------------------------

                 Key: HADOOP-3918
                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
             Project: Hadoop Core
          Issue Type: Improvement
          Components: contrib/fuse-dfs
            Reporter: Pete Wyckoff
            Priority: Minor


Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3918:
---------------------------------

    Summary: Improve fuse-dfs error message when classpath not set or set incorrectly  (was: Improved error message when classpath not set or set incorrectly)

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3918:
---------------------------------

    Attachment: patch0.txt

> Improved error message when classpath not set or set incorrectly
> ----------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3918:
---------------------------------

    Release Note:
libhdfs will return NULL when there's a java exception creating an object rather than exiting immediately, so that the application can decide what to do on this kind of error.

Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.


  was:
libhdfs will return NULL when there's a java exception creating an object rather than exiting immediately, so that the application can decide what to do on this kind of error.

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff reassigned HADOOP-3918:
------------------------------------

    Assignee: Pete Wyckoff

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3918:
---------------------------------

    Description:
Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit

Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.



  was:
Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit
> Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3918:
---------------------------------

    Release Note:
libhdfs will return NULL when there's a java exception creating an object rather than exiting immediately, so that the application can decide what to do on this kind of error.



  was:
libhdfs will return NULL when there's a java exception creating an object rather than exiting immediately, so that the application can decide what to do on this kind of error.

Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.


          Status: Patch Available  (was: Open)

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620688#action_12620688 ]

Pete Wyckoff commented on HADOOP-3918:
--------------------------------------

note that ant test-libhdfs -Dlibhdfs=1   passes

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit
> Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620715#action_12620715 ]

Hadoop QA commented on HADOOP-3918:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12387750/patch0.txt
  against trunk revision 683652.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3031/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3031/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3031/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3031/console

This message is automatically generated.

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit
> Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3918:
---------------------------------

    Attachment: patch1.txt

Added unit tests and also a no_check_classpath option.

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt, patch1.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit
> Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3918:
---------------------------------

    Status: Patch Available  (was: Open)

submitting patch1.txt

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt, patch1.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit
> Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621618#action_12621618 ]

Pete Wyckoff commented on HADOOP-3918:
--------------------------------------

The new patch includes a unit test when the classpath is just set to foo.jar to ensure it recognizes there is no hadoop-blah.jar and exits with exit code 4. The proper tests I added hadoop.jar to the classpath to spoof it. (since in test mode, it is just using build/classes and not the jar).  

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt, patch1.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit
> Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3918:
---------------------------------

    Status: Open  (was: Patch Available)

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt, patch1.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit
> Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-3918:
---------------------------------

    Attachment: patch1.txt

fixed indenting in TestFuseDFS.

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt, patch1.txt, patch1.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit
> Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621630#action_12621630 ]

Zheng Shao commented on HADOOP-3918:
------------------------------------

The hadoop jar filename looks like hadoop-0.19.0-dev-core.jar, but we are looking for "hadoop-.+?.jar".

Shall we look for "hadoop-.*-dev-core\\.jar" instead?

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3918
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/fuse-dfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt, patch1.txt, patch1.txt
>
>
> Currently libhdfs does an exit(1) when it cannot create a hadoop object. fuse does not like this and instead fuse_dfs should return -EIO and log to syslog and stderr a message. Also if it is obvious somehting is wrong, like the CLASSPATH is null or does not contain something of the form hadoop-[a-zA-Z-].jar immediately print an error and exit
> Note that it is tough to debug this issue because when fuse-dfs is not in debug mode, it is running as a fuse module and stderr is redirected, so all one gets is "software abort" when libhdfs exits. So, this will greatly improve things since fuse-dfs can print a proper error and the user can quickly see what the problem is.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621630#action_12621630 ]

zshao edited comment on HADOOP-3918 at 8/11/08 3:15 PM:
-------------------------------------------------------------

The hadoop jar filename looks like hadoop-0.19.0-dev-core.jar, but we are looking for "hadoop-.+?.jar".

Shall we look for "hadoop-.*-dev-core\\.jar" instead? (two backslashes are converted to the line-break by jira).


      was (Author: zshao):
    The hadoop jar filename looks like hadoop-0.19.0-dev-core.jar, but we are looking for "hadoop-.+?.jar".

Shall we look for "hadoop-.*-dev-core\\.jar" instead?

 

> Improve fuse-dfs error message when classpath not set or set incorrectly
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3918
>                 URL: