[jira] Created: (GERONIMODEVTOOLS-341) Facilitate Branding of GEP

Facilitate Branding of GEP
--------------------------

                 Key: GERONIMODEVTOOLS-341
                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
             Project: Geronimo-Devtools
          Issue Type: Improvement
          Components: eclipse-plugin
    Affects Versions: 2.1.1
            Reporter: Ted Kirby
            Assignee: Ted Kirby
             Fix For: 2.1.1


Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Kirby updated GERONIMODEVTOOLS-341:
---------------------------------------

    Attachment: GD341-1.patch

GD341-1 fixes a message at the top of the Edit Server Runtime screen.
It also changes a method from protected to public in plugins\org.apache.geronimo.st.core\src\main\java\org\apache\geronimo\st\core\GeronimoServerBehaviourDelegate.java to allow for override and branding.

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594677#action_12594677 ]

Tim McConnell commented on GERONIMODEVTOOLS-341:
------------------------------------------------

GD341-1.patch works great. So I applied it with revision 653880. Will leave JIRA open as I suspect there will be multiple patches in this area. Thanks Ted for the patch !!

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Kirby updated GERONIMODEVTOOLS-341:
---------------------------------------

    Attachment: GD341-2-install-jvm-msgs.patch

fix installation directory and jvm level messages

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch, GD341-2-install-jvm-msgs.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Kirby updated GERONIMODEVTOOLS-341:
---------------------------------------

    Attachment: GD341-3-launch-console.patch

fix the launch console message

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch, GD341-2-install-jvm-msgs.patch, GD341-3-launch-console.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594940#action_12594940 ]

Tim McConnell commented on GERONIMODEVTOOLS-341:
------------------------------------------------

Hi Ted, I applied patches GD341-2 and GD341-3 in revision 654140. Had some conflicts in Messages.properties but think I cleared them up correctly, but please check. Thanks

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch, GD341-2-install-jvm-msgs.patch, GD341-3-launch-console.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Kirby updated GERONIMODEVTOOLS-341:
---------------------------------------

    Attachment: GD341-4-version-content.patch

I agree with your conflict resolution.

Here is another drop, GD341-4-version-contents, that deals with runtime messages about missing content and missing or incorrect version number.

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch, GD341-2-install-jvm-msgs.patch, GD341-3-launch-console.patch, GD341-4-version-content.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595636#action_12595636 ]

Tim McConnell commented on GERONIMODEVTOOLS-341:
------------------------------------------------

Patch GD341-4 applied with revision 654856. Thanks Ted Kirby for the patch !!

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch, GD341-2-install-jvm-msgs.patch, GD341-3-launch-console.patch, GD341-4-version-content.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Kirby updated GERONIMODEVTOOLS-341:
---------------------------------------

    Attachment: GD341-5-install-message.patch

GD341-5-install-message.patch is a patch for the install confirm dialog for a confirmation message when clicking the "Download and Install" button during new server definition.

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch, GD341-2-install-jvm-msgs.patch, GD341-3-launch-console.patch, GD341-4-version-content.patch, GD341-5-install-message.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599048#action_12599048 ]

Tim McConnell commented on GERONIMODEVTOOLS-341:
------------------------------------------------

Patch GD341-5 applied to trunk with revision 659131. Thanks Ted Kirby for the patch !!

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch, GD341-2-install-jvm-msgs.patch, GD341-3-launch-console.patch, GD341-4-version-content.patch, GD341-5-install-message.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim McConnell resolved GERONIMODEVTOOLS-341.
--------------------------------------------

    Resolution: Fixed

> Facilitate Branding of GEP
> --------------------------
>
>                 Key: GERONIMODEVTOOLS-341
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-341
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.1
>            Reporter: Ted Kirby
>            Assignee: Ted Kirby
>             Fix For: 2.1.1
>
>         Attachments: GD341-1.patch, GD341-2-install-jvm-msgs.patch, GD341-3-launch-console.patch, GD341-4-version-content.patch, GD341-5-install-message.patch
>
>
> Many messages in Message.properties files have vendor (Apache) and server (Geronimo) names hard-coded.  This complicates work for vendors who may wish to brand the GEP.  The server and runtimes have vendor and server name attributes, with values provided by the plugin.properties files.  The code should use these values when it can.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.