[jira] Created: (GERONIMO-4082) <hidden-classes> ignored for certain classes that are loaded by system class loader

<hidden-classes> ignored for certain classes that are loaded by system class loader
-----------------------------------------------------------------------------------

                 Key: GERONIMO-4082
                 URL: https://issues.apache.org/jira/browse/GERONIMO-4082
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: kernel
    Affects Versions: 2.1.1
         Environment: All
            Reporter: Manu T George
             Fix For: 2.2


 There is a problem with the hidden-classes element not
working for asm classes. The reason was the optimized class loading
mechanism which does not check if the classes are hidden before the
code block given below

      //
       // No dice, let's offer the primordial loader a shot...
       //
       try {
               return resolveClass(findSystemClass(name), resolve);
       } catch (ClassNotFoundException cnfe) {
               // ignore...just being a good citizen.
       }

I was able to get this to work by reverting to the safe method of
finding classes via the system property
-DXorg.apache.geronimo.kernel.config.MPCLSearchOption=safe

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bohn updated GERONIMO-4082:
-------------------------------

    Fix Version/s: 2.1.2

Added fix version of 2.1.2 per update by Jarek indicating that it was required for 2.1.2 release when he edited the release plan for 2.1.2.

> <hidden-classes> ignored for certain classes that are loaded by system class loader
> -----------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4082
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4082
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: kernel
>    Affects Versions: 2.1.1
>         Environment: All
>            Reporter: Manu T George
>             Fix For: 2.1.2, 2.2
>
>
>  There is a problem with the hidden-classes element not
> working for asm classes. The reason was the optimized class loading
> mechanism which does not check if the classes are hidden before the
> code block given below
>       //
>        // No dice, let's offer the primordial loader a shot...
>        //
>        try {
>                return resolveClass(findSystemClass(name), resolve);
>        } catch (ClassNotFoundException cnfe) {
>                // ignore...just being a good citizen.
>        }
> I was able to get this to work by reverting to the safe method of
> finding classes via the system property
> -DXorg.apache.geronimo.kernel.config.MPCLSearchOption=safe

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevan Miller reassigned GERONIMO-4082:
--------------------------------------

    Assignee: Kevan Miller

> <hidden-classes> ignored for certain classes that are loaded by system class loader
> -----------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4082
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4082
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: kernel
>    Affects Versions: 2.1.1
>         Environment: All
>            Reporter: Manu T George
>            Assignee: Kevan Miller
>             Fix For: 2.1.2, 2.2
>
>
>  There is a problem with the hidden-classes element not
> working for asm classes. The reason was the optimized class loading
> mechanism which does not check if the classes are hidden before the
> code block given below
>       //
>        // No dice, let's offer the primordial loader a shot...
>        //
>        try {
>                return resolveClass(findSystemClass(name), resolve);
>        } catch (ClassNotFoundException cnfe) {
>                // ignore...just being a good citizen.
>        }
> I was able to get this to work by reverting to the safe method of
> finding classes via the system property
> -DXorg.apache.geronimo.kernel.config.MPCLSearchOption=safe

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMO-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615774#action_12615774 ]

Joe Bohn commented on GERONIMO-4082:
------------------------------------

Is there any remaining work for this or can we mark this as complete and delivered in 2.1.2 now?

> <hidden-classes> ignored for certain classes that are loaded by system class loader
> -----------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4082
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4082
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: kernel
>    Affects Versions: 2.1.1
>         Environment: All
>            Reporter: Manu T George
>            Assignee: Kevan Miller
>             Fix For: 2.1.2, 2.2
>
>
>  There is a problem with the hidden-classes element not
> working for asm classes. The reason was the optimized class loading
> mechanism which does not check if the classes are hidden before the
> code block given below
>       //
>        // No dice, let's offer the primordial loader a shot...
>        //
>        try {
>                return resolveClass(findSystemClass(name), resolve);
>        } catch (ClassNotFoundException cnfe) {
>                // ignore...just being a good citizen.
>        }
> I was able to get this to work by reverting to the safe method of
> finding classes via the system property
> -DXorg.apache.geronimo.kernel.config.MPCLSearchOption=safe

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevan Miller resolved GERONIMO-4082.
------------------------------------

    Resolution: Fixed

We'll shortcut to the primordial classloader only if processing a java.* or data primitive class. Otherwise, we'll follow the normal parent ClassLoading order.

The checking for data primitive classes needs to be tweaked a bit, but will handle with a separate Jira.

> <hidden-classes> ignored for certain classes that are loaded by system class loader
> -----------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4082
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4082
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: kernel
>    Affects Versions: 2.1.1
>         Environment: All
>            Reporter: Manu T George
>            Assignee: Kevan Miller
>             Fix For: 2.1.2, 2.2
>
>
>  There is a problem with the hidden-classes element not
> working for asm classes. The reason was the optimized class loading
> mechanism which does not check if the classes are hidden before the
> code block given below
>       //
>        // No dice, let's offer the primordial loader a shot...
>        //
>        try {
>                return resolveClass(findSystemClass(name), resolve);
>        } catch (ClassNotFoundException cnfe) {
>                // ignore...just being a good citizen.
>        }
> I was able to get this to work by reverting to the safe method of
> finding classes via the system property
> -DXorg.apache.geronimo.kernel.config.MPCLSearchOption=safe

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.