[jira] Created: (DERBY-961) Error 22001 can include 'XX-RESOLVE-XX' which should be removed

[Apache Derby Developers mailing list]

Error 22001 can include 'XX-RESOLVE-XX' which should be removed
---------------------------------------------------------------

         Key: DERBY-961
         URL: http://issues.apache.org/jira/browse/DERBY-961
     Project: Derby
        Type: Bug
    Versions: 10.2.0.0    
    Reporter: Myrna van Lunteren
    Priority: Minor


In some cases, error 22001 can come up as follows:
A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.

This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.

It should be removed from the message.

Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
So, running updatableResultSet will generate the message.
 
The stack trace I saw:
 at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
 at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
 at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
 at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
 at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
 at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
 at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
 at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
 at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
 at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
 at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
 at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
 

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[Apache Derby Developers mailing list]

     [ http://issues.apache.org/jira/browse/DERBY-961?page=all ]

Mike Matrigali updated DERBY-961:
---------------------------------

    Component: SQL

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>          Key: DERBY-961
>          URL: http://issues.apache.org/jira/browse/DERBY-961
>      Project: Derby
>         Type: Bug

>   Components: SQL
>     Versions: 10.2.0.0
>     Reporter: Myrna van Lunteren
>     Priority: Minor

>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

     [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton updated DERBY-961:
----------------------------------

    Attachment: tweakMsg.diff

I took a look at the message in question, and it appears
that the intent of the XX-RESOLVE-XX message parameter
is to hold the actual value which could not be shrunk to fit
in the column.

I imagine that the reason for the XX-RESOLVE-XX is
because for a SQLBinary data type, the actual value may
not be human-readable, and so cannot be displayed.

So I created the attached experimental diff (tweakMsg.diff),
which changes the XX-RESOLVE-XX parameter to the
message to "(Binary data value not displayed)", which
I hope would give a better hint to the person who received
this error message about what was going on.

I ran the entire regression suite with the modified test, and got
no failures, and I also grepped the source tree for XX-RESOLVE-XX
and got no hits.

However, I'm not totally sure how to make this problem occur,
in order to verify that the new message in fact looks better
than the old one.

In order to make this a complete fix worthy of submitting, I
think I'll need to find a test case which provokes this error,
and verify that the error message looks better.

But in the meantime, if anybody has any comments on this
approach, I'd be most grateful.

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Priority: Minor
>         Attachments: tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton reassigned DERBY-961:
-------------------------------------

    Assignee: Bryan Pendleton

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>         Attachments: tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614868#action_12614868 ]

Kathey Marsden commented on DERBY-961:
--------------------------------------

In The test memory.BlobMemTest you can change the table to be too small and get this message.
Change line 77 to be
s.executeUpdate("CREATE TABLE BLOBTAB (K INT CONSTRAINT PK PRIMARY KEY, B BLOB(" + 17000000 + "))");
and you will get failures like:

3) testBlobLength(org.apache.derbyTesting.functionTests.tests.memory.BlobMemTest)java.sql.SQLException: A truncation err
or was encountered trying to shrink BLOB 'XX-RESOLVE-XX' to length 17000000.

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>         Attachments: tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton updated DERBY-961:
----------------------------------

    Attachment: msgChangeWithTest.diff

Thanks Kathey! That test indeed provokes the error, just as you predicted.

I verified that the error message was displayed as I expected it to be,
then modified the patch proposal to include a tweak to BlobMemTest
to provoke the truncation error intentionally and verify that the 22001
SQLState was returned.

Attached is the modified patch proposal.

Please let me know of any comments.

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>         Attachments: msgChangeWithTest.diff, tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton resolved DERBY-961.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 10.5.0.0

Committed msgChangeWithTest.diff to the trunk as revision 678769

I don't intend to merge this to any of the prior branches at this time, so
I'm marking the issue resolved.

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: msgChangeWithTest.diff, tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616838#action_12616838 ]

Knut Anders Hatlen commented on DERBY-961:
------------------------------------------

The new message is not internationalized and will be printed in English in all locales. Should we do something to make it possible to translate the message (for instance, creating a message id and adding it to messages.xml)?

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: msgChangeWithTest.diff, tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Myrna van Lunteren closed DERBY-961.
------------------------------------

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: msgChangeWithTest.diff, tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Myrna van Lunteren reopened DERBY-961:
--------------------------------------


I was a little hasty closing this - didn't notice the last comment.
It seems a lot of work for a minor issue, but I agree, to cross all t's we should have a translated (at least, translatable) message...

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: msgChangeWithTest.diff, tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617185#action_12617185 ]

Bryan Pendleton commented on DERBY-961:
---------------------------------------

I agree with the observation that the English text for the message
parameter should not be hard-coded, but should be fetched from
a message file.

I'll have a look at this and see what I can do.

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: msgChangeWithTest.diff, tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton updated DERBY-961:
----------------------------------

    Attachment: i18nHiddenString.txt

Attached is a patch proposal to internationalize the message
parameter which indicates that the binary data has been hidden.

I'm a bit unfamiliar with the I18N message support so please
have a look and let me know if I'm misunderstanding the message
infrastructure.

The intent of the patch is to provide the same error message, but
with the string extracted from a message file so that it can be
translated if desired.

I verified the patch by tweaking BlobMemTest to print out the
22001 exception that it receives in the DERBY-961 test, and I
visually inspected the message and it looked OK to me.

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: i18nHiddenString.txt, msgChangeWithTest.diff, tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617336#action_12617336 ]

Knut Anders Hatlen commented on DERBY-961:
------------------------------------------

Thanks Bryan. The patch looks fine to me. Since the message is only used as part of another message and is not a full error message in itself, it would perhaps be better to give it an identifier that doesn't look like an SQL state and move the constant from SQLState.java to MessageId.java. Then the message should also be moved to another section of messages.xml. Look for the section with this heading in messages.xml:

<!--
This section contains all of the internationalized messages which are
undocumented. This includes messages with handles which are
pseudo-SQLStates, documented in SQLState.java. This also includes
messages with non-SQLState handles which are documented in
MessageId.java.
-->

    <section>
        <desc>Undocumented messages with pseudo-SQLStates or no SQLStates</desc>

> Error 22001 can include 'XX-RESOLVE-XX' which should be removed
> ---------------------------------------------------------------
>
>                 Key: DERBY-961
>                 URL: https://issues.apache.org/jira/browse/DERBY-961
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.6
>            Reporter: Myrna van Lunteren
>            Assignee: Bryan Pendleton
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: i18nHiddenString.txt, msgChangeWithTest.diff, tweakMsg.diff
>
>
> In some cases, error 22001 can come up as follows:
> A truncation error was encountered trying to shrink CHAR () FOR BIT DATA 'XX-RESOLVE-XX' to length 40.
> This message makes it appear as if there is a column called XX-RESOLVE-XX, however, this string is coming out of SQLBinary.java.
> It should be removed from the message.
> Other references for this string are in the masters for updatableResultSet.out, and in the test lang/concateTests.java (referring to DERBY-124).
> So, running updatableResultSet will generate the message.
>  
> The stack trace I saw:
>  at org.apache.derby.iapi.error.StandardException.newException(StandardException.java:362)
>  at org.apache.derby.iapi.types.SQLBinary.checkHostVariable(SQLBinary.java:977)
>  at org.apache.derby.exe.ac05550069x0109x5d95xbdfcxffff9c80fb80163.e0 (Unknown Source)
>  at org.apache.derby.impl.services.reflect.DirectCall.invoke(ReflectGeneratedClass.java:138)
>  at org.apache.derby.impl.sql.execute.RowResultSet.getNextRowCore(RowResultSet.java:155)
>  at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore (NormalizeResultSet.java:204)
>  at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(DMLWriteResultSet.java:123)
>  at org.apache.derby.impl.sql.execute.InsertResultSet.open(InsertResultSet.java:521)
>  at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:359)
>  at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1142)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1421)
>  at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(EmbedPreparedStatement.java:263)
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.