[jira] Created: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet
|
View:
New views
8 Messages
—
Rating Filter:
Alert me
|
 |
[jira] Created: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet
by JIRA jira@apache.org
::
Rate this Message:
Rename BaseJDBCTestCase.usingDerbyNet
------------------------------------- Key: DERBY-3763 URL: https://issues.apache.org/jira/browse/DERBY-3763 Project: Derby Issue Type: Improvement Components: Test Affects Versions: 10.5.0.0 Reporter: Kristian Waagan Assignee: Kristian Waagan Priority: Trivial The names of the methods 'usingDerbyNet' and 'usingDerbyNetClient' in BaseJDBCTestCase are confusing. I propose we change the one used to tell if we are using the DB2 client driver (JCC). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Updated: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet
by JIRA jira@apache.org
::
Rate this Message:
[ https://issues.apache.org/jira/browse/DERBY-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3763: ----------------------------------- Attachment: derby-3763-1a-usingDB2Client.stat derby-3763-1a-usingDB2Client.diff 'derby-3763-1a-usingDB2Client.diff' renames BaseJDBCTestCase.usingDerbyNet to usingDB2Client. There might be better names, I'm open for suggestions! Patch ready for review. > Rename BaseJDBCTestCase.usingDerbyNet > ------------------------------------- > > Key: DERBY-3763 > URL: https://issues.apache.org/jira/browse/DERBY-3763 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Trivial > Attachments: derby-3763-1a-usingDB2Client.diff, derby-3763-1a-usingDB2Client.stat > > > The names of the methods 'usingDerbyNet' and 'usingDerbyNetClient' in BaseJDBCTestCase are confusing. > I propose we change the one used to tell if we are using the DB2 client driver (JCC). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Commented: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet
by JIRA jira@apache.org
::
Rate this Message:
[ https://issues.apache.org/jira/browse/DERBY-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611555#action_12611555 ] Dag H. Wanvik commented on DERBY-3763: -------------------------------------- I am OK with the name change, but just a nit: In the test BlobClob4BlobTest you have for example this line: } catch (StringIndexOutOfBoundsException se) { assertTrue("FAIL - This exception should only happen with DerbyNet", usingDerbyNet()); If you change the name of the method, the explanatory message should probably be changes as well: assertTrue("FAIL - This exception should only happen with DB2 client", + usingDB2Client()); There are several other instances of this. A data point, the "Net=db2 client", "Client=Derby client" convention is still used in the old (non-JUnit tests), but I agree it is better to remove this source of confusion and be explicit as you propose. > Rename BaseJDBCTestCase.usingDerbyNet > ------------------------------------- > > Key: DERBY-3763 > URL: https://issues.apache.org/jira/browse/DERBY-3763 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Trivial > Attachments: derby-3763-1a-usingDB2Client.diff, derby-3763-1a-usingDB2Client.stat > > > The names of the methods 'usingDerbyNet' and 'usingDerbyNetClient' in BaseJDBCTestCase are confusing. > I propose we change the one used to tell if we are using the DB2 client driver (JCC). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Issue Comment Edited: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet
by JIRA jira@apache.org
::
Rate this Message:
[ https://issues.apache.org/jira/browse/DERBY-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611555#action_12611555 ] dagw edited comment on DERBY-3763 at 7/8/08 5:37 AM: -------------------------------------------------------------- I am OK with the name change, but just a nit: In the test BlobClob4BlobTest you have for example this line: } catch (StringIndexOutOfBoundsException se) { assertTrue("FAIL - This exception should only happen with DerbyNet", usingDerbyNet()); If you change the name of the method, the explanatory message should probably be changes as well: assertTrue("FAIL - This exception should only happen with DB2 client", usingDB2Client()); There are several other instances of this. A data point, the "Net=db2 client", "Client=Derby client" convention is still used in the old (non-JUnit tests), but I agree it is better to remove this source of confusion and be explicit as you propose. was (Author: dagw): I am OK with the name change, but just a nit: In the test BlobClob4BlobTest you have for example this line: } catch (StringIndexOutOfBoundsException se) { assertTrue("FAIL - This exception should only happen with DerbyNet", usingDerbyNet()); If you change the name of the method, the explanatory message should probably be changes as well: assertTrue("FAIL - This exception should only happen with DB2 client", + usingDB2Client()); There are several other instances of this. A data point, the "Net=db2 client", "Client=Derby client" convention is still used in the old (non-JUnit tests), but I agree it is better to remove this source of confusion and be explicit as you propose. > Rename BaseJDBCTestCase.usingDerbyNet > ------------------------------------- > > Key: DERBY-3763 > URL: https://issues.apache.org/jira/browse/DERBY-3763 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Trivial > Attachments: derby-3763-1a-usingDB2Client.diff, derby-3763-1a-usingDB2Client.stat > > > The names of the methods 'usingDerbyNet' and 'usingDerbyNetClient' in BaseJDBCTestCase are confusing. > I propose we change the one used to tell if we are using the DB2 client driver (JCC). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Commented: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet
by JIRA jira@apache.org
::
Rate this Message:
[ https://issues.apache.org/jira/browse/DERBY-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611601#action_12611601 ] Kristian Waagan commented on DERBY-3763: ---------------------------------------- Thanks for the comment Dag. I'll wait a while and see if anyone else has strong feelings about this. If I go ahead with the current proposal, I'll change the comments/strings as you pointed out. Since the current convention comes from the old test harness, I think it is acceptable to change it to something better in the new one. Others might think differently, if so please speak up. BTW; If it had been "DerbyNet" and "DerbyClient" it would have been kind of okay, but it's "DerbyNet" and "DerbyNetClient" and that I find confusing. > Rename BaseJDBCTestCase.usingDerbyNet > ------------------------------------- > > Key: DERBY-3763 > URL: https://issues.apache.org/jira/browse/DERBY-3763 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Trivial > Attachments: derby-3763-1a-usingDB2Client.diff, derby-3763-1a-usingDB2Client.stat > > > The names of the methods 'usingDerbyNet' and 'usingDerbyNetClient' in BaseJDBCTestCase are confusing. > I propose we change the one used to tell if we are using the DB2 client driver (JCC). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Updated: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet
by JIRA jira@apache.org
::
Rate this Message:
[ https://issues.apache.org/jira/browse/DERBY-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3763: ----------------------------------- Attachment: derby-3763-1b-usingDB2Client.stat derby-3763-1b-usingDB2Client.diff Patch 1b changes some additional comments as suggested by Dag and includes an additional change in JDBCClient. TestConfiguration is still using the string "DerbyNet" when parsing properties from the old harness. suites.All passed, running derbyall. Plan to commit tomorrow. > Rename BaseJDBCTestCase.usingDerbyNet > ------------------------------------- > > Key: DERBY-3763 > URL: https://issues.apache.org/jira/browse/DERBY-3763 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Trivial > Attachments: derby-3763-1a-usingDB2Client.diff, derby-3763-1a-usingDB2Client.stat, derby-3763-1b-usingDB2Client.diff, derby-3763-1b-usingDB2Client.stat > > > The names of the methods 'usingDerbyNet' and 'usingDerbyNetClient' in BaseJDBCTestCase are confusing. > I propose we change the one used to tell if we are using the DB2 client driver (JCC). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Resolved: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet
by JIRA jira@apache.org
::
Rate this Message:
[ https://issues.apache.org/jira/browse/DERBY-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan resolved DERBY-3763. ------------------------------------ Resolution: Fixed Fix Version/s: 10.5.0.0 10.4.1.4 Derby Info: (was: [Patch Available]) My test runs passed with patch 1b applied. Committed 'derby-3763-1b-usingDB2Client.diff' to trunk with revision 677848. Backported to 10.4 with revision 677849. > Rename BaseJDBCTestCase.usingDerbyNet > ------------------------------------- > > Key: DERBY-3763 > URL: https://issues.apache.org/jira/browse/DERBY-3763 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Trivial > Fix For: 10.4.1.4, 10.5.0.0 > > Attachments: derby-3763-1a-usingDB2Client.diff, derby-3763-1a-usingDB2Client.stat, derby-3763-1b-usingDB2Client.diff, derby-3763-1b-usingDB2Client.stat > > > The names of the methods 'usingDerbyNet' and 'usingDerbyNetClient' in BaseJDBCTestCase are confusing. > I propose we change the one used to tell if we are using the DB2 client driver (JCC). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Closed: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet
by JIRA jira@apache.org
::
Rate this Message:
[ https://issues.apache.org/jira/browse/DERBY-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan closed DERBY-3763. ---------------------------------- > Rename BaseJDBCTestCase.usingDerbyNet > ------------------------------------- > > Key: DERBY-3763 > URL: https://issues.apache.org/jira/browse/DERBY-3763 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Trivial > Fix For: 10.4.1.4, 10.5.0.0 > > Attachments: derby-3763-1a-usingDB2Client.diff, derby-3763-1a-usingDB2Client.stat, derby-3763-1b-usingDB2Client.diff, derby-3763-1b-usingDB2Client.stat > > > The names of the methods 'usingDerbyNet' and 'usingDerbyNetClient' in BaseJDBCTestCase are confusing. > I propose we change the one used to tell if we are using the DB2 client driver (JCC). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
| Free Forum Powered by Nabble | Forum Help |