[jira] Created: (DERBY-3758) Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit

View: New views
7 Messages — Rating Filter:   Alert me  

[jira] Created: (DERBY-3758) Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit
----------------------------------------------------------------------------------

                 Key: DERBY-3758
                 URL: https://issues.apache.org/jira/browse/DERBY-3758
             Project: Derby
          Issue Type: Test
          Components: Test
         Environment: windows xp, sp2.
            Reporter: Junjie Peng
            Assignee: Junjie Peng


Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3758) Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/DERBY-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Junjie Peng updated DERBY-3758:
-------------------------------

    Attachment: derby-3758-stat.txt
                derby-3758-patch.txt

Please check the patch!

> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-3758
>                 URL: https://issues.apache.org/jira/browse/DERBY-3758
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>         Environment: windows xp, sp2.
>            Reporter: Junjie Peng
>            Assignee: Junjie Peng
>         Attachments: derby-3758-patch.txt, derby-3758-stat.txt
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3758) Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/DERBY-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Junjie Peng updated DERBY-3758:
-------------------------------

    Attachment: derby-3758-1-stat.txt
                derby-3758-1-patch.txt

Delete precedence.sql from  java\testing\org\apache\derbyTesting\functionTests\tests\lang\LangScripts.java.

> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-3758
>                 URL: https://issues.apache.org/jira/browse/DERBY-3758
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>         Environment: windows xp, sp2.
>            Reporter: Junjie Peng
>            Assignee: Junjie Peng
>         Attachments: derby-3758-1-patch.txt, derby-3758-1-stat.txt, derby-3758-patch.txt, derby-3758-stat.txt
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3758) Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/DERBY-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614687#action_12614687 ]

Knut Anders Hatlen commented on DERBY-3758:
-------------------------------------------

In the original test, it is expected that some of the statements fail with a syntax error. The new test doesn't seem to expect syntax errors for the same statements. Why is that?

> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-3758
>                 URL: https://issues.apache.org/jira/browse/DERBY-3758
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>         Environment: windows xp, sp2.
>            Reporter: Junjie Peng
>            Assignee: Junjie Peng
>         Attachments: derby-3758-1-patch.txt, derby-3758-1-stat.txt, derby-3758-patch.txt, derby-3758-stat.txt
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3758) Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/DERBY-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617754#action_12617754 ]

Junjie Peng commented on DERBY-3758:
------------------------------------

Hi, Knut. Thanks for your attention!
Yes, there are two of them:
Line 31:
select c11 from t1 where 'acme widgets' like 'acme%' in (1=1);

Line 36:
select c11 from t1 where exists(select * from (values 1) as t) not in (1=2);


They fails on ij, with prompt "Encounter '=' at line *, column *".

I think, from the point of the witer's original intent, the two tests should be
Line 31:
select c11 from t1 where 'acme widgets' like 'acme%' in ('1=1');

Line 36:
select c11 from t1 where exists(select * from (values 1) as t) not in ('1=2');

the 1=1 & 1=2 should be enbraced by \'.

How do you think about it?



> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-3758
>                 URL: https://issues.apache.org/jira/browse/DERBY-3758
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>         Environment: windows xp, sp2.
>            Reporter: Junjie Peng
>            Assignee: Junjie Peng
>         Attachments: derby-3758-1-patch.txt, derby-3758-1-stat.txt, derby-3758-patch.txt, derby-3758-stat.txt
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-3758) Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/DERBY-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Myrna van Lunteren resolved DERBY-3758.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.5.0.0
       Derby Info:   (was: [Patch Available])

I hesitated for a time before committing this test...
You've got a point in that the 2 statements returning a syntax message weren't doing anymore what the comments indicate the original test was supposed to do, and your variations come closer to that goal.

But we didn't gain so much in converting this test - whether run in LangScripts or as a junit test in its own right..., with embedded it runs in 31 ms on my machine, and I was contemplating whether we need to run this test against networkserver...

But in the end I figured it was an improvement over non-intended syntax errors and getting rid of an extra master also helps.

Committed with revision 686104

> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-3758
>                 URL: https://issues.apache.org/jira/browse/DERBY-3758
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>         Environment: windows xp, sp2.
>            Reporter: Junjie Peng
>            Assignee: Junjie Peng
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3758-1-patch.txt, derby-3758-1-stat.txt, derby-3758-patch.txt, derby-3758-stat.txt
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-3758) Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/DERBY-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Junjie Peng closed DERBY-3758.
------------------------------


Thank you, Myrna! I agree with your comments.

> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-3758
>                 URL: https://issues.apache.org/jira/browse/DERBY-3758
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>         Environment: windows xp, sp2.
>            Reporter: Junjie Peng
>            Assignee: Junjie Peng
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3758-1-patch.txt, derby-3758-1-stat.txt, derby-3758-patch.txt, derby-3758-stat.txt
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

LightInTheBox - Buy quality products at wholesale price!