[jira] Created: (DERBY-3728) Fix error handling in PrivilegedFileOpsForTests

Fix error handling in PrivilegedFileOpsForTests
-----------------------------------------------

                 Key: DERBY-3728
                 URL: https://issues.apache.org/jira/browse/DERBY-3728
             Project: Derby
          Issue Type: Bug
          Components: Test
    Affects Versions: 10.5.0.0
            Reporter: Kristian Waagan
            Priority: Minor
             Fix For: 10.5.0.0


The exception handling in this utility class is unclear and can in some cases cause ClassCastException to be thrown.
Note that SecurityException is a runtime exception.

Potential issues to be fixed:
 1) Avoid possibility of ClassCastException in 'getFileInputStream'
 2) Don't include SecurityException in the signature (throws clause)
 3) Document SecurityException in JavaDoc.

Points 2 and 3 leads to the option of not catching SecurityException, which allows the code to be written more concisely and we can use PrivilegedAction instead of PrivilegedExceptionAction in some cases.

There is also a missing character in the class name in the header, and an invalid JavaDoc tag in the class JavaDoc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606349#action_12606349 ]

Knut Anders Hatlen commented on DERBY-3728:
-------------------------------------------

The class org.apache.derby.iapi.util.PrivilegedFileOps has similar issues.

> Fix error handling in PrivilegedFileOpsForTests
> -----------------------------------------------
>
>                 Key: DERBY-3728
>                 URL: https://issues.apache.org/jira/browse/DERBY-3728
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>
> The exception handling in this utility class is unclear and can in some cases cause ClassCastException to be thrown.
> Note that SecurityException is a runtime exception.
> Potential issues to be fixed:
>  1) Avoid possibility of ClassCastException in 'getFileInputStream'
>  2) Don't include SecurityException in the signature (throws clause)
>  3) Document SecurityException in JavaDoc.
> Points 2 and 3 leads to the option of not catching SecurityException, which allows the code to be written more concisely and we can use PrivilegedAction instead of PrivilegedExceptionAction in some cases.
> There is also a missing character in the class name in the header, and an invalid JavaDoc tag in the class JavaDoc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan reassigned DERBY-3728:
--------------------------------------

    Assignee: Kristian Waagan

> Fix error handling in PrivilegedFileOpsForTests
> -----------------------------------------------
>
>                 Key: DERBY-3728
>                 URL: https://issues.apache.org/jira/browse/DERBY-3728
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>
> The exception handling in this utility class is unclear and can in some cases cause ClassCastException to be thrown.
> Note that SecurityException is a runtime exception.
> Potential issues to be fixed:
>  1) Avoid possibility of ClassCastException in 'getFileInputStream'
>  2) Don't include SecurityException in the signature (throws clause)
>  3) Document SecurityException in JavaDoc.
> Points 2 and 3 leads to the option of not catching SecurityException, which allows the code to be written more concisely and we can use PrivilegedAction instead of PrivilegedExceptionAction in some cases.
> There is also a missing character in the class name in the header, and an invalid JavaDoc tag in the class JavaDoc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3728:
-----------------------------------

    Derby Info: [Patch Available]

> Fix error handling in PrivilegedFileOpsForTests
> -----------------------------------------------
>
>                 Key: DERBY-3728
>                 URL: https://issues.apache.org/jira/browse/DERBY-3728
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3728-1a.diff
>
>
> The exception handling in this utility class is unclear and can in some cases cause ClassCastException to be thrown.
> Note that SecurityException is a runtime exception.
> Potential issues to be fixed:
>  1) Avoid possibility of ClassCastException in 'getFileInputStream'
>  2) Don't include SecurityException in the signature (throws clause)
>  3) Document SecurityException in JavaDoc.
> Points 2 and 3 leads to the option of not catching SecurityException, which allows the code to be written more concisely and we can use PrivilegedAction instead of PrivilegedExceptionAction in some cases.
> There is also a missing character in the class name in the header, and an invalid JavaDoc tag in the class JavaDoc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3728:
-----------------------------------

    Attachment: derby-3728-1a.diff

'derby-3728-1a.diff' fixes the issues mentioned in the description and also corrects some other minor issues (wrong classname in header, JavaDoc tags).

Patch ready for review. I do plan to commit this patch later today.

FYI, the PrivilegedFileOps mentioned in the previous comment has been removed (see DERBY-3864).

> Fix error handling in PrivilegedFileOpsForTests
> -----------------------------------------------
>
>                 Key: DERBY-3728
>                 URL: https://issues.apache.org/jira/browse/DERBY-3728
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3728-1a.diff
>
>
> The exception handling in this utility class is unclear and can in some cases cause ClassCastException to be thrown.
> Note that SecurityException is a runtime exception.
> Potential issues to be fixed:
>  1) Avoid possibility of ClassCastException in 'getFileInputStream'
>  2) Don't include SecurityException in the signature (throws clause)
>  3) Document SecurityException in JavaDoc.
> Points 2 and 3 leads to the option of not catching SecurityException, which allows the code to be written more concisely and we can use PrivilegedAction instead of PrivilegedExceptionAction in some cases.
> There is also a missing character in the class name in the header, and an invalid JavaDoc tag in the class JavaDoc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan resolved DERBY-3728.
------------------------------------

    Resolution: Fixed
    Derby Info:   (was: [Patch Available])

Committed 'derby-3728-1a.diff' to trunk with revision 702518.

> Fix error handling in PrivilegedFileOpsForTests
> -----------------------------------------------
>
>                 Key: DERBY-3728
>                 URL: https://issues.apache.org/jira/browse/DERBY-3728
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3728-1a.diff
>
>
> The exception handling in this utility class is unclear and can in some cases cause ClassCastException to be thrown.
> Note that SecurityException is a runtime exception.
> Potential issues to be fixed:
>  1) Avoid possibility of ClassCastException in 'getFileInputStream'
>  2) Don't include SecurityException in the signature (throws clause)
>  3) Document SecurityException in JavaDoc.
> Points 2 and 3 leads to the option of not catching SecurityException, which allows the code to be written more concisely and we can use PrivilegedAction instead of PrivilegedExceptionAction in some cases.
> There is also a missing character in the class name in the header, and an invalid JavaDoc tag in the class JavaDoc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan closed DERBY-3728.
----------------------------------

> Fix error handling in PrivilegedFileOpsForTests
> -----------------------------------------------
>
>                 Key: DERBY-3728
>                 URL: https://issues.apache.org/jira/browse/DERBY-3728
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3728-1a.diff
>
>
> The exception handling in this utility class is unclear and can in some cases cause ClassCastException to be thrown.
> Note that SecurityException is a runtime exception.
> Potential issues to be fixed:
>  1) Avoid possibility of ClassCastException in 'getFileInputStream'
>  2) Don't include SecurityException in the signature (throws clause)
>  3) Document SecurityException in JavaDoc.
> Points 2 and 3 leads to the option of not catching SecurityException, which allows the code to be written more concisely and we can use PrivilegedAction instead of PrivilegedExceptionAction in some cases.
> There is also a missing character in the class name in the header, and an invalid JavaDoc tag in the class JavaDoc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.