[jira] Created: (CONTINUUM-1845) Notification mails is not always sent but just if the build state changes

Notification mails is not always sent but just if the build state changes
-------------------------------------------------------------------------

                 Key: CONTINUUM-1845
                 URL: http://jira.codehaus.org/browse/CONTINUUM-1845
             Project: Continuum
          Issue Type: Bug
          Components: Notification Subsystem
    Affects Versions: 1.1
            Reporter: Stefano Nichele


Currently with <alwaysSend> set to false, notification mails are sent only if the build state changes or if the state is ERROR or FAILURE and the notifier has been configured with error/failure.
This means that for a build in state SUCCESS, notification mails are not sent every time a build is run.

Indeed the expected behavior should be that notification mails are sent every time the build state matches the one configured per notifier. If a notifier is configured with "Send on Success" it wants to receive an email every time the project is built with success.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/CONTINUUM-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefano Nichele updated CONTINUUM-1845:
---------------------------------------

    Attachment: patch.diff

Patch for this issue.

Just AbstractContinuumNotifier.shouldNotify (in Continuum Notifier API) has been changed.

> Notification mails is not always sent but just if the build state changes
> -------------------------------------------------------------------------
>
>                 Key: CONTINUUM-1845
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1845
>             Project: Continuum
>          Issue Type: Bug
>          Components: Notification Subsystem
>    Affects Versions: 1.1
>            Reporter: Stefano Nichele
>         Attachments: patch.diff
>
>
> Currently with <alwaysSend> set to false, notification mails are sent only if the build state changes or if the state is ERROR or FAILURE and the notifier has been configured with error/failure.
> This means that for a build in state SUCCESS, notification mails are not sent every time a build is run.
> Indeed the expected behavior should be that notification mails are sent every time the build state matches the one configured per notifier. If a notifier is configured with "Send on Success" it wants to receive an email every time the project is built with success.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/CONTINUUM-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefano Nichele updated CONTINUUM-1845:
---------------------------------------

    Attachment: continuum-notifier-api-1.1.jar

For the interested one, this is the jar built with the patch (it can be applied to continuum 1.1)

It must be copied in
{{./apps/continuum/webapp/WEB-INF/lib/ }}
replacing the old one.

> Notification mails is not always sent but just if the build state changes
> -------------------------------------------------------------------------
>
>                 Key: CONTINUUM-1845
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1845
>             Project: Continuum
>          Issue Type: Bug
>          Components: Notification Subsystem
>    Affects Versions: 1.1
>            Reporter: Stefano Nichele
>         Attachments: continuum-notifier-api-1.1.jar, patch.diff
>
>
> Currently with <alwaysSend> set to false, notification mails are sent only if the build state changes or if the state is ERROR or FAILURE and the notifier has been configured with error/failure.
> This means that for a build in state SUCCESS, notification mails are not sent every time a build is run.
> Indeed the expected behavior should be that notification mails are sent every time the build state matches the one configured per notifier. If a notifier is configured with "Send on Success" it wants to receive an email every time the project is built with success.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/CONTINUUM-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145129#action_145129 ]

nichele edited comment on CONTINUUM-1845 at 8/15/08 4:03 AM:
---------------------------------------------------------------------

For the interested one, this is the jar built with the patch (it can be applied to continuum 1.1)

It must be copied in
    ./apps/continuum/webapp/WEB-INF/lib/
replacing the old one.


      was (Author: nichele):
    For the interested one, this is the jar built with the patch (it can be applied to continuum 1.1)

It must be copied in
{{./apps/continuum/webapp/WEB-INF/lib/ }}
replacing the old one.

 

> Notification mails is not always sent but just if the build state changes
> -------------------------------------------------------------------------
>
>                 Key: CONTINUUM-1845
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1845
>             Project: Continuum
>          Issue Type: Bug
>          Components: Notification Subsystem
>    Affects Versions: 1.1
>            Reporter: Stefano Nichele
>         Attachments: continuum-notifier-api-1.1.jar, patch.diff
>
>
> Currently with <alwaysSend> set to false, notification mails are sent only if the build state changes or if the state is ERROR or FAILURE and the notifier has been configured with error/failure.
> This means that for a build in state SUCCESS, notification mails are not sent every time a build is run.
> Indeed the expected behavior should be that notification mails are sent every time the build state matches the one configured per notifier. If a notifier is configured with "Send on Success" it wants to receive an email every time the project is built with success.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/CONTINUUM-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse updated CONTINUUM-1845:
----------------------------------------

      Fix Version/s: 1.2
    Patch Submitted: [Yes]

Patch to review, I'm not sure about this change.
How to configure the notifier to send only on state change?

> Notification mails is not always sent but just if the build state changes
> -------------------------------------------------------------------------
>
>                 Key: CONTINUUM-1845
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1845
>             Project: Continuum
>          Issue Type: Bug
>          Components: Notification Subsystem
>    Affects Versions: 1.1
>            Reporter: Stefano Nichele
>             Fix For: 1.2
>
>         Attachments: continuum-notifier-api-1.1.jar, patch.diff
>
>
> Currently with <alwaysSend> set to false, notification mails are sent only if the build state changes or if the state is ERROR or FAILURE and the notifier has been configured with error/failure.
> This means that for a build in state SUCCESS, notification mails are not sent every time a build is run.
> Indeed the expected behavior should be that notification mails are sent every time the build state matches the one configured per notifier. If a notifier is configured with "Send on Success" it wants to receive an email every time the project is built with success.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/CONTINUUM-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145324#action_145324 ]

Emmanuel Venisse commented on CONTINUUM-1845:
---------------------------------------------

ok, I looked at the patch in details and I'm not agree with the change.

With this patch, I can't get mail only if the state change like it is done today to not be spamed.
For my projects, I want to know if the build is back to success but I don't want to receive 300 mails by hours.

I'll probably accept the patch if a new method is added (isSendOnStateChanged), The value of it should be true by default and can be modified from the UI.

> Notification mails is not always sent but just if the build state changes
> -------------------------------------------------------------------------
>
>                 Key: CONTINUUM-1845
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1845
>             Project: Continuum
>          Issue Type: Bug
>          Components: Notification Subsystem
>    Affects Versions: 1.1
>            Reporter: Stefano Nichele
>             Fix For: 1.2
>
>         Attachments: continuum-notifier-api-1.1.jar, patch.diff
>
>
> Currently with <alwaysSend> set to false, notification mails are sent only if the build state changes or if the state is ERROR or FAILURE and the notifier has been configured with error/failure.
> This means that for a build in state SUCCESS, notification mails are not sent every time a build is run.
> Indeed the expected behavior should be that notification mails are sent every time the build state matches the one configured per notifier. If a notifier is configured with "Send on Success" it wants to receive an email every time the project is built with success.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/CONTINUUM-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145864#action_145864 ]

Thomas Demande commented on CONTINUUM-1845:
-------------------------------------------

I personally think that this issue is taken by the wrong side.

Looking at the mailing list thread that initiated that issue, the problem described was that {{<alwaysSend>}} was sending message to every notifier, even if we configured not to send that state to that notifier.

My thought is that we are missing a property here, something like {{<sameStateSend>}}, that would allow more fine grained customization.

Use case :

* Notifier A for successful builds
* Notifier B for failure builds
* {{<alwaysSend>false</alwaysSend>}}
* {{<sameStateSend>true</sameStateSend>}}

=> a second successfull build will be notified to A, not to B.

And I think that use case is the missing one in Continuum

> Notification mails is not always sent but just if the build state changes
> -------------------------------------------------------------------------
>
>                 Key: CONTINUUM-1845
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1845
>             Project: Continuum
>          Issue Type: Bug
>          Components: Notification Subsystem
>    Affects Versions: 1.1
>            Reporter: Stefano Nichele
>             Fix For: 1.2
>
>         Attachments: continuum-notifier-api-1.1.jar, patch.diff
>
>
> Currently with <alwaysSend> set to false, notification mails are sent only if the build state changes or if the state is ERROR or FAILURE and the notifier has been configured with error/failure.
> This means that for a build in state SUCCESS, notification mails are not sent every time a build is run.
> Indeed the expected behavior should be that notification mails are sent every time the build state matches the one configured per notifier. If a notifier is configured with "Send on Success" it wants to receive an email every time the project is built with success.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/CONTINUUM-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146571#action_146571 ]

Stefano Nichele commented on CONTINUUM-1845:
--------------------------------------------

As suggested in the mailing list, a new configuration parameter should be the right thing to do also in my opinion (unfortunatelly I was not able to provide a complete patch but I think that the mine is enough in several cases)
Personally I would suggest to set sameStateSend to true as default since in this way we have the expected behavior at least for new  users, but in this ways the behavior will change for the old users.

> Notification mails is not always sent but just if the build state changes
> -------------------------------------------------------------------------
>
>                 Key: CONTINUUM-1845
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1845
>             Project: Continuum
>          Issue Type: Bug
>          Components: Notification Subsystem
>    Affects Versions: 1.1
>            Reporter: Stefano Nichele
>             Fix For: 1.2.1
>
>         Attachments: continuum-notifier-api-1.1.jar, patch.diff
>
>
> Currently with <alwaysSend> set to false, notification mails are sent only if the build state changes or if the state is ERROR or FAILURE and the notifier has been configured with error/failure.
> This means that for a build in state SUCCESS, notification mails are not sent every time a build is run.
> Indeed the expected behavior should be that notification mails are sent every time the build state matches the one configured per notifier. If a notifier is configured with "Send on Success" it wants to receive an email every time the project is built with success.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/CONTINUUM-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wendy Smoak updated CONTINUUM-1845:
-----------------------------------

    Fix Version/s:     (was: 1.2.1)
                   1.x

Moving this out of the 1.2.1 bucket as discussed on dev@.

http://www.nabble.com/Releasing-1.2.1-td19948265.html

> Notification mails is not always sent but just if the build state changes
> -------------------------------------------------------------------------
>
>                 Key: CONTINUUM-1845
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1845
>             Project: Continuum
>          Issue Type: Bug
>          Components: Notification Subsystem
>    Affects Versions: 1.1
>            Reporter: Stefano Nichele
>             Fix For: 1.x
>
>         Attachments: continuum-notifier-api-1.1.jar, patch.diff
>
>
> Currently with <alwaysSend> set to false, notification mails are sent only if the build state changes or if the state is ERROR or FAILURE and the notifier has been configured with error/failure.
> This means that for a build in state SUCCESS, notification mails are not sent every time a build is run.
> Indeed the expected behavior should be that notification mails are sent every time the build state matches the one configured per notifier. If a notifier is configured with "Send on Success" it wants to receive an email every time the project is built with success.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira