[jira] Created: (COCOON3-2) Add an XSchema Validator as PipeLineComponent

Add an XSchema Validator as PipeLineComponent
---------------------------------------------

                 Key: COCOON3-2
                 URL: https://issues.apache.org/jira/browse/COCOON3-2
             Project: Cocoon 3
          Issue Type: Improvement
          Components: cocoon-pipeline
    Affects Versions: 3.0.0-alpha-2
            Reporter: Simone Tripodi
            Assignee: Cocoon Developers Team
            Priority: Minor
             Fix For: 3.0.0-alpha-2


XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi updated COCOON3-2:
---------------------------------

    Attachment: XSchemaProcessor.patch

The provided implementation uses JAXP APIs to realize XSchema validation.
Simple testcase contained in the patch

> Add an XSchema Validator as PipeLineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Cocoon Developers Team
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz reassigned COCOON3-2:
------------------------------------

    Assignee: Reinhard Poetz  (was: Cocoon Developers Team)

> Add an XSchema Validator as PipeLineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz closed COCOON3-2.
--------------------------------

    Resolution: Fixed

I've applied the patch. Thanks Simone.

This patch has reminded me that we have to do something about error handling. In the case of invalid XML, a RuntimeException is thrown ATM which isn't really helpful. OTOH, checked exceptions all over the place might not be helpful either.

> Add an XSchema Validator as PipeLineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz reopened COCOON3-2:
----------------------------------


Simone, can you explain what the SchemaErrorHandler is supposed to do? Steven and I don't understand why it keeps references to raised exceptions. Also the getThrowable() method isn't used (which is actually not possible because the SchemaErrorHandler is created inline without keeping a reference to it in the transformer.

> Add an XSchema Validator as PipeLineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638302#action_12638302 ]

Simone Tripodi commented on COCOON3-2:
--------------------------------------

Hi Reinhard,
in the private mail I sent you days ago, about the Validator, I asked your help on this because I didn't understand how did you use the handler, so I prepared the handler to be managed in a similar way you did with the Transformer.
So, at this time, as you noticed, is not meaningful :(

> Add an XSchema Validator as PipeLineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638314#action_12638314 ]

Steven Dolg commented on COCOON3-2:
-----------------------------------

Ah, never mind.
This is some code we took from Cocoon 2.2 without changes.
We will have a look at this and probably rework it someday.

Thanks Simone.

> Add an XSchema Validator as PipeLineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz closed COCOON3-2.
--------------------------------

    Resolution: Fixed

The SchemaErrorHandler throws a specific unchecked exception (SchemaValidationException) when the XML is invalid now.

> Add an XSchema Validator as PipeLineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Simone Tripodi]

Hi Reinhard, Hi Steven (and nice to meet you!!!!)
is there a way I can help you to close the issue related to the FIXME in

/cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/component/sax/SchemaProcessorTransformer.java

Best regards,
Simone

2008/10/9 Reinhard Poetz (JIRA) <jira@...>:

>
>     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Reinhard Poetz closed COCOON3-2.
> --------------------------------
>
>    Resolution: Fixed
>
> The SchemaErrorHandler throws a specific unchecked exception (SchemaValidationException) when the XML is invalid now.
>
>> Add an XSchema Validator as PipeLineComponent
>> ---------------------------------------------
>>
>>                 Key: COCOON3-2
>>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>>             Project: Cocoon 3
>>          Issue Type: Improvement
>>          Components: cocoon-pipeline
>>    Affects Versions: 3.0.0-alpha-2
>>            Reporter: Simone Tripodi
>>            Assignee: Reinhard Poetz
>>            Priority: Minor
>>             Fix For: 3.0.0-alpha-2
>>
>>         Attachments: XSchemaProcessor.patch
>>
>>
>> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
>> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

--
My LinkedIn profile: http://www.linkedin.com/in/simonetripodi
My GoogleCode profile: http://code.google.com/u/simone.tripodi/
My Picasa: http://picasaweb.google.com/simone.tripodi/
My Tube: http://www.youtube.com/user/stripodi
My Del.icio.us: http://del.icio.us/simone.tripodi

[Reinhard Pötz-2]

Simone Tripodi wrote:
> Hi Reinhard, Hi Steven (and nice to meet you!!!!)
> is there a way I can help you to close the issue related to the FIXME in
>
> /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/component/sax/SchemaProcessorTransformer.java

Yes, very appreciated.

If you want to use the SchemaProcessorTransformer in a sitemap, you have
to provide a default constructor and implement the setConfiguration()
method which gives the component access to all sitemap parameters. (e.g.
see the FileGenerator).

The 'cocoon-sample' module should give you an idea how you can define a
pipeline in a sitemap. If you haven't run the 'cocoon-sample' module
yet, see the README.txt in the root directory of Cocoon 3.

If this doesn't answer all your questions, just let us know.

--
Reinhard Pötz                           Managing Director, {Indoqa} GmbH
                         http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member                  reinhard@...
________________________________________________________________________

     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi updated COCOON3-2:
---------------------------------

    Attachment: SchemaProcessorInSiteMap.patch

The second uploaded patch contains the fix to use the SchemaProcessorTransformer in the SiteMap.

Example included, plugged in the cocoon-samples, main page also updated.

> Add an XSchema Validator as PipeLineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: SchemaProcessorInSiteMap.patch, XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Simone Tripodi]

Hi Reinhard, Steven,
sorry if I'm a little late but I had some work to do. In attach on the
COCOON3-2 Jira's issue you can find the patch we need.
Just a small note: in way to run the example, Jetty replied on port
8888 instead of 8190 as wrote in the README.
I hope that's all useful.
Best regards!!!
Simone

2008/10/10 Reinhard Pötz <reinhard@...>:

> Simone Tripodi wrote:
>> Hi Reinhard, Hi Steven (and nice to meet you!!!!)
>> is there a way I can help you to close the issue related to the FIXME in
>>
>> /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/component/sax/SchemaProcessorTransformer.java
>
> Yes, very appreciated.
>
> If you want to use the SchemaProcessorTransformer in a sitemap, you have
> to provide a default constructor and implement the setConfiguration()
> method which gives the component access to all sitemap parameters. (e.g.
> see the FileGenerator).
>
> The 'cocoon-sample' module should give you an idea how you can define a
> pipeline in a sitemap. If you haven't run the 'cocoon-sample' module
> yet, see the README.txt in the root directory of Cocoon 3.
>
> If this doesn't answer all your questions, just let us know.
>
> --
> Reinhard Pötz                           Managing Director, {Indoqa} GmbH
>                         http://www.indoqa.com/en/people/reinhard.poetz/
>
> Member of the Apache Software Foundation
> Apache Cocoon Committer, PMC member                  reinhard@...
> ________________________________________________________________________
>

--
My LinkedIn profile: http://www.linkedin.com/in/simonetripodi
My GoogleCode profile: http://code.google.com/u/simone.tripodi/
My Picasa: http://picasaweb.google.com/simone.tripodi/
My Tube: http://www.youtube.com/user/stripodi
My Del.icio.us: http://del.icio.us/simone.tripodi

     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz reopened COCOON3-2:
----------------------------------


Thanks for your contribution. I will have a look at it asap.

> Add an XSchema Validator as PipeLineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: SchemaProcessorInSiteMap.patch, XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz closed COCOON3-2.
--------------------------------

    Resolution: Fixed

Patch applied. Thanks Simone!

> Add an XSchema Validator as PipelineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: SchemaProcessorInSiteMap.patch, XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz updated COCOON3-2:
---------------------------------

    Summary: Add an XSchema Validator as PipelineComponent  (was: Add an XSchema Validator as PipeLineComponent)

> Add an XSchema Validator as PipelineComponent
> ---------------------------------------------
>
>                 Key: COCOON3-2
>                 URL: https://issues.apache.org/jira/browse/COCOON3-2
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Simone Tripodi
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: SchemaProcessorInSiteMap.patch, XSchemaProcessor.patch
>
>
> XSchema Validation can be performed as an Identity Transformer where the input will be filter by the XSchema validation.
> An error occurs - and the pipeline will be break - when the input is not valid against the declared XML Schema.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.