[jira] Created: (CARGO-598) deployable/properties/name is ignored by deployEar when deploying a EAR file to container

deployable/properties/name is ignored by deployEar when deploying a EAR file to container
-----------------------------------------------------------------------------------------

                 Key: CARGO-598
                 URL: http://jira.codehaus.org/browse/CARGO-598
             Project: Cargo
          Issue Type: Bug
          Components: Core
         Environment: Any
            Reporter: Kaizer Sogiawala


org.codehaus.cargo.container.spi.deployer.AbstractCopyingInstalledLocalDeployer.deployEar ignores the deployable/properties/name configuration from Maven2 plugin

file: core/api/container/src/main/java/org/codehaus/cargo/container/spi/deployer/AbstractCopyingInstalledLocalDeployer.java

It uses the EAR artifact name to generate the target path -- ignoring the name override specified in the POM file.  I will try to provide a patch to this.



--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/CARGO-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kaizer Sogiawala updated CARGO-598:
-----------------------------------

    Attachment: CARGO-598-deployEar.patch

Patch to fix the reported issue is attached.

In api/container/src/main/java/org/codehaus/cargo/container/spi/deployer/AbstractCopyingInstalledLocalDeployer.java
Changed the deployEar method to use the name property of Ear,  Ear.name, instead of the EAR's artifact file name.

In api/container/src/main/java/org/codehaus/cargo/container/spi/deployer/AbstractCopyingInstalledLocalDeployer.java
Changed the parseName to store the file name, including the file extension, of the Ear artifact when deployable/properties/name is not specified. The deployEar now uses this name to form the destination filename. Hence the extension is required.

> deployable/properties/name is ignored by deployEar when deploying a EAR file to container
> -----------------------------------------------------------------------------------------
>
>                 Key: CARGO-598
>                 URL: http://jira.codehaus.org/browse/CARGO-598
>             Project: Cargo
>          Issue Type: Bug
>          Components: Core
>         Environment: Any
>            Reporter: Kaizer Sogiawala
>         Attachments: CARGO-598-deployEar.patch
>
>
> org.codehaus.cargo.container.spi.deployer.AbstractCopyingInstalledLocalDeployer.deployEar ignores the deployable/properties/name configuration from Maven2 plugin
> file: core/api/container/src/main/java/org/codehaus/cargo/container/spi/deployer/AbstractCopyingInstalledLocalDeployer.java
> It uses the EAR artifact name to generate the target path -- ignoring the name override specified in the POM file.  I will try to provide a patch to this.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/CARGO-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=147980#action_147980 ]

wing-tung Leung commented on CARGO-598:
---------------------------------------

We have a related problem, and could use this kind of solution. Our deployment target is a local JBoss server and the deployable is copied directly into the deploy directory. Our JBoss server hosts multiple modules (1 EAR, 1 EJB, 1 WAR) and they must be deployed in a fixed order.

We use the JBoss PrefixDeploymentSorter and prefix the filename with a digit to ensure correct startup order. Instead of having a clean artifact name like "salesModule" in our Maven repository, we fallback to "1salesModule". The latter name is really ugly, and we'd prefer to specify the prefix in the deployment configuration instead of our global artifact ID.

Would you accept a patch where the target name can be defined inside in the deployable tag? If yes, I will try to supply a patch ..

> deployable/properties/name is ignored by deployEar when deploying a EAR file to container
> -----------------------------------------------------------------------------------------
>
>                 Key: CARGO-598
>                 URL: http://jira.codehaus.org/browse/CARGO-598
>             Project: Cargo
>          Issue Type: Bug
>          Components: Core
>         Environment: Any
>            Reporter: Kaizer Sogiawala
>         Attachments: CARGO-598-deployEar.patch
>
>
> org.codehaus.cargo.container.spi.deployer.AbstractCopyingInstalledLocalDeployer.deployEar ignores the deployable/properties/name configuration from Maven2 plugin
> file: core/api/container/src/main/java/org/codehaus/cargo/container/spi/deployer/AbstractCopyingInstalledLocalDeployer.java
> It uses the EAR artifact name to generate the target path -- ignoring the name override specified in the POM file.  I will try to provide a patch to this.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email