[jira] Created: (CAMEL-968) Allow for overriding of the Main.showOptions() method

Allow for overriding of the Main.showOptions() method
-----------------------------------------------------

                 Key: CAMEL-968
                 URL: https://issues.apache.org/activemq/browse/CAMEL-968
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-spring
    Affects Versions: 1.4.0
            Reporter: Geoff Gibbs
            Priority: Minor
         Attachments: Main.patch

Currently if you subclass the org.apache.camel.spring.Main class, then the command line options of Main are available, but using -h produces a list of options headed by:

"Apache Camel Runner takes the following options"

It would be nice to be able to change this in the sub-class. Overriding showOptions() is not satisfactory and the option list is stored a a private field with no getter, meaning the list of options cannot be generated.

I have provided a patch for one possible solution, that allows for just the header part of showOptions() to be overriden.
(it also moves the generation of the information line into the Option class instead of the showOptions method itself to allow for further customisation, if required.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46269#action_46269 ]

Claus Ibsen commented on CAMEL-968:
-----------------------------------

Geoff, could you re attach the patch file granting license to ASF. We can not accept the patch without this license.

> Allow for overriding of the Main.showOptions() method
> -----------------------------------------------------
>
>                 Key: CAMEL-968
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-968
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.4.0
>            Reporter: Geoff Gibbs
>            Priority: Minor
>         Attachments: Main.patch
>
>
> Currently if you subclass the org.apache.camel.spring.Main class, then the command line options of Main are available, but using -h produces a list of options headed by:
> "Apache Camel Runner takes the following options"
> It would be nice to be able to change this in the sub-class. Overriding showOptions() is not satisfactory and the option list is stored a a private field with no getter, meaning the list of options cannot be generated.
> I have provided a patch for one possible solution, that allows for just the header part of showOptions() to be overriden.
> (it also moves the generation of the information line into the Option class instead of the showOptions method itself to allow for further customisation, if required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46346#action_46346 ]

Claus Ibsen commented on CAMEL-968:
-----------------------------------

Geoff if you need this in 1.5 then you should re attach the patch ASAP. We are starting to cut a RC really soon.

> Allow for overriding of the Main.showOptions() method
> -----------------------------------------------------
>
>                 Key: CAMEL-968
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-968
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.4.0
>            Reporter: Geoff Gibbs
>            Priority: Minor
>         Attachments: Main.patch
>
>
> Currently if you subclass the org.apache.camel.spring.Main class, then the command line options of Main are available, but using -h produces a list of options headed by:
> "Apache Camel Runner takes the following options"
> It would be nice to be able to change this in the sub-class. Overriding showOptions() is not satisfactory and the option list is stored a a private field with no getter, meaning the list of options cannot be generated.
> I have provided a patch for one possible solution, that allows for just the header part of showOptions() to be overriden.
> (it also moves the generation of the information line into the Option class instead of the showOptions method itself to allow for further customisation, if required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoff Gibbs updated CAMEL-968:
------------------------------

    Attachment: Main.patch

> Allow for overriding of the Main.showOptions() method
> -----------------------------------------------------
>
>                 Key: CAMEL-968
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-968
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.4.0
>            Reporter: Geoff Gibbs
>            Priority: Minor
>         Attachments: Main.patch
>
>
> Currently if you subclass the org.apache.camel.spring.Main class, then the command line options of Main are available, but using -h produces a list of options headed by:
> "Apache Camel Runner takes the following options"
> It would be nice to be able to change this in the sub-class. Overriding showOptions() is not satisfactory and the option list is stored a a private field with no getter, meaning the list of options cannot be generated.
> I have provided a patch for one possible solution, that allows for just the header part of showOptions() to be overriden.
> (it also moves the generation of the information line into the Option class instead of the showOptions method itself to allow for further customisation, if required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoff Gibbs updated CAMEL-968:
------------------------------

    Attachment:     (was: Main.patch)

> Allow for overriding of the Main.showOptions() method
> -----------------------------------------------------
>
>                 Key: CAMEL-968
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-968
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.4.0
>            Reporter: Geoff Gibbs
>            Priority: Minor
>         Attachments: Main.patch
>
>
> Currently if you subclass the org.apache.camel.spring.Main class, then the command line options of Main are available, but using -h produces a list of options headed by:
> "Apache Camel Runner takes the following options"
> It would be nice to be able to change this in the sub-class. Overriding showOptions() is not satisfactory and the option list is stored a a private field with no getter, meaning the list of options cannot be generated.
> I have provided a patch for one possible solution, that allows for just the header part of showOptions() to be overriden.
> (it also moves the generation of the information line into the Option class instead of the showOptions method itself to allow for further customisation, if required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-968:
------------------------------

         Assignee: Claus Ibsen
    Fix Version/s: 1.5.0

> Allow for overriding of the Main.showOptions() method
> -----------------------------------------------------
>
>                 Key: CAMEL-968
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-968
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.4.0
>            Reporter: Geoff Gibbs
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: Main.patch
>
>
> Currently if you subclass the org.apache.camel.spring.Main class, then the command line options of Main are available, but using -h produces a list of options headed by:
> "Apache Camel Runner takes the following options"
> It would be nice to be able to change this in the sub-class. Overriding showOptions() is not satisfactory and the option list is stored a a private field with no getter, meaning the list of options cannot be generated.
> I have provided a patch for one possible solution, that allows for just the header part of showOptions() to be overriden.
> (it also moves the generation of the information line into the Option class instead of the showOptions method itself to allow for further customisation, if required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-968.
-------------------------------

    Resolution: Fixed

Applied path with thanks.

> Allow for overriding of the Main.showOptions() method
> -----------------------------------------------------
>
>                 Key: CAMEL-968
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-968
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.4.0
>            Reporter: Geoff Gibbs
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: Main.patch
>
>
> Currently if you subclass the org.apache.camel.spring.Main class, then the command line options of Main are available, but using -h produces a list of options headed by:
> "Apache Camel Runner takes the following options"
> It would be nice to be able to change this in the sub-class. Overriding showOptions() is not satisfactory and the option list is stored a a private field with no getter, meaning the list of options cannot be generated.
> I have provided a patch for one possible solution, that allows for just the header part of showOptions() to be overriden.
> (it also moves the generation of the information line into the Option class instead of the showOptions method itself to allow for further customisation, if required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.