[jira] Created: (CAMEL-737) When getContext().addInterceptorStrategy(new Tracer()); is added in a RouteBuilder class, then the timer component does not work

When getContext().addInterceptorStrategy(new Tracer());  is added in a RouteBuilder class, then the timer component does not work
---------------------------------------------------------------------------------------------------------------------------------

                 Key: CAMEL-737
                 URL: https://issues.apache.org/activemq/browse/CAMEL-737
             Project: Apache Camel
          Issue Type: Bug
    Affects Versions: 1.4.0
            Reporter: Charles Moulliard
             Fix For: 1.4.0


When

getContext().addInterceptorStrategy(new Tracer());

is added in a RouteBuilder Class, then the timer component does not start.

e.g.

public class RouteBuilder extends RouteBuilder {

    getContext().addInterceptorStrategy(new Tracer());

    public void configure() {

        from("timer://export")
        .to("bean:myBean");
    }
}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-737:
------------------------------

    Fix Version/s: 1.5.0
                       (was: 1.4.0)

Moving to Camel 1.5

> When getContext().addInterceptorStrategy(new Tracer());  is added in a RouteBuilder class, then the timer component does not work
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-737
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-737
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Charles Moulliard
>             Fix For: 1.5.0
>
>
> When
> getContext().addInterceptorStrategy(new Tracer());
> is added in a RouteBuilder Class, then the timer component does not start.
> e.g.
> public class RouteBuilder extends RouteBuilder {
>     getContext().addInterceptorStrategy(new Tracer());
>     public void configure() {
>         from("timer://export")
>         .to("bean:myBean");
>     }
> }

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44385#action_44385 ]

William Tam commented on CAMEL-737:
-----------------------------------

let me take a look.

> When getContext().addInterceptorStrategy(new Tracer());  is added in a RouteBuilder class, then the timer component does not work
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-737
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-737
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Charles Moulliard
>             Fix For: 1.5.0
>
>
> When
> getContext().addInterceptorStrategy(new Tracer());
> is added in a RouteBuilder Class, then the timer component does not start.
> e.g.
> public class RouteBuilder extends RouteBuilder {
>     getContext().addInterceptorStrategy(new Tracer());
>     public void configure() {
>         from("timer://export")
>         .to("bean:myBean");
>     }
> }

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44389#action_44389 ]

William Tam commented on CAMEL-737:
-----------------------------------

It was caused by NPE thrown by TraceFormatter

java.lang.NullPointerException
        at org.apache.camel.processor.interceptor.TraceFormatter.getBodyTypeAsString(TraceFormatter.java:124)
        at org.apache.camel.processor.interceptor.TraceFormatter.format(TraceFormatter.java:46)
        at org.apache.camel.processor.interceptor.TraceInterceptor.format(TraceInterceptor.java:68)
        at org.apache.camel.processor.Logger.logMessage(Logger.java:218)
        at org.apache.camel.processor.Logger.process(Logger.java:125)
        at org.apache.camel.processor.interceptor.TraceInterceptor.logException(TraceInterceptor.java:128)
        at org.apache.camel.processor.interceptor.TraceInterceptor.process(TraceInterceptor.java:59)
        at org.apache.camel.impl.converter.AsyncProcessorTypeConverter$ProcessorToAsyncProcessorBridge.process(AsyncProcessorTypeConverter.java:43)
        at org.apache.camel.processor.DeadLetterChannel.process(DeadLetterChannel.java:155)
        at org.apache.camel.processor.DeadLetterChannel.process(DeadLetterChannel.java:91)
        at org.apache.camel.processor.UnitOfWorkProcessor.process(UnitOfWorkProcessor.java:39)
        at org.apache.camel.util.AsyncProcessorHelper.process(AsyncProcessorHelper.java:41)
        at org.apache.camel.processor.DelegateAsyncProcessor.process(DelegateAsyncProcessor.java:66)
        at org.apache.camel.component.timer.TimerConsumer.sendTimerExchange(TimerConsumer.java:91)
        at org.apache.camel.component.timer.TimerConsumer$1.run(TimerConsumer.java:48)
        at java.util.TimerThread.mainLoop(Unknown Source)
        at java.util.TimerThread.run(Unknown Source)

> When getContext().addInterceptorStrategy(new Tracer());  is added in a RouteBuilder class, then the timer component does not work
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-737
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-737
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Charles Moulliard
>             Fix For: 1.5.0
>
>         Attachments: Camel-737.patch
>
>
> When
> getContext().addInterceptorStrategy(new Tracer());
> is added in a RouteBuilder Class, then the timer component does not start.
> e.g.
> public class RouteBuilder extends RouteBuilder {
>     getContext().addInterceptorStrategy(new Tracer());
>     public void configure() {
>         from("timer://export")
>         .to("bean:myBean");
>     }
> }

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William Tam updated CAMEL-737:
------------------------------

    Attachment: Camel-737.patch

The patch fixes NPE in TraceFormatter and adds an unit test .

> When getContext().addInterceptorStrategy(new Tracer());  is added in a RouteBuilder class, then the timer component does not work
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-737
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-737
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Charles Moulliard
>             Fix For: 1.5.0
>
>         Attachments: Camel-737.patch
>
>
> When
> getContext().addInterceptorStrategy(new Tracer());
> is added in a RouteBuilder Class, then the timer component does not start.
> e.g.
> public class RouteBuilder extends RouteBuilder {
>     getContext().addInterceptorStrategy(new Tracer());
>     public void configure() {
>         from("timer://export")
>         .to("bean:myBean");
>     }
> }

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William Tam updated CAMEL-737:
------------------------------

    Attachment:     (was: Camel-737.patch)

> When getContext().addInterceptorStrategy(new Tracer());  is added in a RouteBuilder class, then the timer component does not work
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-737
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-737
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Charles Moulliard
>             Fix For: 1.5.0
>
>
> When
> getContext().addInterceptorStrategy(new Tracer());
> is added in a RouteBuilder Class, then the timer component does not start.
> e.g.
> public class RouteBuilder extends RouteBuilder {
>     getContext().addInterceptorStrategy(new Tracer());
>     public void configure() {
>         from("timer://export")
>         .to("bean:myBean");
>     }
> }

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William Tam updated CAMEL-737:
------------------------------

    Attachment: Camel-737.patch

> When getContext().addInterceptorStrategy(new Tracer());  is added in a RouteBuilder class, then the timer component does not work
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-737
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-737
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Charles Moulliard
>             Fix For: 1.5.0
>
>         Attachments: Camel-737.patch
>
>
> When
> getContext().addInterceptorStrategy(new Tracer());
> is added in a RouteBuilder Class, then the timer component does not start.
> e.g.
> public class RouteBuilder extends RouteBuilder {
>     getContext().addInterceptorStrategy(new Tracer());
>     public void configure() {
>         from("timer://export")
>         .to("bean:myBean");
>     }
> }

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned CAMEL-737:
---------------------------------

    Assignee: Claus Ibsen

> When getContext().addInterceptorStrategy(new Tracer());  is added in a RouteBuilder class, then the timer component does not work
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-737
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-737
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Charles Moulliard
>            Assignee: Claus Ibsen
>             Fix For: 1.5.0
>
>         Attachments: Camel-737.patch
>
>
> When
> getContext().addInterceptorStrategy(new Tracer());
> is added in a RouteBuilder Class, then the timer component does not start.
> e.g.
> public class RouteBuilder extends RouteBuilder {
>     getContext().addInterceptorStrategy(new Tracer());
>     public void configure() {
>         from("timer://export")
>         .to("bean:myBean");
>     }
> }

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-737.
-------------------------------

    Resolution: Fixed

Applied patch with thanks to William Tam.

Also fixed the same problem for LogFormatter.

> When getContext().addInterceptorStrategy(new Tracer());  is added in a RouteBuilder class, then the timer component does not work
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-737
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-737
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Charles Moulliard
>            Assignee: Claus Ibsen
>             Fix For: 1.5.0
>
>         Attachments: Camel-737.patch
>
>
> When
> getContext().addInterceptorStrategy(new Tracer());
> is added in a RouteBuilder Class, then the timer component does not start.
> e.g.
> public class RouteBuilder extends RouteBuilder {
>     getContext().addInterceptorStrategy(new Tracer());
>     public void configure() {
>         from("timer://export")
>         .to("bean:myBean");
>     }
> }

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.