[jira] Created: (AMQNET-95) IMessageProducer contains methods for creating messages which is not in agreement with JMS API and .NET vendor specific messaging APIs

IMessageProducer contains methods for creating messages which is not in agreement with JMS API and .NET vendor specific messaging APIs
--------------------------------------------------------------------------------------------------------------------------------------

                 Key: AMQNET-95
                 URL: https://issues.apache.org/activemq/browse/AMQNET-95
             Project: ActiveMQ .Net
          Issue Type: Bug
          Components: ActiveMQ Client
            Reporter: Mark Pollack
            Assignee: James Strachan
             Fix For: 1.0


The IMessageProducer interface contains CreateMessage, CreateTextMessage(), etc.   I don't see why these are on the IMessageProducer interface as it quite non-standard.  I guess there is a good reason for this but I can't think of one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/AMQNET-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Gomes resolved AMQNET-95.
-----------------------------

      Assignee: Jim Gomes  (was: James Strachan)
    Resolution: Won't Fix

The reason they are there are for programming convenience.  Instead of being forced to pass around two objects (both the ISession and IMessageProducer objects), the user of NMS only need pass around IMessageProducer in order to create and send messages.

While JMS may not support the message creation functions on IMessageProducer, and only has them on ISession, I think an argument can be made that the creation and sending of a message are compatible responsibilities.

In any case, this can be viewed as a fairly harmless extension to the API from the user's perspective as they are free to not use the CreateMessage() functions on IMessageProducer and only use them from ISession.  Also, for client provider implementors, this shouldn't be too hard to work with as there are currently three client provider implementations (ActiveMQ, EMS, and MSMQ) that were able to easily wrap these functions and forward them to the IMessageProducer's ISession object.

> IMessageProducer contains methods for creating messages which is not in agreement with JMS API and .NET vendor specific messaging APIs
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-95
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-95
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ Client
>            Reporter: Mark Pollack
>            Assignee: Jim Gomes
>             Fix For: 1.0
>
>
> The IMessageProducer interface contains CreateMessage, CreateTextMessage(), etc.   I don't see why these are on the IMessageProducer interface as it quite non-standard.  I guess there is a good reason for this but I can't think of one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/AMQNET-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44779#action_44779 ]

Mark Pollack commented on AMQNET-95:
------------------------------------

As you can tell, I'd be more inclined to be as close to the standard spec as possible just to avoid any confusion.  I ran across it while creating stub implementations for testing in case that gives another perspective to the usage patterns involved with this extension.  I've already felt that swapping out a TIBCO impl to use NMS was a bit more work than it should have been, though this isn't one of those cases because I didn't have those calls to begin with.  Other examples of 'a bit more work' is the use of message.body, message.properites, and a few other odds and ends.  These are not 'major' issues, just wanted to hear your take on the matter.

> IMessageProducer contains methods for creating messages which is not in agreement with JMS API and .NET vendor specific messaging APIs
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-95
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-95
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ Client
>            Reporter: Mark Pollack
>            Assignee: Jim Gomes
>             Fix For: 1.0
>
>
> The IMessageProducer interface contains CreateMessage, CreateTextMessage(), etc.   I don't see why these are on the IMessageProducer interface as it quite non-standard.  I guess there is a good reason for this but I can't think of one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.