[jira] Created: (AGILA-44) Option to use JSP Includes for rendering forms for Task nodes.

[Agila - Dev mailing list]

Option to use JSP Includes for rendering forms for Task nodes.
--------------------------------------------------------------

         Key: AGILA-44
         URL: http://issues.apache.org/jira/browse/AGILA-44
     Project: Agila
        Type: New Feature
  Components: BPM Console  
    Reporter: Geoff Howard


The existing HTTPRenderer used in the sample webapp only supports returning the html of the form as a String.  This leads to an ugly StringBuffer exercise in the sample LeaveApplication process as noted in the code.  This patch provides an alternate renderer and adjusts the existing rendering mechanism to account for the new option.

There is certainly a cleaner way to do this - most probably through a true callback method, but for now this seems to work.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[Agila - Dev mailing list]

     [ http://issues.apache.org/jira/browse/AGILA-44?page=all ]

Geoff Howard updated AGILA-44:
------------------------------

    Attachment: jspIncludeForm.patch

proposed patch

> Option to use JSP Includes for rendering forms for Task nodes.
> --------------------------------------------------------------
>
>          Key: AGILA-44
>          URL: http://issues.apache.org/jira/browse/AGILA-44
>      Project: Agila
>         Type: New Feature
>   Components: BPM Console
>     Reporter: Geoff Howard
>  Attachments: jspIncludeForm.patch
>
> The existing HTTPRenderer used in the sample webapp only supports returning the html of the form as a String.  This leads to an ugly StringBuffer exercise in the sample LeaveApplication process as noted in the code.  This patch provides an alternate renderer and adjusts the existing rendering mechanism to account for the new option.
> There is certainly a cleaner way to do this - most probably through a true callback method, but for now this seems to work.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[Agila - Dev mailing list]

     [ http://issues.apache.org/jira/browse/AGILA-44?page=all ]

Chris Lim reassigned AGILA-44:
------------------------------

    Assign To: Chris Lim

> Option to use JSP Includes for rendering forms for Task nodes.
> --------------------------------------------------------------
>
>          Key: AGILA-44
>          URL: http://issues.apache.org/jira/browse/AGILA-44
>      Project: Agila
>         Type: New Feature
>   Components: BPM Console
>     Reporter: Geoff Howard
>     Assignee: Chris Lim
>  Attachments: jspIncludeForm.patch
>
> The existing HTTPRenderer used in the sample webapp only supports returning the html of the form as a String.  This leads to an ugly StringBuffer exercise in the sample LeaveApplication process as noted in the code.  This patch provides an alternate renderer and adjusts the existing rendering mechanism to account for the new option.
> There is certainly a cleaner way to do this - most probably through a true callback method, but for now this seems to work.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[Christopher Lim]

> There is certainly a cleaner way to do this - most probably through a true callback method, but for now this seems to work.

I agree. Thanks for the patch. :)


Chris




On 3/27/06, Geoff Howard (JIRA) <agila-dev@...> wrote:

> Option to use JSP Includes for rendering forms for Task nodes.
> --------------------------------------------------------------
>
>          Key: AGILA-44
>          URL: http://issues.apache.org/jira/browse/AGILA-44
>      Project: Agila
>         Type: New Feature
>   Components: BPM Console
>     Reporter: Geoff Howard
>
>
> The existing HTTPRenderer used in the sample webapp only supports returning the html of the form as a String.  This leads to an ugly StringBuffer exercise in the sample LeaveApplication process as noted in the code.  This patch provides an alternate renderer and adjusts the existing rendering mechanism to account for the new option.
>
> There is certainly a cleaner way to do this - most probably through a true callback method, but for now this seems to work.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
>
>

[Agila - Dev mailing list]

     [ http://issues.apache.org/jira/browse/AGILA-44?page=all ]

Geoff Howard updated AGILA-44:
------------------------------

    Description:
The existing HTTPRenderer used in the sample webapp only supports returning the html of the form as a String.  This leads to an ugly StringBuffer exercise in the sample LeaveApplication process as noted in the code.  

The first patch provides an alternate renderer and adjusts the existing rendering mechanism to account for the new option.  

The second patch takes a different approach and can replace the first.  It uses RequestDispatcher.include in the task's render method to accomplish the same goal, and also allows fall back behavior for tasks that wish to generate the form html as a string using some other method.  It uses less overall code, but does rely on servlet spec 2.4 (agila bpm seems to already depend on 2.4 anyway).  

  was:
The existing HTTPRenderer used in the sample webapp only supports returning the html of the form as a String.  This leads to an ugly StringBuffer exercise in the sample LeaveApplication process as noted in the code.  This patch provides an alternate renderer and adjusts the existing rendering mechanism to account for the new option.

There is certainly a cleaner way to do this - most probably through a true callback method, but for now this seems to work.


alternate patch

> Option to use JSP Includes for rendering forms for Task nodes.
> --------------------------------------------------------------
>
>          Key: AGILA-44
>          URL: http://issues.apache.org/jira/browse/AGILA-44
>      Project: Agila
>         Type: New Feature

>   Components: BPM Console
>     Reporter: Geoff Howard
>     Assignee: Chris Lim
>  Attachments: jspIncludeForm.patch
>
> The existing HTTPRenderer used in the sample webapp only supports returning the html of the form as a String.  This leads to an ugly StringBuffer exercise in the sample LeaveApplication process as noted in the code.  
> The first patch provides an alternate renderer and adjusts the existing rendering mechanism to account for the new option.  
> The second patch takes a different approach and can replace the first.  It uses RequestDispatcher.include in the task's render method to accomplish the same goal, and also allows fall back behavior for tasks that wish to generate the form html as a string using some other method.  It uses less overall code, but does rely on servlet spec 2.4 (agila bpm seems to already depend on 2.4 anyway).  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[Agila - Dev mailing list]

     [ http://issues.apache.org/jira/browse/AGILA-44?page=all ]

Geoff Howard updated AGILA-44:
------------------------------

    Attachment: jspRenderingForm-2.patch

> Option to use JSP Includes for rendering forms for Task nodes.
> --------------------------------------------------------------
>
>          Key: AGILA-44
>          URL: http://issues.apache.org/jira/browse/AGILA-44
>      Project: Agila
>         Type: New Feature

>   Components: BPM Console
>     Reporter: Geoff Howard
>     Assignee: Chris Lim
>  Attachments: jspIncludeForm.patch, jspRenderingForm-2.patch
>
> The existing HTTPRenderer used in the sample webapp only supports returning the html of the form as a String.  This leads to an ugly StringBuffer exercise in the sample LeaveApplication process as noted in the code.  
> The first patch provides an alternate renderer and adjusts the existing rendering mechanism to account for the new option.  
> The second patch takes a different approach and can replace the first.  It uses RequestDispatcher.include in the task's render method to accomplish the same goal, and also allows fall back behavior for tasks that wish to generate the form html as a string using some other method.  It uses less overall code, but does rely on servlet spec 2.4 (agila bpm seems to already depend on 2.4 anyway).  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira