[jira] Commented: (TRINIDAD-799) Add agent version support in skinning

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596463#action_12596463 ]

Blake Sullivan commented on TRINIDAD-799:
-----------------------------------------

If the current implementation doesn't match what was discussed, I believe that we should back it out and release.  We can but the agreed upon api in the next release.

> Add agent version support in skinning
> -------------------------------------
>
>                 Key: TRINIDAD-799
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-799
>             Project: MyFaces Trinidad
>          Issue Type: Wish
>          Components: Components
>    Affects Versions: 1.0.4-core
>            Reporter: Andrew Robinson
>            Assignee: Andrew Robinson
>             Fix For:  1.0.8-core,  1.2.8-core
>
>
> The current skinning functionality does not allow a skinning developer to differentiate between different browser versions. For example, it is possible to tell the difference between IE and firefox, but not between IE 6 and 7
> Possible implementations:
> 1) @agent ie6 { ... }
> 2) @agent ie { @agentVersion 6 { ... } }
> A more general and more powerful approach would be to allow developers to use a regex on the browser version:
> @agent match /MSIE [67]/

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Scott O'Bryan]

That's certainly an option Blake..  Let's see what kind of progress
Andrew is able to make with it and, if he doesn't make any progress,
I'll back it out and begin the release process.

Scott

Blake Sullivan (JIRA) wrote:

>     [ https://issues.apache.org/jira/browse/TRINIDAD-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596463#action_12596463 ]
>
> Blake Sullivan commented on TRINIDAD-799:
> -----------------------------------------
>
> If the current implementation doesn't match what was discussed, I believe that we should back it out and release.  We can but the agreed upon api in the next release.
>
>
>  
>> Add agent version support in skinning
>> -------------------------------------
>>
>>                 Key: TRINIDAD-799
>>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-799
>>             Project: MyFaces Trinidad
>>          Issue Type: Wish
>>          Components: Components
>>    Affects Versions: 1.0.4-core
>>            Reporter: Andrew Robinson
>>            Assignee: Andrew Robinson
>>             Fix For:  1.0.8-core,  1.2.8-core
>>
>>
>> The current skinning functionality does not allow a skinning developer to differentiate between different browser versions. For example, it is possible to tell the difference between IE and firefox, but not between IE 6 and 7
>> Possible implementations:
>> 1) @agent ie6 { ... }
>> 2) @agent ie { @agentVersion 6 { ... } }
>> A more general and more powerful approach would be to allow developers to use a regex on the browser version:
>> @agent match /MSIE [67]/
>>    
>
>  

[Andrew Robinson-5]

Okay, it is in w/ version matching, no min/max ranges though. Thought
the ranges could wait for a future release.

-Andrew

On Tue, May 13, 2008 at 11:48 AM, Scott O'Bryan <darkarena@...> wrote:

> That's certainly an option Blake..  Let's see what kind of progress Andrew
> is able to make with it and, if he doesn't make any progress, I'll back it
> out and begin the release process.
>
>  Scott
>
>
>
>  Blake Sullivan (JIRA) wrote:
>
> >    [
> https://issues.apache.org/jira/browse/TRINIDAD-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596463#action_12596463
> ]
> > Blake Sullivan commented on TRINIDAD-799:
> > -----------------------------------------
> >
> > If the current implementation doesn't match what was discussed, I believe
> that we should back it out and release.  We can but the agreed upon api in
> the next release.
> >
> >
> >
> >
> > > Add agent version support in skinning
> > > -------------------------------------
> > >
> > >                Key: TRINIDAD-799
> > >                URL: https://issues.apache.org/jira/browse/TRINIDAD-799
> > >            Project: MyFaces Trinidad
> > >         Issue Type: Wish
> > >         Components: Components
> > >   Affects Versions: 1.0.4-core
> > >           Reporter: Andrew Robinson
> > >           Assignee: Andrew Robinson
> > >            Fix For:  1.0.8-core,  1.2.8-core
> > >
> > >
> > > The current skinning functionality does not allow a skinning developer
> to differentiate between different browser versions. For example, it is
> possible to tell the difference between IE and firefox, but not between IE 6
> and 7
> > > Possible implementations:
> > > 1) @agent ie6 { ... }
> > > 2) @agent ie { @agentVersion 6 { ... } }
> > > A more general and more powerful approach would be to allow developers
> to use a regex on the browser version:
> > > @agent match /MSIE [67]/
> > >
> > >
> >
> >
> >
>
>