« Return to Thread: [jira] Created: (TAPESTRY-2518) Saving a form with a Grid after sorting saves data to incorrect rows.

[jira] Commented: (TAPESTRY-2518) Saving a form with a Grid after sorting saves data to incorrect rows.

by Tapestry - Dev mailing list :: Rate this Message:

Reply to Author | View in Thread


    [ https://issues.apache.org/jira/browse/TAPESTRY-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628666#action_12628666 ]

Howard M. Lewis Ship commented on TAPESTRY-2518:
------------------------------------------------

At issue here is that the Grid stores row *indexes* into the form, not the primary key of the row.  It might be nice to change that.  Like Loop, Grid should be use a PrimaryKeyEncoder  (optionally).  However, this may also be related to TAPESTRY-2636, meaning that the Grid will work correctly as long as the underlying data has not shifted (had rows added or removed).

> Saving a form with a Grid after sorting saves data to incorrect rows.
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2518
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2518
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.13
>            Reporter: Skow
>
> I could be doing something wrong, but it seems as though saving a Grid of objects which is included in a Form after sorting the Grid to a non-default sort order results in the rows getting saved under an incorrect ID.  
> This should be reproducible in any form which includes an editable Grid, but here are the basic steps to reproduce what I'm seeing:
> 1.  Create an Item class which includes an ID column and a Name column (I have mine set up as a Hibernate object)
> 2.  Create a Page with a Grid of Items inside a Form including a Save button which causes the Page to persist the Items
> 3.  Create a couple Items (ID, name):
>       (1, 'item one')
>       (2, 'item two')
> 4.  Bring up the Page, Sort by ID (or Name) so they look like this:
>       (2, 'item two')
>       (1, 'item one')
> 5.  Click Save and if I'm not mistaken you will see:
>       (2, 'item one')      <-- Note that Item 2 is now associated with the name of Item 1...
>       (1, 'item two')
> Please let me know if there is any difficulty in reproducing this issue and I will try to put together a minimal code example.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

 « Return to Thread: [jira] Created: (TAPESTRY-2518) Saving a form with a Grid after sorting saves data to incorrect rows.

LightInTheBox - Buy quality products at wholesale price!