« Return to Thread: [jira] Created: (JCR-1180) DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db schema

[jira] Commented: (JCR-1180) DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db schema

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View in Thread


    [ https://issues.apache.org/jira/browse/JCR-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594811#action_12594811 ]

Thomas Mueller commented on JCR-1180:
-------------------------------------

> something that works within the scope of the existing schemaObjectPrefix option

I think splitting schemaObjectPrefix in 'schema name' 'dot' 'table name prefix' is an ugly hack: Any database identifier can contain spaces and dots if it's quoted. Correct parsing and splitting the schemaObjectPrefix would be really ugly and database dependent (MS SQL Server supports [] quotes, MySQL backticks; but most database use double quotes, which need to be escaped in XML). I think it's better to use a distinct case sensitive property 'schemaName' as in the java.sql.DatabaseMetaData.getColumns and so forth. In my view, the schemaObjectPrefix should be kept as is (tableNamePrefix would actually be the right name).


> DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db schema
> ---------------------------------------------------------------------------------
>
>                 Key: JCR-1180
>                 URL: https://issues.apache.org/jira/browse/JCR-1180
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>         Environment: All
>            Reporter: Kev Jackson
>            Assignee: Thomas Mueller
>            Priority: Minor
>         Attachments: jackrabbit-core.patch
>
>
> I have a need to store my repository objects under a different db schema than the default for the rdbms (I'm using postgresql, so in my case the default is 'public')
> The current implementation of the DatabasePersistenceManager and DatabaseFileSystem do not support changing the schema.
> Problems:
> - schemaObjectPrefix allows the user to add a table prefix, but you cannot use this to set a schema ie <schema>.table, as the . is stripped out and replaced with an escaped version
> - schema param currently refers to a ddl resource, not what people would naturally think is the param to set the schema for the repository
> Fix:
> - rename the current schema -> schemaDDL
> - add an optional schema param which allows the user to select which schema they want to use
> - improve error messages so that when an incorrect schemaDDL is chosen the user doesn't have to dig through nabble etc to find an answer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

 « Return to Thread: [jira] Created: (JCR-1180) DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db schema

LightInTheBox - Buy quality products at wholesale price