« Return to Thread: [jira] Created: (JCR-1180) DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db schema

[jira] Commented: (JCR-1180) DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db schema

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View in Thread


    [ https://issues.apache.org/jira/browse/JCR-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536228 ]

Thomas Mueller commented on JCR-1180:
-------------------------------------

Hi,

> schema param currently refers to a ddl resource,
> not what people would naturally think is the param to set the schema for the repository

You are right, 'schema' is unfortunate. I also thought it means the database schema, and spent a lot of time because of this (actually, twice - the last time two weeks ago). I would love to change it to schemaDDL, the only problem I see is compatibility. What about: support a new setting 'schemaDDL' (or what about just 'ddl', or 'ddlResource'), and change all samples to use this property name. But still support 'schema' as well for backward compatibility.

> - add an optional schema param which allows the user to select which schema they want to use

what about 'schemaName' to avoid a clash with the deprecated 'schema' property? Currently the user name is hard coded (ResultSet rs = metaData.getTables(null, userName, tableName, null))

> - improve error messages so that when an incorrect schemaDDL is chosen the user doesn't have to dig through nabble etc to find an answer

Sure. What about "Configuration error: The resource xyz.ddl could not be found"?

Thanks,
Thomas

> DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db schema
> ---------------------------------------------------------------------------------
>
>                 Key: JCR-1180
>                 URL: https://issues.apache.org/jira/browse/JCR-1180
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.4
>         Environment: All
>            Reporter: Kev Jackson
>             Fix For: 1.4
>
>         Attachments: jackrabbit-core-add-schema.patch
>
>
> I have a need to store my repository objects under a different db schema than the default for the rdbms (I'm using postgresql, so in my case the default is 'public')
> The current implementation of the DatabasePersistenceManager and DatabaseFileSystem do not support changing the schema.
> Problems:
> - schemaObjectPrefix allows the user to add a table prefix, but you cannot use this to set a schema ie <schema>.table, as the . is stripped out and replaced with an escaped version
> - schema param currently refers to a ddl resource, not what people would naturally think is the param to set the schema for the repository
> Fix:
> - rename the current schema -> schemaDDL
> - add an optional schema param which allows the user to select which schema they want to use
> - improve error messages so that when an incorrect schemaDDL is chosen the user doesn't have to dig through nabble etc to find an answer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

 « Return to Thread: [jira] Created: (JCR-1180) DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db schema

LightInTheBox - Buy quality products at wholesale price!