« Return to Thread: [jira] Created: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet

[jira] Commented: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View in Thread


    [ https://issues.apache.org/jira/browse/DERBY-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611601#action_12611601 ]

Kristian Waagan commented on DERBY-3763:
----------------------------------------

Thanks for the comment Dag.

I'll wait a while and see if anyone else has strong feelings about this.
If I go ahead with the current proposal, I'll change the comments/strings as you pointed out.
Since the current convention comes from the old test harness, I think it is acceptable to change it to something better in the new one. Others might think differently, if so please speak up.


BTW; If it had been "DerbyNet" and "DerbyClient" it would have been kind of okay, but it's "DerbyNet" and "DerbyNetClient" and that I find confusing.

> Rename BaseJDBCTestCase.usingDerbyNet
> -------------------------------------
>
>                 Key: DERBY-3763
>                 URL: https://issues.apache.org/jira/browse/DERBY-3763
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Trivial
>         Attachments: derby-3763-1a-usingDB2Client.diff, derby-3763-1a-usingDB2Client.stat
>
>
> The names of the methods 'usingDerbyNet' and 'usingDerbyNetClient' in BaseJDBCTestCase are confusing.
> I propose we change the one used to tell if we are using the DB2 client driver (JCC).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

 « Return to Thread: [jira] Created: (DERBY-3763) Rename BaseJDBCTestCase.usingDerbyNet

LightInTheBox - Buy quality products at wholesale price!