[janino-dev] [jira] Created: (JANINO-120) Janino Compiler Needs Optimizing

Janino Compiler Needs Optimizing
--------------------------------

                 Key: JANINO-120
                 URL: http://jira.codehaus.org/browse/JANINO-120
             Project: Janino
          Issue Type: Bug
            Reporter: Matt Fowles
            Assignee: Arno Unkrig


On large projects the janino compiler is orders of magnitude slower than javac.  It would be nice to optimize this a bit.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=137677#action_137677 ]

Matt Fowles commented on JANINO-120:
------------------------------------

UnitCompiler.findLocalVariable is also a hot spot, but I have not been able to find a clean way to optimize that yet.

> Janino Compiler Needs Optimizing
> --------------------------------
>
>                 Key: JANINO-120
>                 URL: http://jira.codehaus.org/browse/JANINO-120
>             Project: Janino
>          Issue Type: Bug
>            Reporter: Matt Fowles
>            Assignee: Arno Unkrig
>         Attachments: fieldcache.patch
>
>
> On large projects the janino compiler is orders of magnitude slower than javac.  It would be nice to optimize this a bit.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/JANINO-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Fowles updated JANINO-120:
-------------------------------

    Attachment: fieldcache.patch

Profiling identified field look up as one of the larger hotspots in the code.  The attached patch uses a map to find fields instead of looping through all of the fields.

> Janino Compiler Needs Optimizing
> --------------------------------
>
>                 Key: JANINO-120
>                 URL: http://jira.codehaus.org/browse/JANINO-120
>             Project: Janino
>          Issue Type: Bug
>            Reporter: Matt Fowles
>            Assignee: Arno Unkrig
>         Attachments: fieldcache.patch
>
>
> On large projects the janino compiler is orders of magnitude slower than javac.  It would be nice to optimize this a bit.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138633#action_138633 ]

Arno Unkrig commented on JANINO-120:
------------------------------------

Hi there,

me too spent a lot of time thinking about "findLocalVariable()". Optimizing the "inner" "findLocalVariable()" doesn't help because you rarely declare more than a few variables in one LVDS. Bummer.

> Janino Compiler Needs Optimizing
> --------------------------------
>
>                 Key: JANINO-120
>                 URL: http://jira.codehaus.org/browse/JANINO-120
>             Project: Janino
>          Issue Type: Bug
>            Reporter: Matt Fowles
>            Assignee: Arno Unkrig
>         Attachments: fieldcache.patch
>
>
> On large projects the janino compiler is orders of magnitude slower than javac.  It would be nice to optimize this a bit.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/JANINO-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arno Unkrig resolved JANINO-120.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.5.15

Applied the patch. Please test!

If everything's OK, close this issue; otherwise "repoen". (Status "resolved" means that _you_ have to work on this issue.)

> Janino Compiler Needs Optimizing
> --------------------------------
>
>                 Key: JANINO-120
>                 URL: http://jira.codehaus.org/browse/JANINO-120
>             Project: Janino
>          Issue Type: Bug
>            Reporter: Matt Fowles
>            Assignee: Arno Unkrig
>             Fix For: 2.5.15
>
>         Attachments: fieldcache.patch
>
>
> On large projects the janino compiler is orders of magnitude slower than javac.  It would be nice to optimize this a bit.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138635#action_138635 ]

Matt Fowles commented on JANINO-120:
------------------------------------

Thanks for the update.  I am in the middle of a slightly larger rework for findLocalVariable() that will make BlockStatements contain a cache of local variables in their scope, with maximal sharing of these caches between statements.  I will open a new ticket for that when I finish it.

> Janino Compiler Needs Optimizing
> --------------------------------
>
>                 Key: JANINO-120
>                 URL: http://jira.codehaus.org/browse/JANINO-120
>             Project: Janino
>          Issue Type: Bug
>            Reporter: Matt Fowles
>            Assignee: Arno Unkrig
>             Fix For: 2.5.15
>
>         Attachments: fieldcache.patch
>
>
> On large projects the janino compiler is orders of magnitude slower than javac.  It would be nice to optimize this a bit.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138637#action_138637 ]

Arno Unkrig commented on JANINO-120:
------------------------------------

Admittedly, your response time is faster than mine ;-)

> Janino Compiler Needs Optimizing
> --------------------------------
>
>                 Key: JANINO-120
>                 URL: http://jira.codehaus.org/browse/JANINO-120
>             Project: Janino
>          Issue Type: Bug
>            Reporter: Matt Fowles
>            Assignee: Arno Unkrig
>             Fix For: 2.5.15
>
>         Attachments: fieldcache.patch
>
>
> On large projects the janino compiler is orders of magnitude slower than javac.  It would be nice to optimize this a bit.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138638#action_138638 ]

Arno Unkrig commented on JANINO-120:
------------------------------------

Yep, opening a new ticket is the right way of doing it. (No chained issues...)

> Janino Compiler Needs Optimizing
> --------------------------------
>
>                 Key: JANINO-120
>                 URL: http://jira.codehaus.org/browse/JANINO-120
>             Project: Janino
>          Issue Type: Bug
>            Reporter: Matt Fowles
>            Assignee: Arno Unkrig
>             Fix For: 2.5.15
>
>         Attachments: fieldcache.patch
>
>
> On large projects the janino compiler is orders of magnitude slower than javac.  It would be nice to optimize this a bit.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138754#action_138754 ]

Matt Fowles commented on JANINO-120:
------------------------------------

Arno, I do not have the ability to close this issue.  I think my login to Jira does not have the power.  You can consider this closed.

> Janino Compiler Needs Optimizing
> --------------------------------
>
>                 Key: JANINO-120
>                 URL: http://jira.codehaus.org/browse/JANINO-120
>             Project: Janino
>          Issue Type: Bug
>            Reporter: Matt Fowles
>            Assignee: Arno Unkrig
>             Fix For: 2.5.15
>
>         Attachments: fieldcache.patch
>
>
> On large projects the janino compiler is orders of magnitude slower than javac.  It would be nice to optimize this a bit.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email