[RFC][Fwd: Re: [RFC][Fwd: Re: Missing Oxygen icons (for Okular)]]

[James Richard Tyrer]

Having considered this further.  It appears that originally I had it
backwards.  Now that I see that, my headache has greatly improved.

Please see attached toolbar from Okular Part.

Notice the problem that the:

        go-next
        go-previous

icons are being used for two different purposes (each).

I had always thought that it was the two icons circled in Green that
needed to be changed.  However, this is wrong.  It is the icons circled
in Red that need to be changed.  Specifically, these 4 icons refer
movement through the pages in a document.

So I am requesting that we have 4 new icons for these KDE Standard Actions:

        DocumentBack
        DocumentForward
        Begin
        End

Naming these icons needs to consider that we have 4 icons:

        go-previous
        go-next
        go-first
        go-last

and we need to fallback to them so my first suggestions will not be
satisfactory.  They will need to be named:


        go-previous-<something>
        go-next-<something>
        go-first-<something>
        go-last-<something>

and it seems to be a no-brainer that: "page" is the obvious choice:

        go-previous-page
        go-next-page
        go-first-page
        go-last-page

These icon names would replace the current icon names for the 4 KDE
Standard Actions:

        DocumentBack
        DocumentForward
        Begin
        End

Note that if these new icons do not exist, it will make no difference
because these KDE Standard Actions currently use:

        go-previous
        go-next
        go-first
        go-last

Will this be satisfactory, or are there further comments.

I presume that KDE-Core needs to approve this so they are CCd.

Note that this leaves open the question of whether or not we need a
third context:

    go-next-view
    go-previous-view

--
JRT


-------- Original Message --------
Subject: Re: [kde-artists] [RFC][Fwd: Re: Missing Oxygen icons (for Okular)]
Date: Tue, 10 Jun 2008 14:55:29 -0700
From: James Richard Tyrer <tyrerj@...>
To: KDE Artists <kde-artists@...>
CC: Jakob Petsovits <jpetso@...>
References: <48346E93.6060908@...>

James Richard Tyrer wrote:
<SNIP>
> I would be glad to hear other suggestions from other artists.  Since
> these are to be the icon names for the KDE Standard Actions:
>
> DocumentBack
> DocumentForward
>
> perhaps, "document" is the best choice.

NO, NO, NO:  This is wrong.  The person who wrote it must have been
having a stupid attack.

Well, perhaps, he was partially correct.

We have a situation I don't like that the arrow icons are used in two
contexts.  Perhaps it would be better to also have actions:

        DocumentStart
        DocumentEnd

But we have th actions:

        Begin
        End

which are the document context and the names really don't matter as long
as developers know what they are for.

So, we could make icons:

        go-page-first
        go-page-previous
        go-page-next
        go-page-last

which would solve the issue in a different way.
       
Still, it would probably be clearer if we had a third contest:

    go-next-view
    go-previous-view

Specifically to handle non-ordered Next & Previous events such as those
needed for viewing a PDF in Okular.  This works like a browser does and
we could use the "go-previous" & "go-next" if they were not the same as
the icons for the Page actions.

And as I said before:

> NOTE: that it is not relevant if Oxygen isn't going to have these icons
> since they will fallback to:
>
> go-next
> go-previous

--
JRT


______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists



______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[Jakob Petsovits]

On Saturday, 14. June 2008, James Richard Tyrer wrote:

> Notice the problem that the:
>
> go-next
> go-previous
>
> icons are being used for two different purposes (each).
>
> I had always thought that it was the two icons circled in Green that
> needed to be changed.  However, this is wrong.  It is the icons circled
> in Red that need to be changed.  Specifically, these 4 icons refer
> movement through the pages in a document.

I agree - the difference in concept is not so much document vs. "global",
but rather history based navigation (green in your screenshot) vs.
order based navigation (red), as I have sometimes stated in the past already.

I spent some more time thinking about how those red icons could be
generalized, because clearly they have use cases beyond just page navigation
but still with similar meaning. What I found is that "order based navigation"
(which was also the most popular usage of the former "1*arrow" icons) is
merely another term for navigating inside a list of concrete items. Examples:

- Many of the 1*arrow usages were actually icons next to real list widgets.
- Page navigation in Okular happens on a fixed list of pages.
- Image navigation in Gwenview (or the Gwenview part in Konqueror)
  happens on a list of image files in the current directory.

Having pondered a long time about which term would be appropriate for this
action, I think this one is actually able to be descriptive and general
enough as well as it matches the meaning of the action, plus it's short and
easy to understand.

So I would propose go-*-list (read as "go to [whatever] item in a list") while
keeping go-* as generic arrow icon that's used as "go to [whatever] item in
history" when in doubt. That might be slightly against the naming spec's
intentions as it regards every use of the arrow icons as navigation in a
list, but as we can't make the generic go-* icons specific to history based
navigation, I feel like the next best thing to do is to special-case lists of
concrete items from "imaginary" lists like history.

We could use the former "1{left,right,up,down}arrow" icons under those new
names, we'd just need new icons for the {first,last,top,bottom} icons as the
double arrow from these icons doesn't match these names. I would assume that
this is doable.

> I presume that KDE-Core needs to approve this so they are CCd.
>
> Note that this leaves open the question of whether or not we need a
> third context:
>
>     go-next-view
>     go-previous-view

If I understand correctly, those are what you planned for history based
navigation inside a specific document (as opposed to "in Konqueror"), right?
I would think that the "document" prefix makes sense in this instance - it's
just like the original "go-{next,previous}" icon, just specific to documents.

Perhaps we can repurpose the current "go-{up,down}-search" icons, add
-next and -previous versions of those too, and rename them as go-*-document?

Wishes,
  Jakob
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

Jakob Petsovits wrote:

> On Saturday, 14. June 2008, James Richard Tyrer wrote:
>> Notice the problem that the:
>>
>> go-next
>> go-previous
>>
>> icons are being used for two different purposes (each).
>>
>> I had always thought that it was the two icons circled in Green that
>> needed to be changed.  However, this is wrong.  It is the icons circled
>> in Red that need to be changed.  Specifically, these 4 icons refer
>> movement through the pages in a document.
>
> I agree - the difference in concept is not so much document vs. "global",
> but rather history based navigation (green in your screenshot) vs.
> order based navigation (red), as I have sometimes stated in the past already.

Yes.

Note that the definition of the uses of the Green circled icons is not
as strict since they can be used for anything which is: Back & Forward.

Your point is taken regarding the Red circled icons.  There are probably
multiple uses for them.  However, we do need to consider that although
these might be used for other things that they would be specifically for
the KDE Standard Actions which have default tooltips (L to R):

        First Page
        Back in the Document
        Forward in the Document
        Last Page

So, I think that they should be designed and named with that specific
use in mind which is why I suggested: "page" for <something>.  However,
I do note that this word is only for the humans, the code doesn't care
what the word for <something> is as long is there is one.

I do wish that there were consistent names for these 4 actions.  But, it
is too late for that.  So, this basically leaves us with either "page"
or "document" as the two logical choices for <something>.

Perhaps consistent tooltips as well (that can be changed in 4.2).  I
there some reason that:

        Previous Page
        Next Page

weren't used?  I am getting off topic, but KDE-Core, please consider
these tooltips.
       
--
JRT
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

James Richard Tyrer wrote:
> Having considered this further.  It appears that originally I had it
> backwards.  Now that I see that, my headache has greatly improved.

I guess that I am not doing to well.  I noticed that I still have this
wrong.  I am not going to go through this all again, I will summarize.

We *do* have the 4 needed Page KDE Standard actions:

       {action}          {tooltip}                 {suggested icon name}

       FirstPage         First Page                go-first-page
       Prior             Previous Page             go-previous-page
       Next              Next Page                 go-next-page
       LastPage          Last Page                 go-last-page


Then we also have:
                       
       DocumentBack      Back in the Document      go-previous-document
       DocumentForward   Forward in the Document   go-next-document

So, that seems logical and obvious.

The problem is that we now seem to be missing two standard actions (this
also seems to be the reason that I find it confusing):

       <NONE>                                      go-first
       Back              Back                      go-previous
       Forward           Forward                   go-next
       <NONE>                                      go-last

The question is whether or not we need them.

Yes, there are other ways to do this.  I started with the presumption
that the Konqueror Browser should use "Back" & "Forward" and that these
actions should use the icons "go-previous" & "go-next".

Now that I hope that this is correct, are there any further comments or
should I commit these changes?  Note that this will not make any
difference until the icons exist.  Some of the older themes have what
should be renamed: "go-previous-document" & "go-next-document".

--
JRT

______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

James Richard Tyrer wrote:

> Now that I hope that this is correct, are there any further comments
> or should I commit these changes?
>
And here is the patch [attached].

> Note that this will not make any difference until the icons exist.

My SVG USR-HiColor theme icons are available here to test the patch:

http://home.earthlink.net/~tyrerj/kde/KDE-4/go-icons_KDE4.tar.bz2

This is a complete set:

        go-bottom
        go-down
        go-first-page
        go-first
        go-last-page
        go-last
        go-next-document
        go-next-page
        go-next
        go-previous-document
        go-previous-page
        go-previous
        go-top
        go-up

--
JRT


Index: kdeui/actions/kstandardaction_p.h
===================================================================
--- kdeui/actions/kstandardaction_p.h (revision 821662)
+++ kdeui/actions/kstandardaction_p.h (working copy)
@@ -80,15 +80,15 @@ static const KStandardActionInfo g_rgAct
   { Back,          KStandardShortcut::Back, "go_back", 0, 0, "go-previous" },
   { Forward,       KStandardShortcut::Forward, "go_forward", 0, 0, "go-next" },
   { Home,          KStandardShortcut::Home, "go_home", 0, 0, "go-home" },
-  { Prior,         KStandardShortcut::Prior, "go_previous", I18N_NOOP("&Previous Page"), 0, "go-previous" },
-  { Next,          KStandardShortcut::Next, "go_next", I18N_NOOP("&Next Page"), 0, "go-next" },
+  { Prior,         KStandardShortcut::Prior, "go_previous", I18N_NOOP("&Previous Page"), 0, "go-previous-page" },
+  { Next,          KStandardShortcut::Next, "go_next", I18N_NOOP("&Next Page"), 0, "go-next-page" },
   { Goto,          KStandardShortcut::AccelNone, "go_goto", I18N_NOOP("&Go To..."), 0, 0 },
   { GotoPage,      KStandardShortcut::AccelNone, "go_goto_page", I18N_NOOP("&Go to Page..."), 0, "go-jump" },
   { GotoLine,      KStandardShortcut::GotoLine, "go_goto_line", I18N_NOOP("&Go to Line..."), 0, 0 },
-  { FirstPage,     KStandardShortcut::Begin, "go_first", I18N_NOOP("&First Page"), 0, "go-first" },
-  { LastPage,      KStandardShortcut::End, "go_last", I18N_NOOP("&Last Page"), 0, "go-last" },
-  { DocumentBack,  KStandardShortcut::AccelNone, "go_document_back", I18N_NOOP("&Back in the Document"), 0, "go-previous" },
-  { DocumentForward, KStandardShortcut::AccelNone, "go_document_forward", I18N_NOOP("&Forward in the Document"), 0, "go-next" },
+  { FirstPage,     KStandardShortcut::Begin, "go_first", I18N_NOOP("&First Page"), 0, "go-first-page" },
+  { LastPage,      KStandardShortcut::End, "go_last", I18N_NOOP("&Last Page"), 0, "go-last-page" },
+  { DocumentBack,  KStandardShortcut::AccelNone, "go_document_back", I18N_NOOP("&Back in the Document"), 0, "go-previous-document" },
+  { DocumentForward, KStandardShortcut::AccelNone, "go_document_forward", I18N_NOOP("&Forward in the Document"), 0, "go-next-document" },
 
   { AddBookmark,   KStandardShortcut::AddBookmark, "bookmark_add", I18N_NOOP("&Add Bookmark"), 0, "bookmark-new" },
   { EditBookmarks, KStandardShortcut::AccelNone, "bookmark_edit", I18N_NOOP("&Edit Bookmarks"), 0, "bookmarks" },

______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

A Wednesday 18 June 2008 19:40:55, James Richard Tyrer escreveu:

> James Richard Tyrer wrote:
> > Now that I hope that this is correct, are there any further comments
> > or should I commit these changes?
>
> And here is the patch [attached].
>
> > Note that this will not make any difference until the icons exist.
>
> My SVG USR-HiColor theme icons are available here to test the patch:
>
> http://home.earthlink.net/~tyrerj/kde/KDE-4/go-icons_KDE4.tar.bz2
>
> This is a complete set:
>
> go-bottom
> go-down
> go-first-page
> go-first
> go-last-page
> go-last
> go-next-document
> go-next-page
> go-next
> go-previous-document
> go-previous-page
> go-previous
> go-top
> go-up

what do you want me to do with that ?? we alrady have those icons , i see no
point on having duplication of icons, that was how we had them in 3.x series.
And it was a mess
if you think we should have a   go-first-page and a go-first they should be
difrent or there is no point in having 2.

--

core oxygen icon designer
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

pinheiro wrote:

> A Wednesday 18 June 2008 19:40:55, James Richard Tyrer escreveu:
>> James Richard Tyrer wrote:
>>> Now that I hope that this is correct, are there any further comments
>>> or should I commit these changes?
>> And here is the patch [attached].
>>
>>> Note that this will not make any difference until the icons exist.
>> My SVG USR-HiColor theme icons are available here to test the patch:
>>
>> http://home.earthlink.net/~tyrerj/kde/KDE-4/go-icons_KDE4.tar.bz2
>>
>> This is a complete set:
>>
>> go-bottom
>> go-down
>> go-first-page
>> go-first
>> go-last-page
>> go-last
>> go-next-document
>> go-next-page
>> go-next
>> go-previous-document
>> go-previous-page
>> go-previous
>> go-top
>> go-up
>
> what do you want me to do with that ?? we alrady have those icons , i see no
> point on having duplication of icons, that was how we had them in 3.x series.
> And it was a mess
> if you think we should have a   go-first-page and a go-first they should be
> difrent or there is no point in having 2.
>

My set of icons *are* all different.  Please either download the icons
and look at them or see this screen shot:

http://bugs.kde.org/attachment.cgi?id=25440&action=view

What won't be different is that if you use an icon theme that doesn't
have the additional icons, that there won't be any difference due to the
way the new icon naming scheme works.  So, if this is committed, and you
use Oxygen icon, you won't see any difference until the new icons are
made and committed.

--
JRT
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

James Richard Tyrer wrote:

> And here is the patch [attached].
>
And here is the RTL patch [attached]] which I have *not* tested.

Could someone that has a RTL language on their system, please help by
testing this (along with the other patch).

Single patch for both is posted here:

http://home.earthlink.net/~tyrerj/kde/KDE-4/statdard_actions0.diff

Along with a SVG only set of icons to test the patches:

http://home.earthlink.net/~tyrerj/kde/KDE-4/go-icons_KDE4.tar.bz2

Thanks.

--
JRT


Index: kstandardaction.cpp
===================================================================
--- kstandardaction.cpp (revision 822252)
+++ kstandardaction.cpp (working copy)
@@ -108,16 +108,16 @@ KAction *create(StandardAction id, const
 
     if ( QApplication::isRightToLeft() ) {
       if ( id == Prior )
-        iconName = "go-next";
+        iconName = "go-next-page";
 
       if ( id == Next )
-        iconName = "go-previous";
+        iconName = "go-previous-page";
 
       if ( id == DocumentBack )
-        iconName = "go-next";
+        iconName = "go-next-document";
 
       if ( id == DocumentForward )
-        iconName = "go-previous";
+        iconName = "go-previous-document";
     }
 
     QIcon icon = iconName.isEmpty() ? KIcon() : KIcon(iconName);

______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

James Richard Tyrer wrote:

> James Richard Tyrer wrote:
>
>> And here is the patch [attached].
>>
> And here is the RTL patch [attached]] which I have *not* tested.
>
> Could someone that has a RTL language on their system, please help by
> testing this (along with the other patch).
>
> Single patch for both is posted here:
>
> http://home.earthlink.net/~tyrerj/kde/KDE-4/statdard_actions0.diff
>
> Along with a SVG only set of icons to test the patches:
>
> http://home.earthlink.net/~tyrerj/kde/KDE-4/go-icons_KDE4.tar.bz2
>
> Thanks.
>

I found a bug with RTL.  The icons for FirstPage & LastPage need to be
reversed with RTL.  So, I updated the patch to include the bug fix.

Is this OK, are there any further comments, or should I commit it?

--
JRT


Index: kdeui/actions/kstandardaction.cpp
===================================================================
--- kdeui/actions/kstandardaction.cpp (revision 823772)
+++ kdeui/actions/kstandardaction.cpp (working copy)
@@ -108,16 +108,22 @@ KAction *create(StandardAction id, const
 
     if ( QApplication::isRightToLeft() ) {
       if ( id == Prior )
-        iconName = "go-next";
+        iconName = "go-next-page";
 
       if ( id == Next )
-        iconName = "go-previous";
+        iconName = "go-previous-page";
+
+      if ( id == FirstPage )
+ iconName = "go-last-page";
+
+      if ( id == LastPage )
+ iconName = "go-first-page";
 
       if ( id == DocumentBack )
-        iconName = "go-next";
+        iconName = "go-next-document";
 
       if ( id == DocumentForward )
-        iconName = "go-previous";
+        iconName = "go-previous-document";
     }
 
     QIcon icon = iconName.isEmpty() ? KIcon() : KIcon(iconName);
Index: kdeui/actions/kstandardaction_p.h
===================================================================
--- kdeui/actions/kstandardaction_p.h (revision 823772)
+++ kdeui/actions/kstandardaction_p.h (working copy)
@@ -80,15 +80,15 @@ static const KStandardActionInfo g_rgAct
   { Back,          KStandardShortcut::Back, "go_back", 0, 0, "go-previous" },
   { Forward,       KStandardShortcut::Forward, "go_forward", 0, 0, "go-next" },
   { Home,          KStandardShortcut::Home, "go_home", 0, 0, "go-home" },
-  { Prior,         KStandardShortcut::Prior, "go_previous", I18N_NOOP("&Previous Page"), 0, "go-previous" },
-  { Next,          KStandardShortcut::Next, "go_next", I18N_NOOP("&Next Page"), 0, "go-next" },
+  { Prior,         KStandardShortcut::Prior, "go_previous", I18N_NOOP("&Previous Page"), 0, "go-previous-page" },
+  { Next,          KStandardShortcut::Next, "go_next", I18N_NOOP("&Next Page"), 0, "go-next-page" },
   { Goto,          KStandardShortcut::AccelNone, "go_goto", I18N_NOOP("&Go To..."), 0, 0 },
   { GotoPage,      KStandardShortcut::AccelNone, "go_goto_page", I18N_NOOP("&Go to Page..."), 0, "go-jump" },
   { GotoLine,      KStandardShortcut::GotoLine, "go_goto_line", I18N_NOOP("&Go to Line..."), 0, 0 },
-  { FirstPage,     KStandardShortcut::Begin, "go_first", I18N_NOOP("&First Page"), 0, "go-first" },
-  { LastPage,      KStandardShortcut::End, "go_last", I18N_NOOP("&Last Page"), 0, "go-last" },
-  { DocumentBack,  KStandardShortcut::AccelNone, "go_document_back", I18N_NOOP("&Back in the Document"), 0, "go-previous" },
-  { DocumentForward, KStandardShortcut::AccelNone, "go_document_forward", I18N_NOOP("&Forward in the Document"), 0, "go-next" },
+  { FirstPage,     KStandardShortcut::Begin, "go_first", I18N_NOOP("&First Page"), 0, "go-first-page" },
+  { LastPage,      KStandardShortcut::End, "go_last", I18N_NOOP("&Last Page"), 0, "go-last-page" },
+  { DocumentBack,  KStandardShortcut::AccelNone, "go_document_back", I18N_NOOP("&Back in the Document"), 0, "go-previous-document" },
+  { DocumentForward, KStandardShortcut::AccelNone, "go_document_forward", I18N_NOOP("&Forward in the Document"), 0, "go-next-document" },
 
   { AddBookmark,   KStandardShortcut::AddBookmark, "bookmark_add", I18N_NOOP("&Add Bookmark"), 0, "bookmark-new" },
   { EditBookmarks, KStandardShortcut::AccelNone, "bookmark_edit", I18N_NOOP("&Edit Bookmarks"), 0, "bookmarks" },

______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

pinheiro wrote:

> A Wednesday 18 June 2008 19:40:55, James Richard Tyrer escreveu:
>> James Richard Tyrer wrote:
>>> Now that I hope that this is correct, are there any further comments
>>> or should I commit these changes?
>> And here is the patch [attached].
>>
>>> Note that this will not make any difference until the icons exist.
>> My SVG USR-HiColor theme icons are available here to test the patch:
>>
>> http://home.earthlink.net/~tyrerj/kde/KDE-4/go-icons_KDE4.tar.bz2
>>
>> This is a complete set:
>>
>> go-bottom
>> go-down
>> go-first-page
>> go-first
>> go-last-page
>> go-last
>> go-next-document
>> go-next-page
>> go-next
>> go-previous-document
>> go-previous-page
>> go-previous
>> go-top
>> go-up
>
> what do you want me to do with that ?? we alrady have those icons , i see no
> point on having duplication of icons, that was how we had them in 3.x series.
> And it was a mess
> if you think we should have a   go-first-page and a go-first they should be
> difrent or there is no point in having 2.
>

I don't really understand, however I have made:

        go-first-page
        go-last-page
        go-next-document
        go-next-page
        go-previous-document
        go-previous-page

in Oxygen style:

http://home.earthlink.net/~tyrerj/kde/KDE-4/go-icons_Oxygen.tar.bz2

and a screenshot showing them:

http://home.earthlink.net/~tyrerj/kde/KDE-4/KSA-Okular3.png

--
JRT


______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

Will commit Friday

The final patch has been posted for a while so if there are no
objections, I will commit it on Friday 7/04/08.

--
JRT
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

A Wednesday 02 July 2008 22:34:04, James Richard Tyrer escreveu:
> Will commit Friday
>
> The final patch has been posted for a while so if there are no
> objections, I will commit it on Friday 7/04/08.

In the next days i will commit most of those icons, started already with
go-next-page, so there is no need for you to commit them. Thanks.

--

core oxygen icon designer
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

pinheiro wrote:
> A Wednesday 02 July 2008 22:34:04, James Richard Tyrer escreveu:
>> Will commit Friday
>>
>> The final patch has been posted for a while so if there are no
>> objections, I will commit it on Friday 7/04/08.
>
> In the next days i will commit most of those icons, started already with
> go-next-page, so there is no need for you to commit them.
>
Thanks for the icons.

For the record, it was the changes to the code that I was talking about
committing.

--
JRT

______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[James Richard Tyrer]

James Richard Tyrer wrote:
> Will commit Friday
>
> The final patch has been posted for a while so if there are no
> objections, I will commit it on Friday 7/04/08.
>
The bug fix was committed since I wanted to be sure that it was in 4.1.
  And, Peter Penz improved the code in kstandardaction.cpp.  Changing
the large number of 'if' statements to a 'switch'.

So, there is now a different patch for TRUNK.  [Attached]

--
JRT


Index: kdeui/actions/kstandardaction.cpp
===================================================================
--- kdeui/actions/kstandardaction.cpp (revision 827546)
+++ kdeui/actions/kstandardaction.cpp (working copy)
@@ -108,12 +108,12 @@ KAction *create(StandardAction id, const
 
     if ( QApplication::isRightToLeft() ) {
      switch ( id ) {
-      case Prior:           iconName = "go-next"; break;
-      case Next:            iconName = "go-previous"; break;
+      case Prior:           iconName = "go-next-page"; break;
+      case Next:            iconName = "go-previous-page"; break;
       case FirstPage:       iconName = "go-last-page"; break;
       case LastPage:        iconName = "go-first-page"; break;
-      case DocumentBack:    iconName = "go-next"; break;
-      case DocumentForward: iconName = "go-previous"; break;
+      case DocumentBack:    iconName = "go-next-document"; break;
+      case DocumentForward: iconName = "go-previous-document"; break;
       default: break;
      }
     }
Index: kdeui/actions/kstandardaction_p.h
===================================================================
--- kdeui/actions/kstandardaction_p.h (revision 827546)
+++ kdeui/actions/kstandardaction_p.h (working copy)
@@ -80,15 +80,15 @@ static const KStandardActionInfo g_rgAct
   { Back,          KStandardShortcut::Back, "go_back", 0, 0, "go-previous" },
   { Forward,       KStandardShortcut::Forward, "go_forward", 0, 0, "go-next" },
   { Home,          KStandardShortcut::Home, "go_home", 0, 0, "go-home" },
-  { Prior,         KStandardShortcut::Prior, "go_previous", I18N_NOOP("&Previous Page"), 0, "go-previous" },
-  { Next,          KStandardShortcut::Next, "go_next", I18N_NOOP("&Next Page"), 0, "go-next" },
+  { Prior,         KStandardShortcut::Prior, "go_previous", I18N_NOOP("&Previous Page"), 0, "go-previous-page" },
+  { Next,          KStandardShortcut::Next, "go_next", I18N_NOOP("&Next Page"), 0, "go-next-page" },
   { Goto,          KStandardShortcut::AccelNone, "go_goto", I18N_NOOP("&Go To..."), 0, 0 },
   { GotoPage,      KStandardShortcut::AccelNone, "go_goto_page", I18N_NOOP("&Go to Page..."), 0, "go-jump" },
   { GotoLine,      KStandardShortcut::GotoLine, "go_goto_line", I18N_NOOP("&Go to Line..."), 0, 0 },
-  { FirstPage,     KStandardShortcut::Begin, "go_first", I18N_NOOP("&First Page"), 0, "go-first" },
-  { LastPage,      KStandardShortcut::End, "go_last", I18N_NOOP("&Last Page"), 0, "go-last" },
-  { DocumentBack,  KStandardShortcut::AccelNone, "go_document_back", I18N_NOOP("&Back in the Document"), 0, "go-previous" },
-  { DocumentForward, KStandardShortcut::AccelNone, "go_document_forward", I18N_NOOP("&Forward in the Document"), 0, "go-next" },
+  { FirstPage,     KStandardShortcut::Begin, "go_first", I18N_NOOP("&First Page"), 0, "go-first-page" },
+  { LastPage,      KStandardShortcut::End, "go_last", I18N_NOOP("&Last Page"), 0, "go-last-page" },
+  { DocumentBack,  KStandardShortcut::AccelNone, "go_document_back", I18N_NOOP("&Back in the Document"), 0, "go-previous-document" },
+  { DocumentForward, KStandardShortcut::AccelNone, "go_document_forward", I18N_NOOP("&Forward in the Document"), 0, "go-next-document" },
 
   { AddBookmark,   KStandardShortcut::AddBookmark, "bookmark_add", I18N_NOOP("&Add Bookmark"), 0, "bookmark-new" },
   { EditBookmarks, KStandardShortcut::AccelNone, "bookmark_edit", I18N_NOOP("&Edit Bookmarks"), 0, "bookmarks" },

______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

[Jakob Petsovits]

On Wednesday, 2. July 2008, James Richard Tyrer wrote:
> Will commit Friday
>
> The final patch has been posted for a while so if there are no
> objections, I will commit it on Friday 7/04/08.

On Wednesday, 2. July 2008, James Richard Tyrer wrote:

> I have not yet seen your comments on these proposed icon names:
>
> go-first-page
> go-previous-page
> go-next-page
> go-last-page
>
> go-previous-document
> go-next-document
>
> Considering the names and tooltips for the Standard Actions that they
> are to be icons for, and the fact that current practice is to use 'next'
> for 'forward' and 'previous' for 'back' in the spec (all as shown
> below), these seem to be the obvious names for these icons.
>
> I have added a pa