[PATCH 3/3] Fix the return error in filecaps

View: New views
3 Messages — Rating Filter:   Alert me  

[PATCH 3/3] Fix the return error in filecaps

by Jin Bing Guo :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

When the libcap-2.11 or newer didn't been installed on the sysytem, the filecaps testcase
would return a message instead of an error.

=============
Before patching
=============
# ./runltp -s filecaps

Running tests.......
<<<test_start>>>
tag=Filecaps stime=1222567559
cmdline="filecapstest.sh"
contacts=""
analysis=exit
initiation_status="ok"
<<<test_output>>>
incrementing stop
setcap not installed. Please install libcap-2.11 or newer from
ftp://ftp.kernel.org/pub/linux/libs/security/linux-privs/libcap2
<<<execution_status>>>
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=0
<<<test_end>>>
INFO: pan reported some tests FAIL

=============
After patching
=============
Running tests.......
<<<test_start>>>
tag=Filecaps stime=1222569141
cmdline=" export TCdat=$LTPROOT/testcases/bin;filecapstest.sh"
contacts=""
analysis=exit
initiation_status="ok"
<<<test_output>>>
incrementing stop
Filecaps 0 CONF : System doesn't support execution of the test
setcap not installed. Please install libcap-2.11 or newer from
ftp://ftp.kernel.org/pub/linux/libs/security/linux-privs/libcap2
<<<execution_status>>>
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=0 cstime=0
<<<test_end>>>
INFO: pan reported all tests PASS


Signed-off-by: Jin Bing Guo <guojb@...>
-----------
(See attached file: Fix_filecapstest.patch)


Best regards!

Jin Bing Guo 郭晋兵

Linux for System p Test
IBM China Systems & Technology Laboratory in Beijing
Tel: +86-10-82454439
Email: guojb@...
-------------------------------------
"Do today what others won't so tomorrow you do what other's can't"



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list


Fix_filecapstest.patch (736 bytes) Download Attachment

Re: [PATCH 3/3] Fix the return error in filecaps

by Subrata Modak :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Sun, 2008-09-28 at 10:38 +0800, Jin Bing Guo wrote:

> When the libcap-2.11 or newer didn't been installed on the sysytem,
> the filecaps testcase
> would return a message instead of an error.
>
> =============
> Before patching
> =============
> # ./runltp -s filecaps
>
> Running tests.......
> <<<test_start>>>
> tag=Filecaps stime=1222567559
> cmdline="filecapstest.sh"
> contacts=""
> analysis=exit
> initiation_status="ok"
> <<<test_output>>>
> incrementing stop
> setcap not installed. Please install libcap-2.11 or newer from
> ftp://ftp.kernel.org/pub/linux/libs/security/linux-privs/libcap2
> <<<execution_status>>>
> duration=0 termination_type=exited termination_id=1 corefile=no
> cutime=0 cstime=0
> <<<test_end>>>
> INFO: pan reported some tests FAIL
>
> =============
> After patching
> =============
> Running tests.......
> <<<test_start>>>
> tag=Filecaps stime=1222569141
> cmdline=" export TCdat=$LTPROOT/testcases/bin;filecapstest.sh"
> contacts=""
> analysis=exit
> initiation_status="ok"
> <<<test_output>>>
> incrementing stop
> Filecaps 0 CONF : System doesn't support execution of the test

Agreed. Thanks.

Regards--
Subrata

> setcap not installed. Please install libcap-2.11 or newer from
> ftp://ftp.kernel.org/pub/linux/libs/security/linux-privs/libcap2
> <<<execution_status>>>
> duration=0 termination_type=exited termination_id=0 corefile=no
> cutime=0 cstime=0
> <<<test_end>>>
> INFO: pan reported all tests PASS
>
>
> Signed-off-by: Jin Bing Guo <guojb@...>
> -----------
> (See attached file: Fix_filecapstest.patch)
>
>
> Best regards!
>
> Jin Bing Guo 郭晋兵
>
> Linux for System p Test
> IBM China Systems & Technology Laboratory in Beijing
> Tel: +86-10-82454439
> Email: guojb@...
> -------------------------------------
> "Do today what others won't so tomorrow you do what other's can't"
>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [PATCH 3/3] Fix the return error in filecaps

by Serge E. Hallyn :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Quoting Subrata Modak (subrata@...):
> On Sun, 2008-09-28 at 10:38 +0800, Jin Bing Guo wrote:
> > When the libcap-2.11 or newer didn't been installed on the sysytem,
> > the filecaps testcase
> > would return a message instead of an error.

'should'?  (At first I thought you meant that is what it was doing now
and you wanted to changed it, which seemed wrong :)

> > =============
> > Before patching
> > =============
> > # ./runltp -s filecaps
> >
> > Running tests.......
> > <<<test_start>>>
> > tag=Filecaps stime=1222567559
> > cmdline="filecapstest.sh"
> > contacts=""
> > analysis=exit
> > initiation_status="ok"
> > <<<test_output>>>
> > incrementing stop
> > setcap not installed. Please install libcap-2.11 or newer from
> > ftp://ftp.kernel.org/pub/linux/libs/security/linux-privs/libcap2
> > <<<execution_status>>>
> > duration=0 termination_type=exited termination_id=1 corefile=no
> > cutime=0 cstime=0
> > <<<test_end>>>
> > INFO: pan reported some tests FAIL
> >
> > =============
> > After patching
> > =============
> > Running tests.......
> > <<<test_start>>>
> > tag=Filecaps stime=1222569141
> > cmdline=" export TCdat=$LTPROOT/testcases/bin;filecapstest.sh"
> > contacts=""
> > analysis=exit
> > initiation_status="ok"
> > <<<test_output>>>
> > incrementing stop
> > Filecaps 0 CONF : System doesn't support execution of the test
>
> Agreed. Thanks.

Yes, IIUC it sounds right.

thanks,
-serge

> Regards--
> Subrata
>
> > setcap not installed. Please install libcap-2.11 or newer from
> > ftp://ftp.kernel.org/pub/linux/libs/security/linux-privs/libcap2
> > <<<execution_status>>>
> > duration=0 termination_type=exited termination_id=0 corefile=no
> > cutime=0 cstime=0
> > <<<test_end>>>
> > INFO: pan reported all tests PASS
> >
> >
> > Signed-off-by: Jin Bing Guo <guojb@...>
> > -----------
> > (See attached file: Fix_filecapstest.patch)
> >
> >
> > Best regards!
> >
> > Jin Bing Guo 郭晋兵
> >
> > Linux for System p Test
> > IBM China Systems & Technology Laboratory in Beijing
> > Tel: +86-10-82454439
> > Email: guojb@...
> > -------------------------------------
> > "Do today what others won't so tomorrow you do what other's can't"
> >
> >
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@...
> https://lists.sourceforge.net/lists/listinfo/ltp-list

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list
LightInTheBox - Buy quality products at wholesale price!