[PATCH 2/3] Fix the make install error in modify_ldt on ppc64

[Jin Bing Guo]

On ppc64, the modify_ldt cases would not been compiled. So it should be return
the message:"System doesn't support execution of the test" instead of an error message.

#uname -a
Linux ovislp1 2.6.18-92.el5 #1 SMP Tue Apr 29 13:21:29 EDT 2008 ppc64 ppc64 ppc64 GNU/Linux

To fix problem, I added the shell scripts to run the testcases.
Added two files and two patches:
testcases/kernel/syscalls/modify_ldt/run-modify_ldt01.sh
testcases/kernel/syscalls/modify_ldt/run-modify_ldt01.sh
Fix_makefile_modify_ldt.patch
Fix_runtest_syscalls.patch

==============
Before patching
==============
# ./runltp -s modify_ldt01
Running tests.......
<<<test_start>>>
tag=modify_ldt01 stime=1222564266
cmdline="modify_ldt01"
contacts=""
analysis=exit
initiation_status="pan(23602): execvp of 'modify_ldt01' (tag modify_ldt01) failed. errno:2 No such file or directory"
<<<test_output>>>
<<<execution_status>>>
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=0
<<<test_end>>>

==============
After patching
==============
# ./runltp -s modify_ldt01
Running tests.......
<<<test_start>>>
tag=modify_ldt01 stime=1222564513
cmdline="run-modify_ldt01.sh"
contacts=""
analysis=exit
initiation_status="ok"
<<<test_output>>>
incrementing stop
modify_ldt01 0 CONF : System doesn't support execution of the test
<<<execution_status>>>
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=0 cstime=0
<<<test_end>>>

In addition, the Fix_runtest_syscalls.patch also resolved the switch01 running error.
------------------
@@ -927,7 +927,7 @@ swapon02 swapon02
swapon03 swapon03

#Exclusive syscall() for POWER6 machines only
-switch01 switch01
+switch01 endian_switch01

symlink01 symlink01
symlink02 symlink02

==============
Before patching
==============
# ./runltp -s switch01
Running tests.......
<<<test_start>>>
tag=switch01 stime=1222565253
cmdline="switch01"
contacts=""
analysis=exit
initiation_status="pan(9373): execvp of 'switch01' (tag switch01) failed. errno:2 No such file or directory"
<<<test_output>>>
<<<execution_status>>>
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=0
<<<test_end>>>

==============
After patching
==============
# ./runltp -s switch01

Running tests.......
<<<test_start>>>
tag=switch01 stime=1222565270
cmdline="endian_switch01"
contacts=""
analysis=exit
initiation_status="ok"
<<<test_output>>>
incrementing stop
endian_switch01 1 CONF : Processor does not support little-endian mode
<<<execution_status>>>
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=0 cstime=0
<<<test_end>>>

Signed-off-by: Jin Bing Guo <guojb@...>
-----------
(See attached file: run-modify_ldt01.sh)(See attached file: run-modify_ldt02.sh)
(See attached file: Fix_makefile_modify_ldt.patch)(See attached file: Fix_runtest_syscalls.patch)


Best regards!

Jin Bing Guo 郭晋兵

Linux for System p Test
IBM China Systems & Technology Laboratory in Beijing
Tel: [phone]
Email: guojb@...
-------------------------------------
"Do today what others won't so tomorrow you do what other's can't"






-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Masatake YAMATO-2]

Hi,

> On ppc64, the modify_ldt cases would not been compiled. So it should be
> return
> the message:"System doesn't support execution of the test" instead of an
> error message.


Using tst_resm C function is better than using echo command.

See the comment by Vijay Kumar.
http://sourceforge.net/mailarchive/message.php?msg_name=48C67E2C.7030905%40bravegnu.org

I'm also working this area, If you are O.K., I'd like to take over your patches:

   [LTP] [PATCH 1/3] Fix the make install error in io_* testcases
   [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64

My intents are:

   1. Using check_header in cond.mk
   2. Using #ifdef/#endif and tst_resm C function instead of echo command like:
      echo "${syscall}01 0 CONF : System doesn't support execution of the test"
   3  Target test cases are:
      - signalfd
      - modify_ldt
      - io_*
      - eventfd
      - inotify

Regards,
Masatake YAMATO


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Jin Bing Guo]

Hi YAMATO,

I complete agree with you to take over the two patches.
Since you ported these testcases from Crackerjack, it's better you improve the cases in a large scale. I just tested some of them and returned my feedback.

Best regards!

Jin Bing Guo 郭晋兵

Linux for System p Test
IBM China Systems & Technology Laboratory in Beijing
Tel: [phone]
Email: guojb@...
-------------------------------------
"Do today what others won't so tomorrow you do what other's can't"



Masatake YAMATO ---09/29/2008 10:36:25 AM---Hi,

Masatake YAMATO <yamato@...>

09/29/2008 10:35 AM

To	Jin Bing Guo/China/IBM@IBMCN
cc	ltp-list@...
Subject	Re: [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64

e
Hi,

> On ppc64, the modify_ldt cases would not been compiled. So it should be
> return
> the message:"System doesn't support execution of the test" instead of an
> error message.


Using tst_resm C function is better than using echo command.

See the comment by Vijay Kumar.
http://sourceforge.net/mailarchive/message.php?msg_name=48C67E2C.7030905%40bravegnu.org

I'm also working this area, If you are O.K., I'd like to take over your patches:

  [LTP] [PATCH 1/3] Fix the make install error in io_* testcases
  [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64

My intents are:

  1. Using check_header in cond.mk
  2. Using #ifdef/#endif and tst_resm C function instead of echo command like:
     echo "${syscall}01 0 CONF : System doesn't support execution of the test"
  3  Target test cases are:
     - signalfd
     - modify_ldt
     - io_*
     - eventfd
     - inotify

Regards,
Masatake YAMATO






-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Jin Bing Guo]

Hi YAMATO,

I complete agree with you to take over the two patches.
Since you ported these testcases from Crackerjack, it's better you improve the cases in a large scale. I just tested some of them and returned my feedback.

Best regards!

Jin Bing Guo 郭晋兵

Linux for System p Test
IBM China Systems & Technology Laboratory in Beijing
Tel: [phone]
Email: guojb@...
-------------------------------------
"Do today what others won't so tomorrow you do what other's can't"



Masatake YAMATO ---09/29/2008 10:36:25 AM---Hi,

Masatake YAMATO <yamato@...>

09/29/2008 10:35 AM

To	Jin Bing Guo/China/IBM@IBMCN
cc	ltp-list@...
Subject	Re: [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64

e
Hi,

> On ppc64, the modify_ldt cases would not been compiled. So it should be
> return
> the message:"System doesn't support execution of the test" instead of an
> error message.


Using tst_resm C function is better than using echo command.

See the comment by Vijay Kumar.
http://sourceforge.net/mailarchive/message.php?msg_name=48C67E2C.7030905%40bravegnu.org

I'm also working this area, If you are O.K., I'd like to take over your patches:

  [LTP] [PATCH 1/3] Fix the make install error in io_* testcases
  [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64

My intents are:

  1. Using check_header in cond.mk
  2. Using #ifdef/#endif and tst_resm C function instead of echo command like:
     echo "${syscall}01 0 CONF : System doesn't support execution of the test"
  3  Target test cases are:
     - signalfd
     - modify_ldt
     - io_*
     - eventfd
     - inotify

Regards,
Masatake YAMATO






-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

Hi Jin,

On Sun, 2008-09-28 at 11:17 +0800, Jin Bing Guo wrote:

> On ppc64, the modify_ldt cases would not been compiled. So it should
> be return
> the message:"System doesn't support execution of the test" instead of
> an error message.
>
> #uname -a
> Linux ovislp1 2.6.18-92.el5 #1 SMP Tue Apr 29 13:21:29 EDT 2008 ppc64
> ppc64 ppc64 GNU/Linux
>
> To fix problem, I added the shell scripts to run the testcases.
> Added two files and two patches:
> testcases/kernel/syscalls/modify_ldt/run-modify_ldt01.sh
> testcases/kernel/syscalls/modify_ldt/run-modify_ldt01.sh

You should combine them into just 1 script instead of 2.

> duration=0 termination_type=exited termination_id=0 corefile=no
> cutime=0 cstime=0
> <<<test_end>>>
>
> In addition, the Fix_runtest_syscalls.patch also resolved the switch01
> running error.
> ------------------
> @@ -927,7 +927,7 @@ swapon02 swapon02
> swapon03 swapon03
>
> #Exclusive syscall() for POWER6 machines only
> -switch01 switch01
> +switch01 endian_switch01

Oops. I did not complete my earlier work. Thanks for fixing this.

Regards--
Subrata

>
> symlink01 symlink01
> symlink02 symlink02

Regards--
Subrata



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Jin Bing Guo]

Hi YAMATO,

I complete agree with you to take over the two patches.
Since you ported these testcases from Crackerjack, it's better you improve the cases in a large scale. I just tested some of them and returned my feedback.

Best regards!

Jin Bing Guo 郭晋兵

Linux for System p Test
IBM China Systems & Technology Laboratory in Beijing
Tel: [phone]
Email: guojb@...
-------------------------------------
"Do today what others won't so tomorrow you do what other's can't"


Masatake YAMATO <yamato@...>

Masatake YAMATO <yamato@...>

2008-09-29 10:35

To	Jin Bing Guo/China/IBM@IBMCN
cc	ltp-list@...
Subject	Re: [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64

Hi,

> On ppc64, the modify_ldt cases would not been compiled. So it should be
> return
> the message:"System doesn't support execution of the test" instead of an
> error message.


Using tst_resm C function is better than using echo command.

See the comment by Vijay Kumar.
http://sourceforge.net/mailarchive/message.php?msg_name=48C67E2C.7030905%40bravegnu.org

I'm also working this area, If you are O.K., I'd like to take over your patches:

  [LTP] [PATCH 1/3] Fix the make install error in io_* testcases
  [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64

My intents are:

  1. Using check_header in cond.mk
  2. Using #ifdef/#endif and tst_resm C function instead of echo command like:
     echo "${syscall}01 0 CONF : System doesn't support execution of the test"
  3  Target test cases are:
     - signalfd
     - modify_ldt
     - io_*
     - eventfd
     - inotify

Regards,
Masatake YAMATO






-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Masatake YAMATO-2]

Hi,

> I complete agree with you to take over the two patches.
> Since you ported these testcases  from Crackerjack, it's better you improve
> the cases in a large scale. I just tested some of them and returned my
> feedback.
>
> Best regards!

Thank you.

I've found I need much more time to improve as I wanted.
This is a short report. If someone know about this issue. Please, let me know.



When I run the test on x86_64, errno is not set even if
the callilng of the modify_ldt got failed.

    [yamato@beach modify_ldt]$  ./modify_ldt01
    modify_ldt01    0  INFO  :  Enter block 1
    modify_ldt01    1  FAIL  :  modify_ldt() set invalid errno, expected ENOSYS, got: 42
    modify_ldt01    0  INFO  :  block 1 FAILED

I'm guessing this is something to do with glibc.

Further more there is inconsistency between man page and kernel code.


man page says:

    ENOSYS func is neither 0 nor 1.

However, 2 and 0x11 may be acceptable.

/usr/share/srpmix/sources/k/kernel/2.6.18-8.el5/pre-build/kernel-2.6.18/linux-2.6.18.i386/arch/x86_64/kernel/ldt.c
    asmlinkage int sys_modify_ldt(int func, void __user *ptr, unsigned long bytecount)
    {
            int ret = -ENOSYS;

            switch (func) {
            case 0:
                    ret = read_ldt(ptr, bytecount);
                    break;
            case 1:
                    ret = write_ldt(ptr, bytecount, 1);
                    break;
            case 2:
                    ret = read_default_ldt(ptr, bytecount);
                    break;
            case 0x11:
                    ret = write_ldt(ptr, bytecount, 0);
                    break;
            }
            return ret;
    }

Before working on Makefile related thing, I have to fix ...somehwere glibc, man
page, and modify_ldt0[12].c.

Masatake YAMATO

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Masatake YAMATO-2]

Hi,


As I promised I've improved modify_ldt test cases.
Instead of using cond.mk, I've used autoconf.
Could you run modify_ldt test cases on ppc64?

I'll work on following test cases next:

       - io_*
       - eventfd
       - inotify

Masatake YAMATO

> Hi YAMATO,
>
> I complete agree with you to take over the two patches.
> Since you ported these testcases  from Crackerjack, it's better you improve
> the cases in a large scale. I just tested some of them and returned my
> feedback.
>
> Best regards!
>
> Jin Bing Guo  郭晋兵
>
> Linux for System p Test
> IBM China Systems & Technology Laboratory in Beijing
> Tel:   [phone]
> Email: guojb@...
> -------------------------------------
> "Do today what others won't so tomorrow you do what other's can't"
>
>
>
>
>                                                                            
>              Masatake YAMATO                                              
>              <yamato@...                                            
>              m>                                                         To
>                                        Jin Bing Guo/China/IBM@IBMCN        
>              09/29/2008 10:35                                           cc
>              AM                        ltp-list@...      
>                                                                    Subject
>                                        Re: [LTP] [PATCH 2/3] Fix the make  
>                                        install error in modify_ldt on      
>                                        ppc64                              
>                                                                            
>                                                                            
>                                                                            
>                                                                            
>                                                                            
>                                                                            
>
>
>
> e
> Hi,
>
> > On ppc64, the modify_ldt cases would not been compiled. So it should be
> > return
> > the message:"System doesn't support execution of the test" instead of an
> > error message.
>
>
> Using tst_resm C function is better than using echo command.
>
> See the comment by Vijay Kumar.
> http://sourceforge.net/mailarchive/message.php?msg_name=48C67E2C.7030905%40bravegnu.org
>
>
> I'm also working this area, If you are O.K., I'd like to take over your
> patches:
>
>    [LTP] [PATCH 1/3] Fix the make install error in io_* testcases
>    [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64
>
> My intents are:
>
>    1. Using check_header in cond.mk
>    2. Using #ifdef/#endif and tst_resm C function instead of echo command
> like:
>       echo "${syscall}01 0 CONF : System doesn't support execution of the
> test"
>    3  Target test cases are:
>       - signalfd
>       - modify_ldt
>       - io_*
>       - eventfd
>       - inotify
>
> Regards,
> Masatake YAMATO
>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

On Tue, 2008-11-18 at 22:15 +0900, Masatake YAMATO wrote:
> Hi,
>
>
> As I promised I've improved modify_ldt test cases.
> Instead of using cond.mk, I've used autoconf.
> Could you run modify_ldt test cases on ppc64?

I will do that soon and let you know.

Regards--
Subrata

>
> I'll work on following test cases next:
>
>        - io_*
>        - eventfd
>        - inotify
>
> Masatake YAMATO
>
>
> > Hi YAMATO,
> >
> > I complete agree with you to take over the two patches.
> > Since you ported these testcases  from Crackerjack, it's better you improve
> > the cases in a large scale. I just tested some of them and returned my
> > feedback.
> >
> > Best regards!
> >
> > Jin Bing Guo  郭晋兵
> >
> > Linux for System p Test
> > IBM China Systems & Technology Laboratory in Beijing
> > Tel:   [phone]
> > Email: guojb@...
> > -------------------------------------
> > "Do today what others won't so tomorrow you do what other's can't"
> >
> >
> >
> >
> >                                                                            
> >              Masatake YAMATO                                              
> >              <yamato@...                                            
> >              m>                                                         To
> >                                        Jin Bing Guo/China/IBM@IBMCN        
> >              09/29/2008 10:35                                           cc
> >              AM                        ltp-list@...      
> >                                                                    Subject
> >                                        Re: [LTP] [PATCH 2/3] Fix the make  
> >                                        install error in modify_ldt on      
> >                                        ppc64                              
> >                                                                            
> >                                                                            
> >                                                                            
> >                                                                            
> >                                                                            
> >                                                                            
> >
> >
> >
> > e
> > Hi,
> >
> > > On ppc64, the modify_ldt cases would not been compiled. So it should be
> > > return
> > > the message:"System doesn't support execution of the test" instead of an
> > > error message.
> >
> >
> > Using tst_resm C function is better than using echo command.
> >
> > See the comment by Vijay Kumar.
> > http://sourceforge.net/mailarchive/message.php?msg_name=48C67E2C.7030905%40bravegnu.org
> >
> >
> > I'm also working this area, If you are O.K., I'd like to take over your
> > patches:
> >
> >    [LTP] [PATCH 1/3] Fix the make install error in io_* testcases
> >    [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64
> >
> > My intents are:
> >
> >    1. Using check_header in cond.mk
> >    2. Using #ifdef/#endif and tst_resm C function instead of echo command
> > like:
> >       echo "${syscall}01 0 CONF : System doesn't support execution of the
> > test"
> >    3  Target test cases are:
> >       - signalfd
> >       - modify_ldt
> >       - io_*
> >       - eventfd
> >       - inotify
> >
> > Regards,
> > Masatake YAMATO
> >
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@...
> https://lists.sourceforge.net/lists/listinfo/ltp-list

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

Hi Yamato,

On Wed, 2008-11-19 at 15:51 +0530, Subrata Modak wrote:
> On Tue, 2008-11-18 at 22:15 +0900, Masatake YAMATO wrote:
> > Hi,
> >
> >
> > As I promised I've improved modify_ldt test cases.
> > Instead of using cond.mk, I've used autoconf.
> > Could you run modify_ldt test cases on ppc64?

And here it goes:

1) uname -a
Linux 2.6.27.5-2-ppc64 #1 SMP 2008-11-11 15:15:33 +0100 ppc64 ppc64
ppc64 GNU/Linux
# ./testcases/kernel/syscalls/modify_ldt/modify_ldt01
modify_ldt01    0  INFO  :  modify_ldt01 test only for ix86
# ./testcases/kernel/syscalls/modify_ldt/modify_ldt02
modify_ldt02    0  INFO  :  modify_ldt02 test only for ix86

2) uname -a
Linux 2.6.27.5-2-default #1 SMP 2008-11-11 15:15:33 +0100 x86_64 x86_64
x86_64 GNU/Linux
# ./testcases/kernel/syscalls/modify_ldt/modify_ldt01
modify_ldt01    1  CONF  :  modify_ldt is available but not tested on
the platform than __i386__
# ./testcases/kernel/syscalls/modify_ldt/modify_ldt02
modify_ldt02    1  CONF  :  modify_ldt is available but not tested on
the platform than __i386__

3) uname -a
Linux 2.6.23.13 #1 SMP Wed Jan 9 18:14:28 PST 2008 ia64 GNU/Linux
# ./testcases/kernel/syscalls/modify_ldt/modify_ldt01
modify_ldt01    0  INFO  :  modify_ldt01 test only for ix86
# ./testcases/kernel/syscalls/modify_ldt/modify_ldt02
modify_ldt02    0  INFO  :  modify_ldt02 test only for ix86

Regards--
Subrata

>
> I will do that soon and let you know.
>
> Regards--
> Subrata
>
> >
> > I'll work on following test cases next:
> >
> >        - io_*
> >        - eventfd
> >        - inotify
> >
> > Masatake YAMATO
> >
> >
> > > Hi YAMATO,
> > >
> > > I complete agree with you to take over the two patches.
> > > Since you ported these testcases  from Crackerjack, it's better you improve
> > > the cases in a large scale. I just tested some of them and returned my
> > > feedback.
> > >
> > > Best regards!
> > >
> > > Jin Bing Guo  郭晋兵
> > >
> > > Linux for System p Test
> > > IBM China Systems & Technology Laboratory in Beijing
> > > Tel:   [phone]
> > > Email: guojb@...
> > > -------------------------------------
> > > "Do today what others won't so tomorrow you do what other's can't"
> > >
> > >
> > >
> > >
> > >                                                                            
> > >              Masatake YAMATO                                              
> > >              <yamato@...                                            
> > >              m>                                                         To
> > >                                        Jin Bing Guo/China/IBM@IBMCN        
> > >              09/29/2008 10:35                                           cc
> > >              AM                        ltp-list@...      
> > >                                                                    Subject
> > >                                        Re: [LTP] [PATCH 2/3] Fix the make  
> > >                                        install error in modify_ldt on      
> > >                                        ppc64                              
> > >                                                                            
> > >                                                                            
> > >                                                                            
> > >                                                                            
> > >                                                                            
> > >                                                                            
> > >
> > >
> > >
> > > e
> > > Hi,
> > >
> > > > On ppc64, the modify_ldt cases would not been compiled. So it should be
> > > > return
> > > > the message:"System doesn't support execution of the test" instead of an
> > > > error message.
> > >
> > >
> > > Using tst_resm C function is better than using echo command.
> > >
> > > See the comment by Vijay Kumar.
> > > http://sourceforge.net/mailarchive/message.php?msg_name=48C67E2C.7030905%40bravegnu.org
> > >
> > >
> > > I'm also working this area, If you are O.K., I'd like to take over your
> > > patches:
> > >
> > >    [LTP] [PATCH 1/3] Fix the make install error in io_* testcases
> > >    [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64
> > >
> > > My intents are:
> > >
> > >    1. Using check_header in cond.mk
> > >    2. Using #ifdef/#endif and tst_resm C function instead of echo command
> > > like:
> > >       echo "${syscall}01 0 CONF : System doesn't support execution of the
> > > test"
> > >    3  Target test cases are:
> > >       - signalfd
> > >       - modify_ldt
> > >       - io_*
> > >       - eventfd
> > >       - inotify
> > >
> > > Regards,
> > > Masatake YAMATO
> > >
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp-list@...
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@...
> https://lists.sourceforge.net/lists/listinfo/ltp-list

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Masatake YAMATO-2]

> On Wed, 2008-11-19 at 15:51 +0530, Subrata Modak wrote:
> > On Tue, 2008-11-18 at 22:15 +0900, Masatake YAMATO wrote:
> > > Hi,
> > >
> > >
> > > As I promised I've improved modify_ldt test cases.
> > > Instead of using cond.mk, I've used autoconf.
> > > Could you run modify_ldt test cases on ppc64?
>
> And here it goes:
>
> 1) uname -a
> Linux 2.6.27.5-2-ppc64 #1 SMP 2008-11-11 15:15:33 +0100 ppc64 ppc64
> ppc64 GNU/Linux
> # ./testcases/kernel/syscalls/modify_ldt/modify_ldt01
> modify_ldt01    0  INFO  :  modify_ldt01 test only for ix86
> # ./testcases/kernel/syscalls/modify_ldt/modify_ldt02
> modify_ldt02    0  INFO  :  modify_ldt02 test only for ix86
>
> 2) uname -a
> Linux 2.6.27.5-2-default #1 SMP 2008-11-11 15:15:33 +0100 x86_64 x86_64
> x86_64 GNU/Linux
> # ./testcases/kernel/syscalls/modify_ldt/modify_ldt01
> modify_ldt01    1  CONF  :  modify_ldt is available but not tested on
> the platform than __i386__
> # ./testcases/kernel/syscalls/modify_ldt/modify_ldt02
> modify_ldt02    1  CONF  :  modify_ldt is available but not tested on
> the platform than __i386__
>
> 3) uname -a
> Linux 2.6.23.13 #1 SMP Wed Jan 9 18:14:28 PST 2008 ia64 GNU/Linux
> # ./testcases/kernel/syscalls/modify_ldt/modify_ldt01
> modify_ldt01    0  INFO  :  modify_ldt01 test only for ix86
> # ./testcases/kernel/syscalls/modify_ldt/modify_ldt02
> modify_ldt02    0  INFO  :  modify_ldt02 test only for ix86

Fine. Thank you.

BTW, when a system call is not available on a
platform, a test case for the system call should report it. In
such case which should the test case use INFO or CONF?
Any guide line?

Masatake YAMATO

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list