[PATCH] S/PDIF rewrite

View: New views
7 Messages — Rating Filter:   Alert me  

[PATCH] S/PDIF rewrite

by Nicolas Boullis :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

Willing to kick decompiled code out of the em8300 driver, I just tried
to rewrite the S/PDIF code.

The new code is much smaller and hopefully much more readable, but there
should be no behavioural difference.

Please give it a try if you have hardware to decode S/PDIF digital
audio. All comments are welcome.


Cheers,

Nicolas


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

em8300_spdif_rewrite.patch.gz (2K) Download Attachment

Re: [PATCH] S/PDIF rewrite

by Bugzilla from ville.skytta@iki.fi :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wednesday 12 December 2007, Nicolas Boullis wrote:

> Hi,
>
> Willing to kick decompiled code out of the em8300 driver, I just tried
> to rewrite the S/PDIF code.
>
> The new code is much smaller and hopefully much more readable, but there
> should be no behavioural difference.
>
> Please give it a try if you have hardware to decode S/PDIF digital
> audio. All comments are welcome.

Tested, didn't notice any difference.  Digital PCM still works, ditto
switching between it and analog.  I don't think I have anything available to
test AC3 with right now.

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

Re: [PATCH] S/PDIF rewrite

by Nicolas Boullis :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

On Wed, Dec 12, 2007 at 08:44:01PM +0200, Ville Skyttä wrote:
>
> Tested, didn't notice any difference.  Digital PCM still works, ditto
> switching between it and analog.  I don't think I have anything available to
> test AC3 with right now.

Same question here, does anyone else want to give it a try before I
commit the change?
Ville, have you been able to test AC3?


Cheers,

Nicolas

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

Re: [PATCH] S/PDIF rewrite

by Bugzilla from ville.skytta@iki.fi :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Sunday 16 December 2007, Nicolas Boullis wrote:

> Ville, have you been able to test AC3?

Thanks for the reminder.  Yes, I just tried it, and it appears to work fine.

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

Re: [PATCH] S/PDIF rewrite

by Nicolas Boullis :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Sun, Dec 16, 2007 at 10:54:16PM +0200, Ville Skyttä wrote:
>
> Thanks for the reminder.  Yes, I just tried it, and it appears to work fine.

OK, thanks.


Nicolas

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

Re: [PATCH] S/PDIF rewrite

by Sebastian Frei-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Am Sonntag, 16. Dezember 2007 17:26:35 schrieb Nicolas Boullis:

> Hi,
>
> On Wed, Dec 12, 2007 at 08:44:01PM +0200, Ville Skyttä wrote:
> > Tested, didn't notice any difference.  Digital PCM still works, ditto
> > switching between it and analog.  I don't think I have anything available
> > to test AC3 with right now.
>
> Same question here, does anyone else want to give it a try before I
> commit the change?
> Ville, have you been able to test AC3?
>
>
> Cheers,
>
> Nicolas
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by:
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services
> for just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplac
>e _______________________________________________
> Dxr3-devel mailing list
> Dxr3-devel@...
> https://lists.sourceforge.net/lists/listinfo/dxr3-devel

I have no equipment to test the digital output, but the analog output still
works with the patch.

S.

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

Re: [PATCH] S/PDIF rewrite

by Nicolas Boullis :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

On Tue, Dec 11, 2007 at 11:41:10PM +0100, Nicolas Boullis wrote:

> Hi,
>
> Willing to kick decompiled code out of the em8300 driver, I just tried
> to rewrite the S/PDIF code.
>
> The new code is much smaller and hopefully much more readable, but there
> should be no behavioural difference.
>
> Please give it a try if you have hardware to decode S/PDIF digital
> audio. All comments are welcome.

Applied since it seems to work as fine as the old code, and that old
code was obviously decompiled and possibly illegal.
Thanks to Ville and Sebastian who gave that patch a try.


Nicolas


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel