[PATCH] Fix compile for 2.6.25 ( >= rc-3) kernels

View: New views
2 Messages — Rating Filter:   Alert me  

[PATCH] Fix compile for 2.6.25 ( >= rc-3) kernels

by Christian Gmeiner-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi all,
with this patch it is possible to use em8300 drivers again. Some
defines got removed from
kernel - http://www.linuxhq.com/kernel/v2.6/25-rc3/include/linux/i2c-id.h

greets,
Christian


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

fix_compile_for_2.6.25_kernel.patch (546 bytes) Download Attachment

Re: [PATCH] Fix compile for 2.6.25 ( >= rc-3) kernels

by Nicolas Boullis :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

On Tue, Mar 18, 2008 at 03:16:19PM +0100, Christian Gmeiner wrote:
> Hi all,
> with this patch it is possible to use em8300 drivers again. Some
> defines got removed from
> kernel - http://www.linuxhq.com/kernel/v2.6/25-rc3/include/linux/i2c-id.h

Thanks Christian for pointing this.
2 comments anyway:
  - I'd rather avoid testing LINUX_VERSION_CODE when it's easy, as it is
    sometimes unaccurate (think about distros that backport some
    changes); here, testing if I2C_DRIVERID_EEPROM looks like a good
    solution to me.
  - If you know and use mercurial, it would be nice if you could send an
    export of your own changeset that I can import as is; that way you
    are rightfully recorded as the author of the change, and you can
    write your own commit message.


Cheersn

Nicolas

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel
LightInTheBox - Buy quality products at wholesale price