[PATCH] Check result value of 'copy_from_user'

[Christian Gmeiner-4]

This patch fixes:

  CC [M]  /root/em8300/modules/em8300_fifo.o
/root/em8300/modules/em8300_fifo.c: In function 'em8300_fifo_write_nolock':
/root/em8300/modules/em8300_fifo.c:206: warning: ignoring return value
of 'copy_from_user', declared with attribute warn_unused_result

greets,
Christian Gmeiner


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Nicolas Boullis]

Hi Christian,

On Tue, Dec 04, 2007 at 12:57:39AM +0100, Christian Gmeiner wrote:
> This patch fixes:
>
>   CC [M]  /root/em8300/modules/em8300_fifo.o
> /root/em8300/modules/em8300_fifo.c: In function 'em8300_fifo_write_nolock':
> /root/em8300/modules/em8300_fifo.c:206: warning: ignoring return value
> of 'copy_from_user', declared with attribute warn_unused_result

If you want to check the return value of copy_from_user here, I think
you should also check the return values of all the get_user calls in
em8300_audio.c.


Cheers,

Nicolas

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Christian Gmeiner-4]

2007/12/4, Nicolas Boullis <nboullis@...>:

> Hi Christian,
>
> On Tue, Dec 04, 2007 at 12:57:39AM +0100, Christian Gmeiner wrote:
> > This patch fixes:
> >
> >   CC [M]  /root/em8300/modules/em8300_fifo.o
> > /root/em8300/modules/em8300_fifo.c: In function 'em8300_fifo_write_nolock':
> > /root/em8300/modules/em8300_fifo.c:206: warning: ignoring return value
> > of 'copy_from_user', declared with attribute warn_unused_result
>
> If you want to check the return value of copy_from_user here, I think
> you should also check the return values of all the get_user calls in
> em8300_audio.c.

HI Nicolas,

em8300_audio.c fixes will follow as i need more time to fix this. But
I think this patch is correct and ready to commit

Greets,
Christian

> Cheers,
>
> Nicolas
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> Dxr3-devel mailing list
> Dxr3-devel@...
> https://lists.sourceforge.net/lists/listinfo/dxr3-devel
>

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel