[PATCH] Brightness/Contrast/Saturation rewrite

[Nicolas Boullis]

Hi,

Willing to kick decompiled code out of the em8300 driver, I just tried
to rewrite the brightness/contrast/saturation code.

The new code is much smaller and hopefully much more readable, but it
certainly does not behave exactly like the old one.

Please give it a try and compare the behaviour of the old and the new
code. All comments are welcome.


Cheers,

Nicolas


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Ville Skyttä]

On Tuesday 11 December 2007, Nicolas Boullis wrote:

> Hi,
>
> Willing to kick decompiled code out of the em8300 driver, I just tried
> to rewrite the brightness/contrast/saturation code.
>
> The new code is much smaller and hopefully much more readable, but it
> certainly does not behave exactly like the old one.
>
> Please give it a try and compare the behaviour of the old and the new
> code. All comments are welcome.

Tested, didn't notice any difference, still works for me from VDR plugin
settings as it used to.

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Nicolas Boullis]

Hi,

On Wed, Dec 12, 2007 at 08:42:19PM +0200, Ville Skyttä wrote:
>
> Tested, didn't notice any difference, still works for me from VDR plugin
> settings as it used to.

Thanks. Does anyone else want to give it a try before I commit the
change?


Cheers,

Nicolas

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Christian Gmeiner-4]

2007/12/16, Nicolas Boullis <nboullis@...>:
> Hi,
>
> On Wed, Dec 12, 2007 at 08:42:19PM +0200, Ville Skyttä wrote:
> >
> > Tested, didn't notice any difference, still works for me from VDR plugin
> > settings as it used to.
>
> Thanks. Does anyone else want to give it a try before I commit the
> change?

yes me... no visual changes -> feel free to commit

greets,
Christian
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Sebastian Frei-2]

Am Montag, 10. Dezember 2007 23:44:43 schrieb Nicolas Boullis:

> Hi,
>
> Willing to kick decompiled code out of the em8300 driver, I just tried
> to rewrite the brightness/contrast/saturation code.
>
> The new code is much smaller and hopefully much more readable, but it
> certainly does not behave exactly like the old one.
>
> Please give it a try and compare the behaviour of the old and the new
> code. All comments are welcome.
>
>
> Cheers,
>
> Nicolas

I applied the patch and I can't see any differences with VDR.

S.

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Nicolas Boullis]

Hi,

On Mon, Dec 10, 2007 at 11:44:43PM +0100, Nicolas Boullis wrote:

> Hi,
>
> Willing to kick decompiled code out of the em8300 driver, I just tried
> to rewrite the brightness/contrast/saturation code.
>
> The new code is much smaller and hopefully much more readable, but it
> certainly does not behave exactly like the old one.
>
> Please give it a try and compare the behaviour of the old and the new
> code. All comments are welcome.

Applied since it seems to work as fine as the old code, and that old
code was obviously decompiled and possibly illegal.
Thanks to Ville, Christian and Sebastian who gave that patch a try.


Nicolas

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel