[PATCH: run_semaphore_test_01.sh]

[Elder Costa]

The following patch is for script
testcases/kernel/ipc/ipc_stress/run_semaphore_test_01.sh

It fixes a test error (line 72) and a bash specific test extension
(lines 72 and 102) that fail to run under Ubuntu (and probably Debian)
as /bin/sh points to dash instead of bash (as in Redhat/Fedora).

This script would also benefit of a reformatting as it lacks indentation
but I wanted to keep the patch simple and I am not familiar with script
format style of LTP.

Regards.

Elder.

--- run_semaphore_test_01.sh.ORIG 2008-09-24 09:39:21.000000000 -0300
+++ run_semaphore_test_01.sh 2008-09-24 09:39:21.000000000 -0300
@@ -72,7 +72,7 @@
 #               - non zero on failure. return value from commands ($RC)
 cleanup()
 {
-    if [[ -nz $SEM_IPCS ]];then
+    if [ -n "$SEM_IPCS" ];then
         ipcrm -s $SEM_IPCS                  # remove the semaphore.
     fi
     tst_resm TINFO "CLOSE: exit."
@@ -102,7 +102,7 @@
 SEMS=`ipcs -s | awk '{printf " %d", $2}' | sed -e 's/ 0//g'`
 for SEM_IPCS in $SEMS
 do
-    if [[ $SEM_IPCS -eq $SEM_ID ]];then
+    if [ $SEM_IPCS -eq $SEM_ID ] ;then
         tst_resm TPASS "semaphore ID comparing passed."
         return $RC
     fi

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

Thanks for the Patch. Just 2 cents:

1) Create your Patch with an Unified diff above LTP-ROOT directory like:

diff -uprN ltp-<original> <ltp-modified>

2) Sign off your patches with the following in your mail body:

Signed-Off-By: Elder Costa <evcosta@...>

Rest are fine. Patch is checked in.

Regards--
Subrata

On Wed, 2008-09-24 at 10:01 -0300, Elder Costa wrote:

> The following patch is for script
> testcases/kernel/ipc/ipc_stress/run_semaphore_test_01.sh
>
> It fixes a test error (line 72) and a bash specific test extension
> (lines 72 and 102) that fail to run under Ubuntu (and probably Debian)
> as /bin/sh points to dash instead of bash (as in Redhat/Fedora).
>
> This script would also benefit of a reformatting as it lacks indentation
> but I wanted to keep the patch simple and I am not familiar with script
> format style of LTP.
>
> Regards.
>
> Elder.
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list