[JIRA] Created: (CAY-892) CM Usability: JEdit Syntax to all TextAreas

[Cayenne - Dev mailing list]

CM Usability: JEdit Syntax to all TextAreas
-------------------------------------------

                 Key: CAY-892
                 URL: https://issues.apache.org/cayenne/browse/CAY-892
             Project: Cayenne
          Issue Type: New Feature
          Components: CayenneModeler GUI
            Reporter: Thomas Bernhard
            Assignee: Andrus Adamchik


Please add JEdit Syntax:
http://sourceforge.net/projects/jedit-syntax
to all TextAreas that display code (SQL, or other syntaxed text).

This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).

The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).

Please not that the library is under MIT license so it should be no compatibility problem.

After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

    [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12561 ]

Kevin Menard commented on CAY-892:
----------------------------------

Looks like the library isn't in any of the official maven repositories.  A few people have hosted it privately, but my guess is we're better off putting it with the others hosted on ObjectStyle.

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Andrus Adamchik
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

    [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12566 ]

Thomas Bernhard commented on CAY-892:
-------------------------------------

> Looks like the library isn't in any of the official maven repositories. A few people have hosted it privately
AstroGrid is hosting it (an open source astronomy project):
http://www.astrogrid.org/maven/jedit/

> my guess is we're better off putting it with the others hosted on ObjectStyle.
+1 for this too, but I think at leat now to implement the feature, using the library from the above url is OK too  (I think the feature is too cool to wait until a the maven repository on objectstyle is updated :) )

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Andrus Adamchik
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

     [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Menard reassigned CAY-892:
--------------------------------

    Assignee: Kevin Menard  (was: Andrus Adamchik)

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

    [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884#action_12884 ]

Andrus Adamchik commented on CAY-892:
-------------------------------------

For the record, as we discussed with Andrey offline some time ago, jedit-syntax lib is a dead project... I'd rather we avoid inclusion of unsupported code in CM (unless it is transparent enough for us to support it ourselves)

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

    [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935#action_12935 ]

Gustav Weber commented on CAY-892:
----------------------------------

> For the record, as we discussed with Andrey offline some time ago, jedit-syntax lib is a dead project... I'd rather
>  we avoid inclusion of unsupported code in CM
Sorry but how is jedit-syntax worse than the dead Platonos  project (than needs modifications to be able to use it as a CM plug-in framework)?

Including JEdit-syntax is very easy - is just one or two lines of code and can be replaced with the actual JTextArea at anytime.

The code of jedit-sytnax was not changed for years, but this is also true for most  "official" Swing components too - they just work.

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

    [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980#action_12980 ]

Andrey Razumovsky commented on CAY-892:
---------------------------------------

Please pay some more attention to this issue.

I've studied jEdit code, it contains just about 10 important classes and interfaces (and other 20 are just markers for different file formats). I can of course write everything from the clean sheet, but i doubt it will be working any better that well-used and well-tested jedit. And i'd vote that the code is "is transparent enough for us to support it ourselves" and I bet we'll never have to change it actually. Things like keyword style and color can of course be changed 'outside' of the library

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Andrus Adamchik]

If Andrey feels this way, I won't have any more objections. Any  
volunteers to build and package the code for Maven upload and  
submitting it to Ibiblio?

http://maven.apache.org/guides/mini/guide-central-repository-upload.html

If not I can do it myself. It may take a week or two for it to get  
uploaded.

Andrus


On Jun 24, 2008, at 9:02 AM, Andrey Razumovsky (JIRA) wrote:

> Andrey Razumovsky commented on CAY-892:
> ---------------------------------------
>
> Please pay some more attention to this issue.
>
> I've studied jEdit code, it contains just about 10 important classes  
> and interfaces (and other 20 are just markers for different file  
> formats). I can of course write everything from the clean sheet, but  
> i doubt it will be working any better that well-used and well-tested  
> jedit. And i'd vote that the code is "is transparent enough for us  
> to support it ourselves" and I bet we'll never have to change it  
> actually. Things like keyword style and color can of course be  
> changed 'outside' of the library

[Ahmed Mohombe]

> to build and package the code for Maven upload and submitting
> it to Ibiblio?
>
> http://maven.apache.org/guides/mini/guide-central-repository-upload.html
>
> If not I can do it myself. It may take a week or two for it to get
> uploaded.
Until it gets public in Ibiblio, one can use the Maven version from astrogrid.org mentioned
by Thomas:
http://www.astrogrid.org/maven/jedit/jedit-syntax/1.0/


Ahmed.

[Andrus Adamchik]

Just don't commit that repo to the top Cayenne pom (i.e. if somebody  
wants to use it, use it locally). Also jedit-syntax version there is  
1.0, while SF has 2.2. Whether that's just sloppiness of the  
maintainers of the repo, or indeed a different version I have no idea...

Andrus


On Jun 24, 2008, at 1:37 PM, Ahmed Mohombe wrote:

>> to build and package the code for Maven upload and submitting it to  
>> Ibiblio?
>> http://maven.apache.org/guides/mini/guide-central-repository-upload.html
>> If not I can do it myself. It may take a week or two for it to get  
>> uploaded.
> Until it gets public in Ibiblio, one can use the Maven version from  
> astrogrid.org mentioned
> by Thomas:
> http://www.astrogrid.org/maven/jedit/jedit-syntax/1.0/
>
>
> Ahmed.
>
>

[Ahmed Mohombe]

> Also jedit-syntax version there is
> 1.0, while SF has 2.2. Whether that's just sloppiness of the maintainers
> of the repo, or indeed a different version I have no idea...
SF has 2.2.2 but that is "artificial" in the sense that it represents the JEdit version
it was taken from (to make it jedit-syntax), so there was never a 1.0 version.

Those from astrogrid.org use that "latest" version(from cvs) but it was the "first" version ever
built with Maven.
(AFAIK they simply had no patience/knowhow to figure out all Maven quirks, so they let the defaults)

Ahmed.

[Cayenne - Dev mailing list]

    [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994#action_12994 ]

Kevin Menard commented on CAY-892:
----------------------------------

If Andrey is comfortable with using jEdit, I'll defer to him on it.  I was 50/50 to begin with, but he's actually looked at the code . . .

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

    [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017#action_13017 ]

Andrey Razumovsky commented on CAY-892:
---------------------------------------

Any news about uploading the library?

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

    [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018#action_13018 ]

Andrus Adamchik commented on CAY-892:
-------------------------------------

Let me submit the files to the central repo. I'll be able to do it this Sunday, and from there it will take somewhere from a couple of days to a couple of weeks to get processed. In the meantime anybody who needs to test it will have to install the jars locally with mvn install:file.

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

    [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022#action_13022 ]

Andrus Adamchik commented on CAY-892:
-------------------------------------

I packged jedit-syntax into a maven friendly format and submitted the bundle to the central repo. You can watch the following Jira for the status:

http://jira.codehaus.org/browse/MAVENUPLOAD-2155

Also here is a POM I used (so that we all use the same group id / artifact id in the meantime):

<project>
        <modelVersion>4.0.0</modelVersion>
        <groupId>net.sf.jedit-syntax</groupId>
        <artifactId>jedit-syntax</artifactId>
        <packaging>jar</packaging>
        <name>Jedit Syntax</name>
        <version>2.2.2</version>
        <description>Syntax Highlighting JavaBean</description>
        <url>http://jedit-syntax.sourceforge.net/</url>
        <licenses>
                <license>
                        <name>MIT License</name>
                        <url>http://www.opensource.org/licenses/mit-license.php</url>
                </license>
        </licenses>
        <scm>
                <connection>
                        scm:cvs:pserver:anonymous@...:/cvsroot/jedit-syntax:jEdit-Syntax
                </connection>
                <url>http://jedit-syntax.cvs.sourceforge.net/jedit-syntax/jEdit-Syntax/</url>
        </scm>
        <build>
                <plugins>
                        <plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-compiler-plugin</artifactId>
                                <configuration>
                                        <source>1.4</source>
                                        <target>1.4</target>
                                </configuration>
                        </plugin>
                        <plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-javadoc-plugin</artifactId>
                                <configuration>
                                        <source>1.4</source>
                                        <target>1.4</target>
                                </configuration>
                        </plugin>
                </plugins>
        </build>
</project>

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Cayenne - Dev mailing list]

     [ https://issues.apache.org/cayenne/browse/CAY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Razumovsky updated CAY-892:
----------------------------------

    Attachment: patch-CAY-892.txt

Patch with replaced text pane with jedit's pane and added dependency to pom. My work here is minimal - I left all default jEdit behavior, colors etc. Also I left JEditArea default font - that seems to be CAY-1066 fix.

> CM Usability: JEdit Syntax to all TextAreas
> -------------------------------------------
>
>                 Key: CAY-892
>                 URL: https://issues.apache.org/cayenne/browse/CAY-892
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>         Attachments: patch-CAY-892.txt
>
>
> Please add JEdit Syntax:
> http://sourceforge.net/projects/jedit-syntax
> to all TextAreas that display code (SQL, or other syntaxed text).
> This library is very small, lightweight (it's not the entire JEdit but an old and simple syntax hightligher).
> The inclusion is very simple(just replace TextArea with JEditArea) but the effect is spectaculous:
> everytime I integrated this library the users were euphoric :) - despite the fact that my work was little (just a code line).
> Please not that the library is under MIT license so it should be no compatibility problem.
> After integrating this library it would make sense to take new screenshots for the documentation cause they'll look much better :).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.