[
http://jira.magnolia.info/browse/MGNLPUR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239#action_17239 ]
Gregory Joseph commented on MGNLPUR-17:
---------------------------------------
thanks.
A few remarks:
# the whole reading of the configuration nodes seems unnecessary, you should be able to get that out of the config bean, as a {{Map<String contextName, Config>}} for example.
# testcases to ensure the ctx configuration properly overrides the defaults would be welcome (and much easier to write if you didnt use nodes directly - as suggested in #1)
# sample bootstrap files would be nice too - note that if using Content2Bean (indirectly, as suggested in #1), javadoc would be sufficient - at some point, we're hoping to be able to generate configuration documentation out of java code/doc.
> defaultBaseUrl used in the email.html template should get it's value from the request URI
> -----------------------------------------------------------------------------------------
>
> Key: MGNLPUR-17
> URL:
http://jira.magnolia.info/browse/MGNLPUR-17> Project: Magnolia Public User Registration
> Issue Type: Improvement
> Reporter: Will Scheidegger
> Assignee: Gregory Joseph
> Priority: Minor
> Attachments: config.modules.public-user-registration.config.contexts.xml, emailWithContext.html, MailInContext.java, RegisterInContext.java, RegisterInContext.java, user-registration-in-context.html
>
>
> The registration confirmation mails sent out use "defaultBaseUrl" to setup the link which lets the user confirm his/her registration. This value is taken form config:/server/defaultBaseUrl which makes it impossible to use PUR on more than one domain in an instance. It would be preferable if the base url + context path would be derived from the request URI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/----------------------------------------------------------------
