[Fwd: [rt.cpan.org #36305] Overridden get_basic_credentials broken w/ NTLM Authentication]

View: New views
2 Messages — Rating Filter:   Alert me  

[Fwd: [rt.cpan.org #36305] Overridden get_basic_credentials broken w/ NTLM Authentication]

by Geoffrey Young :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



-------- Original Message --------
Subject: [rt.cpan.org #36305] Overridden get_basic_credentials broken w/
NTLM Authentication
Date: Fri, 30 May 2008 13:43:17 -0400
From: RFRANKEL via RT <bug-Apache-Test@...>
Reply-To: bug-Apache-Test@...
To: undisclosed-recipients:;
References: <RT-Ticket-36305@...>


Fri May 30 13:43:16 2008: Request 36305 was acted upon.
Transaction: Ticket created by RFRANKEL
        Queue: Apache-Test
      Subject: Overridden get_basic_credentials broken w/ NTLM
Authentication
    Broken in: 1.29, 1.30
     Severity: Important
        Owner: Nobody
   Requestors: RFRANKEL@...
       Status: new
  Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=36305 >


Apache::TestRequest::get_basic_credentials dies when accessing a realm
using mod_ntlm for authentication. The reason is that $realm is undefined.

Patch to fix below:

--- TestRequest.pm~     2007-11-14 01:44:36.000000000 -0500
+++ TestRequest.pm      2008-05-30 11:35:57.681722000 -0400
@@ -260,7 +260,7 @@
      my($self, $realm, $uri, $proxy) = @_;

      for ($realm, '__ALL__') {
-        next unless $credentials{$_};
+        next unless $_ && $credentials{$_};
          return @{ $credentials{$_} };
      }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: [Fwd: [rt.cpan.org #36305] Overridden get_basic_credentials broken w/ NTLM Authentication]

by Fred Moyer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Reviewed, tested, and committed.

r661903

Geoffrey Young wrote:

>
>
> -------- Original Message --------
> Subject: [rt.cpan.org #36305] Overridden get_basic_credentials broken w/
> NTLM Authentication
> Date: Fri, 30 May 2008 13:43:17 -0400
> From: RFRANKEL via RT <bug-Apache-Test@...>
> Reply-To: bug-Apache-Test@...
> To: undisclosed-recipients:;
> References: <RT-Ticket-36305@...>
>
>
> Fri May 30 13:43:16 2008: Request 36305 was acted upon.
> Transaction: Ticket created by RFRANKEL
>        Queue: Apache-Test
>      Subject: Overridden get_basic_credentials broken w/ NTLM
> Authentication
>    Broken in: 1.29, 1.30
>     Severity: Important
>        Owner: Nobody
>   Requestors: RFRANKEL@...
>       Status: new
>  Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=36305 >
>
>
> Apache::TestRequest::get_basic_credentials dies when accessing a realm
> using mod_ntlm for authentication. The reason is that $realm is undefined.
>
> Patch to fix below:
>
> --- TestRequest.pm~     2007-11-14 01:44:36.000000000 -0500
> +++ TestRequest.pm      2008-05-30 11:35:57.681722000 -0400
> @@ -260,7 +260,7 @@
>      my($self, $realm, $uri, $proxy) = @_;
>
>      for ($realm, '__ALL__') {
> -        next unless $credentials{$_};
> +        next unless $_ && $credentials{$_};
>          return @{ $credentials{$_} };
>      }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

LightInTheBox - Buy quality products at wholesale price!