[Fwd: [Firebird-checkins] CVS: OdbcJdbc/IscDbc IscStatement.cpp, 1.18.2.15, 1.18.2.16]

[Jorge Andrés Brugger]

I think this change is the origin of
http://tracker.firebirdsql.org/browse/ODBC-32

(it´s the only change between builds 142 and 143, build 142 works fine,
144-145 doesn't)

-------- Mensaje original --------
Asunto: [Firebird-checkins] CVS: OdbcJdbc/IscDbc IscStatement.cpp,
1.18.2.15, 1.18.2.16
Fecha: Sun, 26 Aug 2007 10:21:09 -0700
De: Vladimir Tsvigun <praktik@...>
A: firebird-checkins@...



Update of /cvsroot/firebird/OdbcJdbc/IscDbc
In directory sc8-pr-cvs17:/tmp/cvs-serv19934

Modified Files:
      Tag: v2-0-beta
        IscStatement.cpp
Log Message:
- fixed bug, URL: http://tracker.firebirdsql.org/browse/ODBC-29,
 "status_exception thrown and caught on every access due to trying
  to close already closed cursor", branch v2-0-beta

Index: IscStatement.cpp
===================================================================
RCS file: /cvsroot/firebird/OdbcJdbc/IscDbc/IscStatement.cpp,v
retrieving revision 1.18.2.15
retrieving revision 1.18.2.16
diff -b -U3 -r1.18.2.15 -r1.18.2.16
--- IscStatement.cpp 22 Mar 2007 17:44:27 -0000 1.18.2.15
+++ IscStatement.cpp 26 Aug 2007 17:21:05 -0000 1.18.2.16
@@ -559,8 +559,6 @@
  resultSets.deleteItem (resultSet);
  if (resultSets.isEmpty())
  {
- openCursor = false;
- typeStmt = stmtNone;
  if ( connection )
  {
  if ( transactionLocal )
@@ -570,14 +568,21 @@
  }
  else if ( connection->transactionInfo.autoCommit )
  connection->commitAuto();
+
+ if ( isActiveCursor() )
+ {
  // Close cursors too.
  ISC_STATUS statusVector[20];
  connection->GDS->_dsql_free_statement( statusVector, &statementHandle, DSQL_close );
  // Cursor already closed or not assigned
- if ( statusVector[1] && statusVector[1] != 335544569 )
+ if ( statusVector[1] && statusVector[1] != 335544569)
  THROW_ISC_EXCEPTION (connection, statusVector);
  }
  }
+
+ openCursor = false;
+ typeStmt = stmtNone;
+ }
 }
 
 void IscStatement::prepareStatement(const char * sqlString)


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Firebird-checkins mailing list
Firebird-checkins@...
https://lists.sourceforge.net/lists/listinfo/firebird-checkins




--
Jorge Andrés Brugger
Informática
DASU - Obra Social del Personal de la Universidad Nacional de la Patagonia
Comodoro Rivadavia, Chubut, Argentina
Teléfono [phone] int. 103
Correo electrónico: jbrugger@...
Website: www.dasu.com.ar



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Firebird-odbc-devel mailing list
Firebird-odbc-devel@...
https://lists.sourceforge.net/lists/listinfo/firebird-odbc-devel