[Cooker] Re: [cooker-commits] [drakx-commit] r243632 - drakx/trunk/perl-install/install

[Olivier Blin-2]

tv <svn-commit@...> writes:

> Author: tv
> Date: Thu Jul 24 19:56:11 2008
> New Revision: 243632
>
> Modified:
>    drakx/trunk/perl-install/install/install2.pm
>
> Log:
> set META_CLASS as 'download' so that we got 'Ia Ora Smooth' theme

This has quite some chance to trigger unwanted behavior in rpm
scriptlets, which might use $META_CLASS.
Better set this variable locally for the matchbox process only

> Modified: drakx/trunk/perl-install/install/install2.pm
> ==============================================================================
> --- drakx/trunk/perl-install/install/install2.pm (original)
> +++ drakx/trunk/perl-install/install/install2.pm Thu Jul 24 19:56:11 2008
> @@ -545,7 +545,7 @@
>      }
>  
>      log::l("META_CLASS=$o->{meta_class}");
> -    $ENV{META_CLASS} = $o->{meta_class}; #- for Ia Ora
> +    $ENV{META_CLASS} = 'download'; #- for Ia Ora Smooth
>  
>      foreach (@::auto_steps) {
>   if (my $s = $o->{steps}{/::(.*)/ ? $1 : $_}) {
>

--
Olivier Blin (blino) - Mandriva

[Frederic Crozat]

On Thu, Jul 24, 2008 at 10:07:15PM +0200, Olivier Blin wrote:

> tv <svn-commit@...> writes:
>
> > Author: tv
> > Date: Thu Jul 24 19:56:11 2008
> > New Revision: 243632
> >
> > Modified:
> >    drakx/trunk/perl-install/install/install2.pm
> >
> > Log:
> > set META_CLASS as 'download' so that we got 'Ia Ora Smooth' theme
>
> This has quite some chance to trigger unwanted behavior in rpm
> scriptlets, which might use $META_CLASS.
> Better set this variable locally for the matchbox process only

Problem is not matchbox but gtk itself.

We probably can override gtk default theme using /etc/gtk-2.0/gtkrc to
be always "Ia Ora Smooth" by adding :

gtk-theme-name = "Ia Ora Smooth" in it.

--
Frederic Crozat
Mandriva

[Thierry Vignaud]

Frederic Crozat <fcrozat@...> writes:

> > > Log:
> > > set META_CLASS as 'download' so that we got 'Ia Ora Smooth' theme
> >
> > This has quite some chance to trigger unwanted behavior in rpm
> > scriptlets, which might use $META_CLASS.
> > Better set this variable locally for the matchbox process only
>
> Problem is not matchbox but gtk itself.
>
> We probably can override gtk default theme using /etc/gtk-2.0/gtkrc to
> be always "Ia Ora Smooth" by adding :
>
> gtk-theme-name = "Ia Ora Smooth" in it.

Done