[Bug 593] New: HopObject.href() broken in 1.6.1

http://helma.org/bugs/show_bug.cgi?id=593

           Summary: HopObject.href() broken in 1.6.1
           Product: Helma
           Version: 1.6.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: critical
          Priority: P1
         Component: HopObject Functionality
        AssignedTo: helma-dev@...
        ReportedBy: rainer.rynesch@...


when you assign two _parent collections the right one is chosen in helma 1.6.0
but in helma 1.6.1 always the first one gets used

0. create a prototype
1. create 2 or 3 collections for this prototype (example root/type.properties):
  datafields=collection(datafield)
  evendatafields=collection(datafield)
  evendatafields.filter=id%2=0
  odddatafields=collection(datafield)
  odddatafields.filter=id%2=1
  #you a 'datafield' will either be in the even or in the odd collection
2. define parent mappings for your hopObject:
  _parent= root.evendatafields,root.odddatafields
3. write a list to your browser (you'l need to create at least 2 datafields -
either manually or using the createmanydatafields.hac from former bugs :):
  var ed=this.evendatafields.list();
  var od=this.odddatafields.list();
  res.contentType="text/plain";
  for(var i = 0; i < 100 && i < ed.length && i < od.length ; i++){
    res.debug("asdf");
    res.writeln("E: "+ed[i].href());
    res.writeln("O: "+od[i].href());
  }
4. output should be on helma 1.6.1 from
(http://adele.helma.org/download/helma/)
  E: /swarmkiller/evendatafields/2/
  O: /swarmkiller/evendatafields/1/
  E: /swarmkiller/evendatafields/4/
  O: /swarmkiller/evendatafields/3/
  E: /swarmkiller/evendatafields/6/
...
5. output should be on helma 1.6.0 from
(http://adele.helma.org/download/helma/)
  E: /swarmkiller/evendatafields/2/
  O: /swarmkiller/odddatafields/1/
  E: /swarmkiller/evendatafields/4/
  O: /swarmkiller/odddatafields/3/
  E: /swarmkiller/evendatafields/6/

of course the hopobjects with an odd id aren't in that collection which will
result in an error:
  Error in application swarmkiller
  Object not found.

so it seems to be an error in .href rather than in the ORM


--
Configure bugmail: http://helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://helma.org/bugs/show_bug.cgi?id=593


hannes@... changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #1 from hannes@...  2008-01-25 12:35 -------
Looks like I overshot the mark with the change suggested by Jürg Lehni.

http://helma.org/pipermail/helma-dev/2007-July/003709.html
http://helma.org/pipermail/helma-dev/2007-November/003866.html

What Jürg requested was that parents would be returned even if the containment
check fails. But I implemented that by just dropping the containment check,
when the proper solution would be to continue testing until we find a parent
that contains the child, and only return the non-containing parent as fallback.


--
Configure bugmail: http://helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://helma.org/bugs/show_bug.cgi?id=593


hannes@... changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from hannes@...  2008-01-28 14:57 -------
Thanks for the report. Bug is fixed in Subversion HEAD. If this is critical for
several users, we can push a 1.6.2 release. Please add your comments here.


--
Configure bugmail: http://helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://helma.org/bugs/show_bug.cgi?id=593


hannes@... changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.6.2




--
Configure bugmail: http://helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev