[Balloon] [Bug+Fix] in BalloonCanvas>>drawString: ...

[Jens Lincke]

Hi,

I found a bug in the BalloonCanvas when drawing a String with an offset
transformation

the method
drawString: s from: firstIndex to: lastIndex in: boundsRect font:
fontOrNil color: c
was marked TODO and did only draw when it can fall back to FormCanvas

But the offset in the Transformation was ignored, so I changed it into:

drawString: s from: firstIndex to: lastIndex in: boundsRect font:
fontOrNil color: c
   (self ifNoTransformWithIn: boundsRect)
       ifTrue:[ | offset |
       offset := transform a13 @ transform a23.

       ^super drawString: s from: firstIndex to: lastIndex in:
boundsRect + offset font: fontOrNil color: c]


and uploaded a iSqueak3.8 package Balloon-jl.4 to the
source.impara.de/Stuff

- Jens Lincke -

_______________________________________________
Balloon mailing list
Balloon@...
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon

[Andreas Raab]

Can you email me the patch?

Thanks,
   - Andreas

Jens Lincke wrote:

> Hi,
>
> I found a bug in the BalloonCanvas when drawing a String with an offset
> transformation
>
> the method
> drawString: s from: firstIndex to: lastIndex in: boundsRect font:
> fontOrNil color: c
> was marked TODO and did only draw when it can fall back to FormCanvas
>
> But the offset in the Transformation was ignored, so I changed it into:
>
> drawString: s from: firstIndex to: lastIndex in: boundsRect font:
> fontOrNil color: c
>   (self ifNoTransformWithIn: boundsRect)
>       ifTrue:[ | offset |
>       offset := transform a13 @ transform a23.
>
>       ^super drawString: s from: firstIndex to: lastIndex in: boundsRect
> + offset font: fontOrNil color: c]
>
>
> and uploaded a iSqueak3.8 package Balloon-jl.4 to the
> source.impara.de/Stuff
>
> - Jens Lincke -
>
> _______________________________________________
> Balloon mailing list
> Balloon@...
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon
>

_______________________________________________
Balloon mailing list
Balloon@...
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon

[Jens Lincke]

here is the changeset

Andreas Raab schrieb:

> Can you email me the patch?
>
> Thanks,
>   - Andreas
>
> Jens Lincke wrote:
>> Hi,
>>
>> I found a bug in the BalloonCanvas when drawing a String with an
>> offset transformation
>>
>> the method
>> drawString: s from: firstIndex to: lastIndex in: boundsRect font:
>> fontOrNil color: c
>> was marked TODO and did only draw when it can fall back to FormCanvas
>>
>> But the offset in the Transformation was ignored, so I changed it into:
>>
>> drawString: s from: firstIndex to: lastIndex in: boundsRect font:
>> fontOrNil color: c
>>   (self ifNoTransformWithIn: boundsRect)
>>       ifTrue:[ | offset |
>>       offset := transform a13 @ transform a23.
>>
>>       ^super drawString: s from: firstIndex to: lastIndex in:
>> boundsRect + offset font: fontOrNil color: c]
>>
>>
>> and uploaded a iSqueak3.8 package Balloon-jl.4 to the
>> source.impara.de/Stuff
>>
>> - Jens Lincke -
>>
>> _______________________________________________
>> Balloon mailing list
>> Balloon@...
>> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon
>>

_______________________________________________
Balloon mailing list
Balloon@...
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon

[Jens Lincke]

Hi,

I added drawing of a red rectangle, to show that there is something that
can not be drawn
in the second change set. It would be better to actually fix this
method, but I think, for that we now have Rome...

Jens Lincke schrieb:

> here is the changeset
>
> Andreas Raab schrieb:
>> Can you email me the patch?
>>
>> Thanks,
>>   - Andreas
>>
>> Jens Lincke wrote:
>>> Hi,
>>>
>>> I found a bug in the BalloonCanvas when drawing a String with an
>>> offset transformation
>>>
>>> the method
>>> drawString: s from: firstIndex to: lastIndex in: boundsRect font:
>>> fontOrNil color: c
>>> was marked TODO and did only draw when it can fall back to FormCanvas
>>>
>>> But the offset in the Transformation was ignored, so I changed it into:
>>>
>>> drawString: s from: firstIndex to: lastIndex in: boundsRect font:
>>> fontOrNil color: c
>>>   (self ifNoTransformWithIn: boundsRect)
>>>       ifTrue:[ | offset |
>>>       offset := transform a13 @ transform a23.
>>>
>>>       ^super drawString: s from: firstIndex to: lastIndex in:
>>> boundsRect + offset font: fontOrNil color: c]
>>>
>>>
>>> and uploaded a iSqueak3.8 package Balloon-jl.4 to the
>>> source.impara.de/Stuff
>>>
>>> - Jens Lincke -
>>>
>>> _______________________________________________
>>> Balloon mailing list
>>> Balloon@...
>>> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon
>>>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Balloon mailing list
> Balloon@...
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon
>  

_______________________________________________
Balloon mailing list
Balloon@...
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon