|

»

»

»

wxWidgets - Dev

#9948: Open page by default browser may fail

View: New views

7 Messages — Rating Filter: Alert me

	#9948: Open page by default browser may fail by wxTrac :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Ticket URL: <http://trac.wxwidgets.org/ticket/9948> #9948: Open page by default browser may fail ---------------------+------------------------------------------------------ Reporter: AlexeyT \| Owner: Type: defect \| Status: new Priority: normal \| Milestone: Component: wxMSW \| Version: 2.8.x Keywords: \| Blockedby: Patch: 1 \| Blocking: ---------------------+------------------------------------------------------ Step to reproduce: 1) Delete registry key "HKEY_CLASSES_ROOT\http\shell\open\ddeexec" 2) Try open any page with wxLaunchDefaultBrowser(wxT("http://www.example.com"), wxBROWSER_NEW_WINDOW); 3) Needed page is opened, but user can see 2 error message: first - "File http://www.example.com" not found second - "12:39:20: Can’t open registry key ‘HKCR\http\shell\open\DDEExec\topic’ (error 2: the system cannot find the file specified.)" In any case this is not good behaviour. I create patch which solved both of problem -- Ticket URL: <http://trac.wxwidgets.org/ticket/9948> _______________________________________________ wx-dev mailing list wx-dev@... http://lists.wxwidgets.org/mailman/listinfo/wx-dev
	Re: #9948: Open page by default browser may fail by wxTrac :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:1> #9948: Open page by default browser may fail ----------------------+----------------------------------------------------- Reporter: AlexeyT \| Owner: Type: defect \| Status: new Priority: normal \| Milestone: Component: wxMSW \| Version: 2.8.x Resolution: \| Keywords: Blockedby: \| Patch: 1 Blocking: \| ----------------------+----------------------------------------------------- Comment(by AlexeyT): This patch fix "open" behaviour for some browser, which not write any information for DDE (for example, Google Chrome and some others). -- Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:1> _______________________________________________ wx-dev mailing list wx-dev@... http://lists.wxwidgets.org/mailman/listinfo/wx-dev
	Re: #9948: Open page by default browser may fail by wxTrac :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:2> #9948: Open page by default browser may fail ----------------------+----------------------------------------------------- Reporter: AlexeyT \| Owner: Type: defect \| Status: infoneeded_new Priority: normal \| Milestone: Component: wxMSW \| Version: 2.8.x Resolution: \| Keywords: Blockedby: \| Patch: 1 Blocking: \| ----------------------+----------------------------------------------------- Changes (by vadz): * status: new => infoneeded_new Comment: I understand the first part of the patch but I don't really understand why is SEE_MASK_FLAG_NO_UI needed. If the browser does get launched, don't we want to see an error message if opening the URL fails? Thanks! -- Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:2> _______________________________________________ wx-dev mailing list wx-dev@... http://lists.wxwidgets.org/mailman/listinfo/wx-dev
	Re: #9948: Open page by default browser may fail by wxTrac :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:3> #9948: Open page by default browser may fail ----------------------+----------------------------------------------------- Reporter: AlexeyT \| Owner: Type: defect \| Status: new Priority: normal \| Milestone: Component: wxMSW \| Version: 2.8.x Resolution: \| Keywords: Blockedby: \| Patch: 1 Blocking: \| ----------------------+----------------------------------------------------- Changes (by AlexeyT): * status: infoneeded_new => new Comment: Replying to [comment:2 vadz]: > I understand the first part of the patch but I don't really understand why is SEE_MASK_FLAG_NO_UI needed. If the browser does get launched, don't we want to see an error message if opening the URL fails? > > Thanks! Without flag SEE_MASK_FLAG_NO_UI browser started with needed page, but also user see message (in message box): "File http://yourpage not found". -- Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:3> _______________________________________________ wx-dev mailing list wx-dev@... http://lists.wxwidgets.org/mailman/listinfo/wx-dev
	Re: #9948: Open page by default browser may fail by wxTrac :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:4> #9948: Open page by default browser may fail ----------------------+----------------------------------------------------- Reporter: AlexeyT \| Owner: Type: defect \| Status: new Priority: normal \| Milestone: Component: wxMSW \| Version: 2.8.x Resolution: \| Keywords: Blockedby: \| Patch: 1 Blocking: \| ----------------------+----------------------------------------------------- Comment(by AlexeyT): Replying to [comment:2 vadz]: > I understand the first part of the patch but I don't really understand why is SEE_MASK_FLAG_NO_UI needed. If the browser does get launched, don't we want to see an error message if opening the URL fails? > > Thanks! Some more information: In my case error message write for ANY web page (exists or not). Configuration: Win XP + Firefox (with delete reg keys, which mention before) or Google Chrome -- Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:4> _______________________________________________ wx-dev mailing list wx-dev@... http://lists.wxwidgets.org/mailman/listinfo/wx-dev
	Re: #9948: Open page by default browser may fail by wxTrac :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:5> #9948: Open page by default browser may fail ----------------------+----------------------------------------------------- Reporter: AlexeyT \| Owner: Type: defect \| Status: new Priority: normal \| Milestone: Component: wxMSW \| Version: 2.8.x Resolution: \| Keywords: Blockedby: \| Patch: 1 Blocking: \| ----------------------+----------------------------------------------------- Comment(by AlexeyT): Can you apply this patch? -- Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:5> _______________________________________________ wx-dev mailing list wx-dev@... http://lists.wxwidgets.org/mailman/listinfo/wx-dev
	Re: #9948: Open page by default browser may fail by wxTrac :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:6> #9948: Open page by default browser may fail -----------------------------+---------------------------------------------- Reporter: AlexeyT \| Owner: Type: defect \| Status: portneeded Priority: low \| Milestone: 2.8.10 Component: wxMSW \| Version: 2.8.x Resolution: port to stable \| Keywords: ShellExecute chrome Blockedby: \| Patch: 1 Blocking: \| -----------------------------+---------------------------------------------- Changes (by vadz): * keywords: => ShellExecute chrome * priority: normal => low * status: new => portneeded * resolution: => port to stable * milestone: => 2.8.10 Comment: Replying to [comment:3 AlexeyT]: > Without flag SEE_MASK_FLAG_NO_UI browser started with needed page, but also user see message (in message box): "File http://yourpage not found". This looks like a bug in your browser (if it's Chrome, I wouldn't be surprised...). I did add SEE_MASK_FLAG_NO_UI but if we discover that it hides real errors with other browsers we could remove it again, the browser really shouldn't do whatever it does that makes ShellExecute() think that it's failed. Anyhow, I've applied this as r55594 to the trunk, it could be backported to 2.8 later if no problems are found, thanks. -- Ticket URL: <http://trac.wxwidgets.org/ticket/9948#comment:6> _______________________________________________ wx-dev mailing list wx-dev@... http://lists.wxwidgets.org/mailman/listinfo/wx-dev

LightInTheBox - Buy quality products at wholesale price!