#6604: auto response causes msn error pop-ups

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |     Owner:  khc  
     Type:  defect     |    Status:  new  
Component:  MSN        |   Version:  2.4.3
 Keywords:             |  
-----------------------+----------------------------------------------------
 Users of the bot-sentry plugin have reported this issue here:

 https://sourceforge.net/tracker/index.php?func=detail&aid=2002718&group_id=156021&atid=798112

 Essentially, when auto-responding, this causes a new window to open to
 report a switchboard error trying to send the message to the msn user.

 Bot sentry listens for the receiving-im-msg signal in order to possibly
 block the new message.  However it checks to see if there is already an
 open conversation, and if there is, the new message will NOT be blocked.
 Unfortunately, the MSN error process directly opens a new conversation,
 effectively bypassing any chance of bot-sentry interception.

 Possible fixes are:

 1.  The patch attached to the bot-sentry bug.

 2.  Notice that bot-sentry sent the message using the
 PURPLE_MESSAGE_AUTO_RESP flag and don't bother to report the switchboard
 error.

 Threads on this issue are here:

 http://pidgin.im/pipermail/devel/2008-July/006291.html
 http://pidgin.im/pipermail/devel/2008-July/006432.html

--
Ticket URL: <http://developer.pidgin.im/ticket/6604>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------
Description changed by deckrider:

Old description:

> Users of the bot-sentry plugin have reported this issue here:
>
> https://sourceforge.net/tracker/index.php?func=detail&aid=2002718&group_id=156021&atid=798112
>
> Essentially, when auto-responding, this causes a new window to open to
> report a switchboard error trying to send the message to the msn user.
>
> Bot sentry listens for the receiving-im-msg signal in order to possibly
> block the new message.  However it checks to see if there is already an
> open conversation, and if there is, the new message will NOT be blocked.
> Unfortunately, the MSN error process directly opens a new conversation,
> effectively bypassing any chance of bot-sentry interception.
>
> Possible fixes are:
>
> 1.  The patch attached to the bot-sentry bug.
>
> 2.  Notice that bot-sentry sent the message using the
> PURPLE_MESSAGE_AUTO_RESP flag and don't bother to report the switchboard
> error.
>
> Threads on this issue are here:
>
> http://pidgin.im/pipermail/devel/2008-July/006291.html
> http://pidgin.im/pipermail/devel/2008-July/006432.html

New description:

 Users of the bot-sentry plugin have reported this issue here:

 https://sourceforge.net/tracker/index.php?func=detail&aid=2002718&group_id=156021&atid=798112

 Essentially, when auto-responding, this causes a new window to open to
 report a switchboard error trying to send the message to the msn user.

 Bot sentry listens for the receiving-im-msg signal in order to possibly
 block the new message.  However it checks to see if there is already an
 open conversation, and if there is, the new message will NOT be blocked.
 Unfortunately, the MSN error process directly opens a new conversation,
 effectively bypassing any chance of bot-sentry interception.

 Possible fixes are:

 1.  The patch attached to the bot-sentry bug.

 2.  Notice that bot-sentry sent the message using the
 PURPLE_MESSAGE_AUTO_RESP flag and don't bother to report the switchboard
 error.

 Threads on this issue are here:

 http://pidgin.im/pipermail/devel/2008-July/006291.html[[BR]]
 http://pidgin.im/pipermail/devel/2008-July/006432.html

--

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:1>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------
Description changed by deckrider:

Old description:

> Users of the bot-sentry plugin have reported this issue here:
>
> https://sourceforge.net/tracker/index.php?func=detail&aid=2002718&group_id=156021&atid=798112
>
> Essentially, when auto-responding, this causes a new window to open to
> report a switchboard error trying to send the message to the msn user.
>
> Bot sentry listens for the receiving-im-msg signal in order to possibly
> block the new message.  However it checks to see if there is already an
> open conversation, and if there is, the new message will NOT be blocked.
> Unfortunately, the MSN error process directly opens a new conversation,
> effectively bypassing any chance of bot-sentry interception.
>
> Possible fixes are:
>
> 1.  The patch attached to the bot-sentry bug.
>
> 2.  Notice that bot-sentry sent the message using the
> PURPLE_MESSAGE_AUTO_RESP flag and don't bother to report the switchboard
> error.
>
> Threads on this issue are here:
>
> http://pidgin.im/pipermail/devel/2008-July/006291.html[[BR]]
> http://pidgin.im/pipermail/devel/2008-July/006432.html

New description:

 Users of the bot-sentry plugin have reported this issue here:

 https://sourceforge.net/tracker/index.php?func=detail&aid=2002718&group_id=156021&atid=798112

 Essentially, when auto-responding, this causes a new window to open to
 report a switchboard error trying to send the message to the msn user.

 Bot sentry listens for the receiving-im-msg signal in order to possibly
 block the new message.  However it checks to see if there is already an
 open conversation, and if there is, the new message will NOT be blocked.
 Unfortunately, the MSN error process directly opens a new conversation,
 effectively bypassing any chance of bot-sentry interception.

 Possible fixes are:

 1.  The patch attached to the bot-sentry bug.

 2.  Notice that bot-sentry sent the message using the
 PURPLE_MESSAGE_AUTO_RESP flag and don't bother to report the switchboard
 error.

 Threads on this issue are here:

 http://pidgin.im/pipermail/devel/2008-July/006291.html

 http://pidgin.im/pipermail/devel/2008-July/006432.html

--

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:2>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by Universe_JDJ):

 cc me

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:3>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by khc):

 does this patch work for you? Note that you need to revert whatever patch
 you are using too. Also note that I've not tested this.

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:4>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by deckrider):

 I applied this patch to pidgin-2.4.3 and since for windows, only msnp9
 seems to be built, I patched that one as shown in the patch I'm uploading
 here, based on your patch.

 I've uploaded the resulting libmsn.dll for bot-sentry windows users to try
 at:

 https://sourceforge.net/tracker/index.php?func=detail&aid=2002718&group_id=156021&atid=798112

 Hopefully there will be some feedback.

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:5>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by deckrider):

 So far, I've only been aware of positive (and no negative) experiences
 regarding your patch.

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:6>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by mark-t):

 I've been using the patch for a week or so, and I've yet to get one of
 those messages, whereas I used to get several per day. I'd say the patch
 is ready to commit, provided you update it to apply to 2.5.1. The trailing
 context for the libpurple/protocols/msn/msn.c portion has changed.

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:7>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by smu johnson):

 Replying to [comment:4 khc]:
 > does this patch work for you? Note that you need to revert whatever
 patch you are using too. Also note that I've not tested this.

 Dear khc,

 Are you a pidgin developer?  Could you please implement this permenantly
 in a future Pidgin release?  I desperately need this patch but am too
 stupid to figure out how to apply it and compile it in Windows, as well as
 too lazy to do it every time for each new pidgin version.

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:8>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by kanntara):

 I tried using the dll file that was zipped at the sourceforge site.  It
 works great for eliminating the bot issue... but it doesn't allow me to
 start a conversation with someone who is offline.  I have a few friends
 for their other personal reasons have their status listed as offline
 constantly.  They can start the conversation, but if something happens
 (e.g. I need to restart the system, etc), I have to wait for them to re-
 initiate the conversation.

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:9>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by khc):

 I think that dll is based on an old version that didn't support offline
 messaging.

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:10>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by kanntara):

 Would make sense.  Any way of getting an updated dll file to test?

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:11>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc
     Type:  defect     |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.4.3      |   Resolution:    
 Keywords:             |  
-----------------------+----------------------------------------------------

Comment(by smu johnson):

 Any way to find out of this change can be made permenantly into any future
 release of Pidgin and solve everyone's issue?

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:12>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------+----------------------------------------------------
 Reporter:  deckrider  |        Owner:  khc    
     Type:  defect     |       Status:  pending
Milestone:             |    Component:  MSN    
  Version:  2.4.3      |   Resolution:        
 Keywords:             |  
-----------------------+----------------------------------------------------
Changes (by rlaager):

  * status:  new => pending


Comment:

 (10:14:15) rlaager: rekkanoryo: I think #6604 is ready to commit. If you
 want to do it, commit both patches at once (one is msnp14 and the other is
 the same change to msnp9) with khc@... as the author.

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:13>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#6604: auto response causes msn error pop-ups
-----------------------------------------+----------------------------------
 Reporter:  deckrider                    |        Owner:  khc
     Type:  defect                       |       Status:  new
Milestone:  Patches Needing Improvement  |    Component:  MSN
  Version:  2.4.3                        |   Resolution:    
 Keywords:                               |  
-----------------------------------------+----------------------------------
Changes (by rlaager):

  * status:  pending => new
  * milestone:  => Patches Needing Improvement


Comment:

 (21:54:03) khc: we shouldn't wait for the ack, and then have the timeout
 code do nothing[[br]]
 (21:54:12) khc: we should just not wait for those messages to begin
 with[[br]]
 (21:54:34) khc: which probably just involves changing release_msg()

--
Ticket URL: <http://developer.pidgin.im/ticket/6604#comment:14>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker