[ checkstyle-Patches-1952556 ] Findbugs support, fixed random bugs

[SourceForge.net]

Patches item #1952556, was opened at 2008-04-27 13:12
Message generated for change (Comment added) made by oburn
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=397080&aid=1952556&group_id=29721

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Travis Schneeberger (tschneeberger)
>Assigned to: Oliver Burn (oburn)
Summary: Findbugs support, fixed random bugs

Initial Comment:
Oliver,

So I went to generate today's patch and realized that many of the bugs I had just fixed you had also fixed causing either conflicts or no changes found:-)  So I'm afraid that my patch is a bit smaller now.

I am including two patch files and a zip file containing all of the libraries required for findbugs.

In the first patch file I have corrected some of the bugs that findbugs found.  These include proper stream closing, and having certain classes implement Serializable, more efficient toArray usage, and a long mathematical bug (which wouldn't have actually caused a problem but it makes findbugs happy).

The second patch file contains the findbugs target.  I decided to not rely on the ANT_HOME property on the local machine.  Instead, all of the required libraries for findbugs are referenced from the lib folder.  This way anyone can run the build file.  The downside to this is that there are quite a few of required libraries.

I have also included a zip file that contains all of the required libraries necessary to run findbugs.  These libraries should be placed in the checkstyle/lib folder.  You could also get a copy of these libraries by downloading the latest version of findbugs.

On my PC findbugs consistently ran in 2 minutes with max effort set.  I did however, have to increase the Java heap memory limit.  That is a setting in the findbugs task.

Let me know if everything is up to par or if there is anything else I should do.  As usual, everything passed the gump test.

Thanks,
Travis

----------------------------------------------------------------------

>Comment By: Oliver Burn (oburn)
Date: 2008-07-02 13:22

Message:
Logged In: YES
user_id=218824
Originator: NO

Thanks - I applied most of the fixes. I did not apply the one with the
duplicate line detection due to concern about performance degradation.

I do not want to encumber the Checkstyle build with all the Findbugs
stuff, so I will not add it to the repository.

----------------------------------------------------------------------

Comment By: Travis Schneeberger (tschneeberger)
Date: 2008-04-27 13:24

Message:
Logged In: YES
user_id=2006707
Originator: YES

Well I guess I cannot upload the libraries.  They are too large.

Anyway below is a list of the files that must be placed in the lib folder.
 You can get the required libraries from the findbugs-1.3.3\lib folder.

asm-3.0.jar
asm-commons-3.0.jar
asm-tree-3.0.jar
bcel.jar
coreplugin.jar
dom4j-full.jar
findbugs-ant.jar
findbugs.jar
jsr305.jar

----------------------------------------------------------------------

Comment By: Travis Schneeberger (tschneeberger)
Date: 2008-04-27 13:12

Message:
Logged In: YES
user_id=2006707
Originator: YES

File Added: findbugs support.patch

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=397080&aid=1952556&group_id=29721

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Checkstyle-devel mailing list
Checkstyle-devel@...
https://lists.sourceforge.net/lists/listinfo/checkstyle-devel